fix: use attestation v1 endpoints pre-electra - #7024
Merged
Conversation
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## electra-fork-rebasejul30 #7024 +/- ##
===========================================================
Coverage ? 49.38%
===========================================================
Files ? 589
Lines ? 39200
Branches ? 2243
===========================================================
Hits ? 19357
Misses ? 19802
Partials ? 41 |
Member
Author
|
Need to merge #6998 before this as v1 attestation apis are currently not working |
nflaig
marked this pull request as draft
August 14, 2024 10:38
nflaig
marked this pull request as ready for review
August 16, 2024 21:57
wemeetagain
approved these changes
Aug 16, 2024
Member
Author
|
It looks like the CI is no longer able to download spec tests, might need to increase timeout |
Member
It looks like general and mainnet are downloaded pretty quickly but minimal seems to be taking a long time. Wonder if there's any restriction/limitation in place. |
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix: use attestation v1 endpoints pre-electra * Adapt block attestations error message with pool apis
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix: use attestation v1 endpoints pre-electra * Adapt block attestations error message with pool apis
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix: use attestation v1 endpoints pre-electra * Adapt block attestations error message with pool apis
Member
|
🎉 This PR is included in v1.22.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix compatiblity with other clients that have not yet implemented attestation v2 endpoints.
Description
Use attestation v1 endpoints pre-electra, after fork transition, the validator client will start using v2 apis.