fix: cached balances in epoch transition

[twoeths]

Motivation

• Use cached balances in processEffectiveBalanceUpdates
• Use state.validators.getReadonly() if possible

Description

• Update cached balances in processPendingBalanceDeposits and processPendingConsolidations
• Use it in processEffectiveBalanceUpdates

[ensi321]

I was looking into this issue as well.

If I understand correctly, the reason why EpochTransitionCache.balances is not correct because it wasn't updated in processPendingConsolidations and processPendingBalanceDeposits?

[twoeths]

I was looking into this issue as well.

If I understand correctly, the reason why EpochTransitionCache.balances is not correct because it wasn't updated in processPendingConsolidations and processPendingBalanceDeposits?

@ensi321 yes it is, but I wasn't able to confirm through spec test

[codecov]

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.

Project coverage is 49.36%. Comparing base (bbc2301) to head (3a80edd).

Additional details and impacted files

@@                     Coverage Diff                      @@
##           electra-fork-rebasejul30    #7018      +/-   ##
============================================================
- Coverage                     49.37%   49.36%   -0.02%     
============================================================
  Files                           589      589              
  Lines                         39137    39151      +14     
  Branches                       2235     2238       +3     
============================================================
+ Hits                          19325    19327       +2     
- Misses                        19771    19783      +12     
  Partials                         41       41              

[ensi321]

Looks like spec test is still passing when introducing back cache.balances in processEffectiveBalanceUpdates.

benchmark is not ran in this PR since the target branch is not unstable.

I ran processEffectiveBalanceUpdates.test.ts with unstable, electra-fork-rebasejul30 and te/cached_balances to compare the result.

unstable:

  phase0 processEffectiveBalanceUpdates
    ✔ phase0 processEffectiveBalanceUpdates - 250000 normalcase           521.4966 ops/s    1.917558 ms/op        -        234 runs   2.02 s
    ✔ phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5        544.3978 ops/s    1.836892 ms/op        -        273 runs   2.01 s

electra-fork-rebasejul30:

  phase0 processEffectiveBalanceUpdates
    ✔ phase0 processEffectiveBalanceUpdates - 250000 normalcase           197.5429 ops/s    5.062191 ms/op        -        103 runs   1.66 s
    ✔ phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5        206.3787 ops/s    4.845461 ms/op        -         70 runs   1.42 s

te/cached_balances

  phase0 processEffectiveBalanceUpdates
    ✔ phase0 processEffectiveBalanceUpdates - 250000 normalcase           557.8163 ops/s    1.792705 ms/op        -        175 runs   1.80 s
    ✔ phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5        562.7605 ops/s    1.776955 ms/op        -        488 runs   2.65 s

Suffice to say in this PR processEffectiveBalanceUpdates passes both perf test and spec test so this fix is effective.

[ensi321]

lgtm

[wemeetagain]

🎉 This PR is included in v1.22.0 🎉