fix: align BeaconBlockBody and BlindedBeaconBlockBody - #6782
Merged
Conversation
nflaig
reviewed
May 15, 2024
nflaig
approved these changes
May 16, 2024
nflaig
left a comment
nflaig
left a comment
Member
There was a problem hiding this comment.
LGTM, I removed the type hacks in tests and fixed the assertion to use toBeWithMessage
g11tech
pushed a commit
that referenced
this pull request
May 24, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
to g11tech/lodestar
that referenced
this pull request
Jun 19, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jul 1, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jul 30, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jul 31, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Aug 2, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix: align BeaconBlockBody and BlindedBeaconBlockBody * Remove type hacks in test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Member
Author
|
馃帀 This PR is included in v1.22.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description