Skip to content

fix: process effective balance updates #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twoeths wants to merge 1 commit into from
Closed

fix: process effective balance updates #6778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/state-transition/src/epoch/processEffectiveBalanceUpdates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,14 @@ export function processEffectiveBalanceUpdates(
const balance = balances[i];

// PERF: It's faster to access to get() every single element (4ms) than to convert to regular array then loop (9ms)
let effectiveBalanceIncrement = effectiveBalanceIncrements[i];
let effectiveBalance = effectiveBalanceIncrement * EFFECTIVE_BALANCE_INCREMENT;
// TODO-electra: figure out why effectiveBalanceIncrements and cache.balances above are not populated correctly
// let effectiveBalanceIncrement = effectiveBalanceIncrements[i];
// let effectiveBalance = effectiveBalanceIncrement * EFFECTIVE_BALANCE_INCREMENT;
// Update the state tree
// Should happen rarely, so it's fine to update the tree
const validator = validators.get(i);
let effectiveBalance = validator.effectiveBalance;
let effectiveBalanceIncrement = Math.floor(effectiveBalance / EFFECTIVE_BALANCE_INCREMENT);
let effectiveBalanceLimit;

if (
Expand All @@ -60,10 +66,6 @@ export function processEffectiveBalanceUpdates(
// Too small. Check effectiveBalance < MAX_EFFECTIVE_BALANCE to prevent unnecessary updates
effectiveBalance + UPWARD_THRESHOLD < balance
) {
// Update the state tree
// Should happen rarely, so it's fine to update the tree
const validator = validators.get(i);

if (fork < ForkSeq.electra) {
effectiveBalanceLimit = MAX_EFFECTIVE_BALANCE;
} else {
Expand Down