chore: release 1.18.1 - #6760
Merged
Merged
Conversation
* feat: disable flood publish * feat: add network.disableFloodPublish cli flag * chore: address PR comments
philknows
marked this pull request as draft
May 13, 2024 07:30
philknows
marked this pull request as ready for review
May 13, 2024 07:30
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
twoeths
approved these changes
May 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable #6760 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 557 557
Lines 59201 59214 +13
Branches 1914 1915 +1
=======================================
+ Hits 36629 36638 +9
- Misses 22529 22533 +4
Partials 43 43 |
Member
|
馃帀 This PR is included in v1.18.1 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hotfix to allow disabling flood publish on gossipsub due to a potential for higher missed blocks with peer increase from #5799 .
Description
Includes #6755. Set by using hidden flag
--network.disableFloodPublish