chore: update nodejs to latest 22 by nazarhussain · Pull Request #6729 · ChainSafe/lodestar

nazarhussain · 2024-05-03T04:37:01Z

Motivation

Use the latest dependencies

Description

Upgrade Nodejs package limit
Use latest nodejs in workflows

Steps to test or reproduce

Run all tests

nazarhussain · 2024-05-03T04:38:25Z

Currently blocked by mscdex/cpu-features#23

codecov · 2024-05-03T04:52:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.88%. Comparing base (3c5bb15) to head (90d1704).
Report is 2 commits behind head on unstable.

❗ Current head 90d1704 differs from pull request most recent head 6fc54a0

Please upload reports for the commit 6fc54a0 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #6729      +/-   ##
============================================
- Coverage     62.20%   61.88%   -0.33%     
============================================
  Files           570      562       -8     
  Lines         59987    59309     -678     
  Branches       1977     1917      -60     
============================================
- Hits          37316    36701     -615     
+ Misses        22628    22565      -63     
  Partials         43       43

nflaig · 2024-05-03T09:20:51Z

      fail-fast: false
      matrix:
-        node: [20]
+        node: [22]


Ideally we wanna run unit tests against both versions, might be too expensive though

We had been running tests for latest version only. If we had earlier [18, 20] then would make more sense to replace one version.

github-actions · 2024-05-03T16:02:57Z

⚠️ Performance Alert ⚠️

Possible performance regression was detected for some benchmarks.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold.

Benchmark suite	Current: `43e5f2a`	Previous: `95ce044`	Ratio
Map get x1000	6.7980 ns/op	0.88200 ns/op	7.71
bitArray.getTrueBitIndexes() bitLen 512	13.943 us/op	3.7430 us/op	3.73

🚀🚀 Significant benchmark improvement detected

Benchmark suite	Current: `43e5f2a`	Previous: `95ce044`	Ratio
BeaconState.hashTreeRoot - No change	282.00 ns/op	1.1900 us/op	0.24

Full benchmark results

Benchmark suite	Current: `43e5f2a`	Previous: `95ce044`	Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc	1.2472 ms/op	933.55 us/op	1.34
getPubkeys - validatorsArr - req 1000 vs - 250000 vc	56.837 us/op	68.400 us/op	0.83
BLS verify - blst-native	1.2346 ms/op	1.1353 ms/op	1.09
BLS verifyMultipleSignatures 3 - blst-native	2.3958 ms/op	2.2036 ms/op	1.09
BLS verifyMultipleSignatures 8 - blst-native	5.1679 ms/op	4.7314 ms/op	1.09
BLS verifyMultipleSignatures 32 - blst-native	18.735 ms/op	18.048 ms/op	1.04
BLS verifyMultipleSignatures 64 - blst-native	36.896 ms/op	34.439 ms/op	1.07
BLS verifyMultipleSignatures 128 - blst-native	73.443 ms/op	67.997 ms/op	1.08
BLS deserializing 10000 signatures	865.30 ms/op	809.90 ms/op	1.07
BLS deserializing 100000 signatures	8.6661 s/op	8.1736 s/op	1.06
BLS verifyMultipleSignatures - same message - 3 - blst-native	1.2802 ms/op	1.1622 ms/op	1.10
BLS verifyMultipleSignatures - same message - 8 - blst-native	1.4494 ms/op	1.2877 ms/op	1.13
BLS verifyMultipleSignatures - same message - 32 - blst-native	2.2815 ms/op	2.0240 ms/op	1.13
BLS verifyMultipleSignatures - same message - 64 - blst-native	3.4232 ms/op	3.0193 ms/op	1.13
BLS verifyMultipleSignatures - same message - 128 - blst-native	5.5371 ms/op	4.9662 ms/op	1.11
BLS aggregatePubkeys 32 - blst-native	28.138 us/op	25.203 us/op	1.12
BLS aggregatePubkeys 128 - blst-native	110.47 us/op	95.715 us/op	1.15
notSeenSlots=1 numMissedVotes=1 numBadVotes=10	59.216 ms/op	47.724 ms/op	1.24
notSeenSlots=1 numMissedVotes=0 numBadVotes=4	67.647 ms/op	38.568 ms/op	1.75
notSeenSlots=2 numMissedVotes=1 numBadVotes=10	36.827 ms/op	36.910 ms/op	1.00
getSlashingsAndExits - default max	111.68 us/op	203.36 us/op	0.55
getSlashingsAndExits - 2k	416.31 us/op	390.06 us/op	1.07
proposeBlockBody type=full, size=empty	6.0677 ms/op	5.5383 ms/op	1.10
isKnown best case - 1 super set check	501.00 ns/op	667.00 ns/op	0.75
isKnown normal case - 2 super set checks	396.00 ns/op	642.00 ns/op	0.62
isKnown worse case - 16 super set checks	325.00 ns/op	643.00 ns/op	0.51
InMemoryCheckpointStateCache - add get delete	6.7630 us/op	8.3540 us/op	0.81
validate api signedAggregateAndProof - struct	2.4025 ms/op	2.0093 ms/op	1.20
validate gossip signedAggregateAndProof - struct	2.4195 ms/op	2.0311 ms/op	1.19
validate gossip attestation - vc 640000	1.4546 ms/op	1.1334 ms/op	1.28
batch validate gossip attestation - vc 640000 - chunk 32	196.19 us/op	147.52 us/op	1.33
batch validate gossip attestation - vc 640000 - chunk 64	164.28 us/op	130.86 us/op	1.26
batch validate gossip attestation - vc 640000 - chunk 128	171.76 us/op	124.59 us/op	1.38
batch validate gossip attestation - vc 640000 - chunk 256	155.46 us/op	114.86 us/op	1.35
pickEth1Vote - no votes	1.2099 ms/op	876.71 us/op	1.38
pickEth1Vote - max votes	11.249 ms/op	8.6771 ms/op	1.30
pickEth1Vote - Eth1Data hashTreeRoot value x2048	16.372 ms/op	14.971 ms/op	1.09
pickEth1Vote - Eth1Data hashTreeRoot tree x2048	25.555 ms/op	23.169 ms/op	1.10
pickEth1Vote - Eth1Data fastSerialize value x2048	639.07 us/op	410.90 us/op	1.56
pickEth1Vote - Eth1Data fastSerialize tree x2048	7.5631 ms/op	4.7140 ms/op	1.60
bytes32 toHexString	808.00 ns/op	591.00 ns/op	1.37
bytes32 Buffer.toString(hex)	276.00 ns/op	462.00 ns/op	0.60
bytes32 Buffer.toString(hex) from Uint8Array	503.00 ns/op	594.00 ns/op	0.85
bytes32 Buffer.toString(hex) + 0x	275.00 ns/op	454.00 ns/op	0.61
Object access 1 prop	0.22800 ns/op	0.32300 ns/op	0.71
Map access 1 prop	0.15000 ns/op	0.31100 ns/op	0.48
Object get x1000	6.0370 ns/op	5.0070 ns/op	1.21
Map get x1000	6.7980 ns/op	0.88200 ns/op	7.71
Object set x1000	59.948 ns/op	26.278 ns/op	2.28
Map set x1000	41.576 ns/op	17.754 ns/op	2.34
Return object 10000 times	0.36250 ns/op	0.22900 ns/op	1.58
Throw Error 10000 times	4.0472 us/op	2.5931 us/op	1.56
fastMsgIdFn sha256 / 200 bytes	2.6350 us/op	2.0050 us/op	1.31
fastMsgIdFn h32 xxhash / 200 bytes	314.00 ns/op	423.00 ns/op	0.74
fastMsgIdFn h64 xxhash / 200 bytes	292.00 ns/op	467.00 ns/op	0.63
fastMsgIdFn sha256 / 1000 bytes	7.9860 us/op	5.9520 us/op	1.34
fastMsgIdFn h32 xxhash / 1000 bytes	440.00 ns/op	530.00 ns/op	0.83
fastMsgIdFn h64 xxhash / 1000 bytes	370.00 ns/op	528.00 ns/op	0.70
fastMsgIdFn sha256 / 10000 bytes	69.685 us/op	50.133 us/op	1.39
fastMsgIdFn h32 xxhash / 10000 bytes	1.9850 us/op	1.8720 us/op	1.06
fastMsgIdFn h64 xxhash / 10000 bytes	1.2850 us/op	1.3450 us/op	0.96
send data - 1000 256B messages	16.195 ms/op	11.263 ms/op	1.44
send data - 1000 512B messages	22.067 ms/op	13.547 ms/op	1.63
send data - 1000 1024B messages	32.012 ms/op	21.182 ms/op	1.51
send data - 1000 1200B messages	35.783 ms/op	23.629 ms/op	1.51
send data - 1000 2048B messages	39.525 ms/op	30.360 ms/op	1.30
send data - 1000 4096B messages	41.106 ms/op	27.404 ms/op	1.50
send data - 1000 16384B messages	98.663 ms/op	69.336 ms/op	1.42
send data - 1000 65536B messages	304.46 ms/op	279.57 ms/op	1.09
enrSubnets - fastDeserialize 64 bits	1.8250 us/op	1.0920 us/op	1.67
enrSubnets - ssz BitVector 64 bits	523.00 ns/op	557.00 ns/op	0.94
enrSubnets - fastDeserialize 4 bits	224.00 ns/op	322.00 ns/op	0.70
enrSubnets - ssz BitVector 4 bits	565.00 ns/op	556.00 ns/op	1.02
prioritizePeers score -10:0 att 32-0.1 sync 2-0	244.66 us/op	148.72 us/op	1.65
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25	267.63 us/op	195.89 us/op	1.37
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5	421.51 us/op	223.69 us/op	1.88
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75	591.28 us/op	375.70 us/op	1.57
prioritizePeers score 0:0 att 64-1 sync 4-1	1.0806 ms/op	437.38 us/op	2.47
array of 16000 items push then shift	1.8868 us/op	1.3091 us/op	1.44
LinkedList of 16000 items push then shift	11.256 ns/op	6.0850 ns/op	1.85
array of 16000 items push then pop	164.11 ns/op	90.811 ns/op	1.81
LinkedList of 16000 items push then pop	10.753 ns/op	6.0110 ns/op	1.79
array of 24000 items push then shift	2.8698 us/op	1.9852 us/op	1.45
LinkedList of 24000 items push then shift	13.868 ns/op	6.1410 ns/op	2.26
array of 24000 items push then pop	225.51 ns/op	124.78 ns/op	1.81
LinkedList of 24000 items push then pop	9.0170 ns/op	5.9720 ns/op	1.51
intersect bitArray bitLen 8	7.4030 ns/op	5.2960 ns/op	1.40
intersect array and set length 8	110.77 ns/op	48.593 ns/op	2.28
intersect bitArray bitLen 128	31.966 ns/op	29.571 ns/op	1.08
intersect array and set length 128	1.1847 us/op	681.86 ns/op	1.74
bitArray.getTrueBitIndexes() bitLen 128	3.0080 us/op	1.3580 us/op	2.22
bitArray.getTrueBitIndexes() bitLen 248	4.8040 us/op	2.0690 us/op	2.32
bitArray.getTrueBitIndexes() bitLen 512	13.943 us/op	3.7430 us/op	3.73
Buffer.concat 32 items	1.3420 us/op	1.0230 us/op	1.31
Uint8Array.set 32 items	2.3740 us/op	1.6310 us/op	1.46
Set add up to 64 items then delete first	3.1748 us/op	1.7949 us/op	1.77
OrderedSet add up to 64 items then delete first	4.6835 us/op	2.7578 us/op	1.70
Set add up to 64 items then delete last	3.4978 us/op	2.0535 us/op	1.70
OrderedSet add up to 64 items then delete last	5.2107 us/op	3.1094 us/op	1.68
Set add up to 64 items then delete middle	3.4133 us/op	2.0412 us/op	1.67
OrderedSet add up to 64 items then delete middle	7.0525 us/op	4.2191 us/op	1.67
Set add up to 128 items then delete first	7.1227 us/op	4.0645 us/op	1.75
OrderedSet add up to 128 items then delete first	12.283 us/op	6.3470 us/op	1.94
Set add up to 128 items then delete last	7.6758 us/op	4.0704 us/op	1.89
OrderedSet add up to 128 items then delete last	11.774 us/op	5.6515 us/op	2.08
Set add up to 128 items then delete middle	7.1259 us/op	3.6329 us/op	1.96
OrderedSet add up to 128 items then delete middle	18.044 us/op	10.394 us/op	1.74
Set add up to 256 items then delete first	15.012 us/op	7.3421 us/op	2.04
OrderedSet add up to 256 items then delete first	23.218 us/op	12.814 us/op	1.81
Set add up to 256 items then delete last	13.950 us/op	8.9208 us/op	1.56
OrderedSet add up to 256 items then delete last	21.457 us/op	14.739 us/op	1.46
Set add up to 256 items then delete middle	13.592 us/op	7.8054 us/op	1.74
OrderedSet add up to 256 items then delete middle	52.081 us/op	36.154 us/op	1.44
transfer serialized Status (84 B)	1.6170 us/op	1.8550 us/op	0.87
copy serialized Status (84 B)	1.5600 us/op	1.4940 us/op	1.04
transfer serialized SignedVoluntaryExit (112 B)	1.8320 us/op	1.9340 us/op	0.95
copy serialized SignedVoluntaryExit (112 B)	1.6050 us/op	1.5200 us/op	1.06
transfer serialized ProposerSlashing (416 B)	2.3000 us/op	2.4010 us/op	0.96
copy serialized ProposerSlashing (416 B)	2.4530 us/op	2.0250 us/op	1.21
transfer serialized Attestation (485 B)	3.1320 us/op	2.2210 us/op	1.41
copy serialized Attestation (485 B)	2.4350 us/op	2.0280 us/op	1.20
transfer serialized AttesterSlashing (33232 B)	3.1140 us/op	2.2780 us/op	1.37
copy serialized AttesterSlashing (33232 B)	9.4960 us/op	7.8580 us/op	1.21
transfer serialized Small SignedBeaconBlock (128000 B)	3.7010 us/op	2.9800 us/op	1.24
copy serialized Small SignedBeaconBlock (128000 B)	32.530 us/op	34.940 us/op	0.93
transfer serialized Avg SignedBeaconBlock (200000 B)	5.1110 us/op	3.5540 us/op	1.44
copy serialized Avg SignedBeaconBlock (200000 B)	58.944 us/op	57.139 us/op	1.03
transfer serialized BlobsSidecar (524380 B)	6.1010 us/op	5.3390 us/op	1.14
copy serialized BlobsSidecar (524380 B)	183.83 us/op	148.37 us/op	1.24
transfer serialized Big SignedBeaconBlock (1000000 B)	4.4380 us/op	4.6480 us/op	0.95
copy serialized Big SignedBeaconBlock (1000000 B)	248.86 us/op	309.19 us/op	0.80
pass gossip attestations to forkchoice per slot	3.5804 ms/op	3.3913 ms/op	1.06
forkChoice updateHead vc 100000 bc 64 eq 0	1.2664 ms/op	508.00 us/op	2.49
forkChoice updateHead vc 600000 bc 64 eq 0	4.0732 ms/op	4.3063 ms/op	0.95
forkChoice updateHead vc 1000000 bc 64 eq 0	7.5748 ms/op	5.7017 ms/op	1.33
forkChoice updateHead vc 600000 bc 320 eq 0	4.4641 ms/op	3.3869 ms/op	1.32
forkChoice updateHead vc 600000 bc 1200 eq 0	4.6323 ms/op	3.4448 ms/op	1.34
forkChoice updateHead vc 600000 bc 7200 eq 0	5.2706 ms/op	4.1135 ms/op	1.28
forkChoice updateHead vc 600000 bc 64 eq 1000	12.544 ms/op	10.783 ms/op	1.16
forkChoice updateHead vc 600000 bc 64 eq 10000	11.736 ms/op	11.287 ms/op	1.04
forkChoice updateHead vc 600000 bc 64 eq 300000	21.974 ms/op	42.356 ms/op	0.52
computeDeltas 500000 validators 300 proto nodes	5.1138 ms/op	3.9934 ms/op	1.28
computeDeltas 500000 validators 1200 proto nodes	6.3622 ms/op	3.9173 ms/op	1.62
computeDeltas 500000 validators 7200 proto nodes	5.1395 ms/op	3.7280 ms/op	1.38
computeDeltas 750000 validators 300 proto nodes	5.6542 ms/op	5.8149 ms/op	0.97
computeDeltas 750000 validators 1200 proto nodes	5.5035 ms/op	6.4169 ms/op	0.86
computeDeltas 750000 validators 7200 proto nodes	5.6076 ms/op	5.7637 ms/op	0.97
computeDeltas 1400000 validators 300 proto nodes	10.511 ms/op	11.176 ms/op	0.94
computeDeltas 1400000 validators 1200 proto nodes	10.835 ms/op	11.797 ms/op	0.92
computeDeltas 1400000 validators 7200 proto nodes	12.030 ms/op	12.708 ms/op	0.95
computeDeltas 2100000 validators 300 proto nodes	18.991 ms/op	15.833 ms/op	1.20
computeDeltas 2100000 validators 1200 proto nodes	18.946 ms/op	16.412 ms/op	1.15
computeDeltas 2100000 validators 7200 proto nodes	17.597 ms/op	15.906 ms/op	1.11
altair processAttestation - 250000 vs - 7PWei normalcase	1.9918 ms/op	1.7294 ms/op	1.15
altair processAttestation - 250000 vs - 7PWei worstcase	4.1729 ms/op	2.7068 ms/op	1.54
altair processAttestation - setStatus - 1/6 committees join	108.52 us/op	138.28 us/op	0.78
altair processAttestation - setStatus - 1/3 committees join	187.39 us/op	264.40 us/op	0.71
altair processAttestation - setStatus - 1/2 committees join	263.59 us/op	387.66 us/op	0.68
altair processAttestation - setStatus - 2/3 committees join	389.56 us/op	451.97 us/op	0.86
altair processAttestation - setStatus - 4/5 committees join	606.69 us/op	602.82 us/op	1.01
altair processAttestation - setStatus - 100% committees join	831.42 us/op	812.61 us/op	1.02
altair processBlock - 250000 vs - 7PWei normalcase	6.4265 ms/op	10.263 ms/op	0.63
altair processBlock - 250000 vs - 7PWei normalcase hashState	34.695 ms/op	41.183 ms/op	0.84
altair processBlock - 250000 vs - 7PWei worstcase	54.627 ms/op	34.517 ms/op	1.58
altair processBlock - 250000 vs - 7PWei worstcase hashState	116.08 ms/op	98.026 ms/op	1.18
phase0 processBlock - 250000 vs - 7PWei normalcase	3.4652 ms/op	3.0351 ms/op	1.14
phase0 processBlock - 250000 vs - 7PWei worstcase	34.728 ms/op	33.834 ms/op	1.03
altair processEth1Data - 250000 vs - 7PWei normalcase	724.08 us/op	670.63 us/op	1.08
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15	11.747 us/op	14.889 us/op	0.79
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219	50.908 us/op	43.652 us/op	1.17
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42	17.938 us/op	23.102 us/op	0.78
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18	11.870 us/op	19.744 us/op	0.60
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020	166.09 us/op	139.87 us/op	1.19
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777	1.2996 ms/op	1.4140 ms/op	0.92
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384	1.4215 ms/op	1.3973 ms/op	1.02
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384	1.5305 ms/op	1.5230 ms/op	1.00
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384	3.9583 ms/op	3.2693 ms/op	1.21
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384	2.1271 ms/op	2.1623 ms/op	0.98
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384	5.2685 ms/op	4.6598 ms/op	1.13
Tree 40 250000 create	497.19 ms/op	395.71 ms/op	1.26
Tree 40 250000 get(125000)	181.48 ns/op	149.21 ns/op	1.22
Tree 40 250000 set(125000)	1.6401 us/op	1.3153 us/op	1.25
Tree 40 250000 toArray()	24.702 ms/op	30.081 ms/op	0.82
Tree 40 250000 iterate all - toArray() + loop	25.482 ms/op	28.694 ms/op	0.89
Tree 40 250000 iterate all - get(i)	65.774 ms/op	72.764 ms/op	0.90
MutableVector 250000 create	16.019 ms/op	11.824 ms/op	1.35
MutableVector 250000 get(125000)	7.5310 ns/op	7.2230 ns/op	1.04
MutableVector 250000 set(125000)	599.31 ns/op	457.97 ns/op	1.31
MutableVector 250000 toArray()	5.2767 ms/op	5.2955 ms/op	1.00
MutableVector 250000 iterate all - toArray() + loop	5.3117 ms/op	5.8304 ms/op	0.91
MutableVector 250000 iterate all - get(i)	1.6749 ms/op	1.4013 ms/op	1.20
Array 250000 create	4.0060 ms/op	5.1650 ms/op	0.78
Array 250000 clone - spread	1.8224 ms/op	1.6866 ms/op	1.08
Array 250000 get(125000)	0.44700 ns/op	1.4440 ns/op	0.31
Array 250000 set(125000)	0.47600 ns/op	1.5290 ns/op	0.31
Array 250000 iterate all - loop	94.206 us/op	170.72 us/op	0.55
effectiveBalanceIncrements clone Uint8Array 300000	62.168 us/op	14.010 us/op	4.44
effectiveBalanceIncrements clone MutableVector 300000	137.00 ns/op	549.00 ns/op	0.25
effectiveBalanceIncrements rw all Uint8Array 300000	206.33 us/op	203.51 us/op	1.01
effectiveBalanceIncrements rw all MutableVector 300000	83.058 ms/op	71.092 ms/op	1.17
phase0 afterProcessEpoch - 250000 vs - 7PWei	95.245 ms/op	84.782 ms/op	1.12
phase0 beforeProcessEpoch - 250000 vs - 7PWei	53.165 ms/op	53.434 ms/op	0.99
altair processEpoch - mainnet_e81889	506.46 ms/op	447.02 ms/op	1.13
mainnet_e81889 - altair beforeProcessEpoch	82.546 ms/op	63.406 ms/op	1.30
mainnet_e81889 - altair processJustificationAndFinalization	24.235 us/op	15.368 us/op	1.58
mainnet_e81889 - altair processInactivityUpdates	7.0445 ms/op	5.1160 ms/op	1.38
mainnet_e81889 - altair processRewardsAndPenalties	54.420 ms/op	61.457 ms/op	0.89
mainnet_e81889 - altair processRegistryUpdates	4.4480 us/op	4.5950 us/op	0.97
mainnet_e81889 - altair processSlashings	851.00 ns/op	1.1160 us/op	0.76
mainnet_e81889 - altair processEth1DataReset	770.00 ns/op	856.00 ns/op	0.90
mainnet_e81889 - altair processEffectiveBalanceUpdates	1.9083 ms/op	1.1215 ms/op	1.70
mainnet_e81889 - altair processSlashingsReset	6.2290 us/op	4.5010 us/op	1.38
mainnet_e81889 - altair processRandaoMixesReset	5.6750 us/op	5.7800 us/op	0.98
mainnet_e81889 - altair processHistoricalRootsUpdate	903.00 ns/op	1.0370 us/op	0.87
mainnet_e81889 - altair processParticipationFlagUpdates	4.0050 us/op	1.8370 us/op	2.18
mainnet_e81889 - altair processSyncCommitteeUpdates	907.00 ns/op	908.00 ns/op	1.00
mainnet_e81889 - altair afterProcessEpoch	106.35 ms/op	82.428 ms/op	1.29
capella processEpoch - mainnet_e217614	1.8349 s/op	1.5414 s/op	1.19
mainnet_e217614 - capella beforeProcessEpoch	324.05 ms/op	340.40 ms/op	0.95
mainnet_e217614 - capella processJustificationAndFinalization	26.456 us/op	30.366 us/op	0.87
mainnet_e217614 - capella processInactivityUpdates	18.933 ms/op	19.972 ms/op	0.95
mainnet_e217614 - capella processRewardsAndPenalties	262.93 ms/op	329.14 ms/op	0.80
mainnet_e217614 - capella processRegistryUpdates	24.990 us/op	27.688 us/op	0.90
mainnet_e217614 - capella processSlashings	755.00 ns/op	1.9260 us/op	0.39
mainnet_e217614 - capella processEth1DataReset	589.00 ns/op	1.2240 us/op	0.48
mainnet_e217614 - capella processEffectiveBalanceUpdates	14.572 ms/op	24.687 ms/op	0.59
mainnet_e217614 - capella processSlashingsReset	4.4650 us/op	7.4090 us/op	0.60
mainnet_e217614 - capella processRandaoMixesReset	6.7230 us/op	10.387 us/op	0.65
mainnet_e217614 - capella processHistoricalRootsUpdate	771.00 ns/op	2.1490 us/op	0.36
mainnet_e217614 - capella processParticipationFlagUpdates	5.6390 us/op	5.8100 us/op	0.97
mainnet_e217614 - capella afterProcessEpoch	277.39 ms/op	335.36 ms/op	0.83
phase0 processEpoch - mainnet_e58758	417.49 ms/op	319.04 ms/op	1.31
mainnet_e58758 - phase0 beforeProcessEpoch	133.87 ms/op	123.74 ms/op	1.08
mainnet_e58758 - phase0 processJustificationAndFinalization	25.259 us/op	18.565 us/op	1.36
mainnet_e58758 - phase0 processRewardsAndPenalties	31.460 ms/op	27.952 ms/op	1.13
mainnet_e58758 - phase0 processRegistryUpdates	10.783 us/op	13.672 us/op	0.79
mainnet_e58758 - phase0 processSlashings	434.00 ns/op	977.00 ns/op	0.44
mainnet_e58758 - phase0 processEth1DataReset	494.00 ns/op	770.00 ns/op	0.64
mainnet_e58758 - phase0 processEffectiveBalanceUpdates	1.7502 ms/op	1.3942 ms/op	1.26
mainnet_e58758 - phase0 processSlashingsReset	4.6570 us/op	2.9480 us/op	1.58
mainnet_e58758 - phase0 processRandaoMixesReset	5.8580 us/op	6.5970 us/op	0.89
mainnet_e58758 - phase0 processHistoricalRootsUpdate	439.00 ns/op	1.2160 us/op	0.36
mainnet_e58758 - phase0 processParticipationRecordUpdates	4.2800 us/op	7.5580 us/op	0.57
mainnet_e58758 - phase0 afterProcessEpoch	84.968 ms/op	80.511 ms/op	1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase	1.1874 ms/op	1.0517 ms/op	1.13
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5	3.0919 ms/op	1.2232 ms/op	2.53
altair processInactivityUpdates - 250000 normalcase	19.279 ms/op	17.763 ms/op	1.09
altair processInactivityUpdates - 250000 worstcase	19.186 ms/op	18.884 ms/op	1.02
phase0 processRegistryUpdates - 250000 normalcase	9.7770 us/op	15.017 us/op	0.65
phase0 processRegistryUpdates - 250000 badcase_full_deposits	385.88 us/op	485.11 us/op	0.80
phase0 processRegistryUpdates - 250000 worstcase 0.5	149.59 ms/op	139.83 ms/op	1.07
altair processRewardsAndPenalties - 250000 normalcase	41.142 ms/op	48.610 ms/op	0.85
altair processRewardsAndPenalties - 250000 worstcase	43.792 ms/op	41.498 ms/op	1.06
phase0 getAttestationDeltas - 250000 normalcase	7.9300 ms/op	7.1989 ms/op	1.10
phase0 getAttestationDeltas - 250000 worstcase	9.5213 ms/op	8.3222 ms/op	1.14
phase0 processSlashings - 250000 worstcase	134.01 us/op	92.742 us/op	1.45
altair processSyncCommitteeUpdates - 250000	128.49 ms/op	207.59 ms/op	0.62
BeaconState.hashTreeRoot - No change	282.00 ns/op	1.1900 us/op	0.24
BeaconState.hashTreeRoot - 1 full validator	148.88 us/op	205.84 us/op	0.72
BeaconState.hashTreeRoot - 32 full validator	1.7441 ms/op	1.8437 ms/op	0.95
BeaconState.hashTreeRoot - 512 full validator	17.315 ms/op	19.385 ms/op	0.89
BeaconState.hashTreeRoot - 1 validator.effectiveBalance	194.86 us/op	223.97 us/op	0.87
BeaconState.hashTreeRoot - 32 validator.effectiveBalance	2.6636 ms/op	3.0530 ms/op	0.87
BeaconState.hashTreeRoot - 512 validator.effectiveBalance	23.765 ms/op	35.174 ms/op	0.68
BeaconState.hashTreeRoot - 1 balances	113.94 us/op	176.85 us/op	0.64
BeaconState.hashTreeRoot - 32 balances	969.82 us/op	1.6871 ms/op	0.57
BeaconState.hashTreeRoot - 512 balances	7.4982 ms/op	16.584 ms/op	0.45
BeaconState.hashTreeRoot - 250000 balances	178.70 ms/op	245.69 ms/op	0.73
aggregationBits - 2048 els - zipIndexesInBitList	25.734 us/op	26.326 us/op	0.98
byteArrayEquals 32	54.487 ns/op	66.412 ns/op	0.82
Buffer.compare 32	48.427 ns/op	38.889 ns/op	1.25
byteArrayEquals 1024	1.6132 us/op	1.7972 us/op	0.90
Buffer.compare 1024	59.082 ns/op	45.999 ns/op	1.28
byteArrayEquals 16384	25.761 us/op	28.774 us/op	0.90
Buffer.compare 16384	250.35 ns/op	241.84 ns/op	1.04
byteArrayEquals 123687377	193.66 ms/op	218.92 ms/op	0.88
Buffer.compare 123687377	7.3358 ms/op	9.5775 ms/op	0.77
byteArrayEquals 32 - diff last byte	53.421 ns/op	102.92 ns/op	0.52
Buffer.compare 32 - diff last byte	47.843 ns/op	41.088 ns/op	1.16
byteArrayEquals 1024 - diff last byte	1.6088 us/op	1.8049 us/op	0.89
Buffer.compare 1024 - diff last byte	61.729 ns/op	48.450 ns/op	1.27
byteArrayEquals 16384 - diff last byte	25.640 us/op	28.693 us/op	0.89
Buffer.compare 16384 - diff last byte	259.98 ns/op	225.63 ns/op	1.15
byteArrayEquals 123687377 - diff last byte	189.39 ms/op	223.61 ms/op	0.85
Buffer.compare 123687377 - diff last byte	7.5449 ms/op	5.4326 ms/op	1.39
byteArrayEquals 32 - random bytes	5.1610 ns/op	4.7380 ns/op	1.09
Buffer.compare 32 - random bytes	50.546 ns/op	40.184 ns/op	1.26
byteArrayEquals 1024 - random bytes	5.1760 ns/op	4.8860 ns/op	1.06
Buffer.compare 1024 - random bytes	50.432 ns/op	38.568 ns/op	1.31
byteArrayEquals 16384 - random bytes	5.1720 ns/op	4.9280 ns/op	1.05
Buffer.compare 16384 - random bytes	50.008 ns/op	34.560 ns/op	1.45
byteArrayEquals 123687377 - random bytes	6.5100 ns/op	9.0300 ns/op	0.72
Buffer.compare 123687377 - random bytes	53.090 ns/op	42.440 ns/op	1.25
regular array get 100000 times	32.903 us/op	42.154 us/op	0.78
wrappedArray get 100000 times	32.876 us/op	43.001 us/op	0.76
arrayWithProxy get 100000 times	12.878 ms/op	10.615 ms/op	1.21
ssz.Root.equals	46.621 ns/op	58.398 ns/op	0.80
byteArrayEquals	48.889 ns/op	57.553 ns/op	0.85
Buffer.compare	10.530 ns/op	10.628 ns/op	0.99
shuffle list - 16384 els	6.4146 ms/op	6.1113 ms/op	1.05
shuffle list - 250000 els	95.060 ms/op	87.229 ms/op	1.09
processSlot - 1 slots	12.537 us/op	20.928 us/op	0.60
processSlot - 32 slots	2.9015 ms/op	3.6195 ms/op	0.80
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei	38.963 ms/op	47.646 ms/op	0.82
getCommitteeAssignments - req 1 vs - 250000 vc	2.1556 ms/op	2.3810 ms/op	0.91
getCommitteeAssignments - req 100 vs - 250000 vc	4.2038 ms/op	3.5044 ms/op	1.20
getCommitteeAssignments - req 1000 vs - 250000 vc	4.4976 ms/op	3.8054 ms/op	1.18
findModifiedValidators - 10000 modified validators	289.38 ms/op	241.31 ms/op	1.20
findModifiedValidators - 1000 modified validators	196.37 ms/op	143.82 ms/op	1.37
findModifiedValidators - 100 modified validators	201.41 ms/op	149.33 ms/op	1.35
findModifiedValidators - 10 modified validators	206.76 ms/op	145.35 ms/op	1.42
findModifiedValidators - 1 modified validators	195.87 ms/op	165.31 ms/op	1.18
findModifiedValidators - no difference	216.95 ms/op	168.38 ms/op	1.29
compare ViewDUs	3.6565 s/op	3.2772 s/op	1.12
compare each validator Uint8Array	1.8291 s/op	1.6820 s/op	1.09
compare ViewDU to Uint8Array	1.4078 s/op	1.1080 s/op	1.27
migrate state 1000000 validators, 24 modified, 0 new	683.83 ms/op	607.18 ms/op	1.13
migrate state 1000000 validators, 1700 modified, 1000 new	1.0031 s/op	1.0088 s/op	0.99
migrate state 1000000 validators, 3400 modified, 2000 new	1.2683 s/op	1.3385 s/op	0.95
migrate state 1500000 validators, 24 modified, 0 new	639.90 ms/op	627.73 ms/op	1.02
migrate state 1500000 validators, 1700 modified, 1000 new	1.0049 s/op	926.79 ms/op	1.08
migrate state 1500000 validators, 3400 modified, 2000 new	1.2942 s/op	1.3565 s/op	0.95
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei	4.8100 ns/op	5.6100 ns/op	0.86
state getBlockRootAtSlot - 250000 vs - 7PWei	707.74 ns/op	734.05 ns/op	0.96
computeProposers - vc 250000	8.0686 ms/op	6.2852 ms/op	1.28
computeEpochShuffling - vc 250000	97.043 ms/op	86.054 ms/op	1.13
getNextSyncCommittee - vc 250000	137.27 ms/op	99.350 ms/op	1.38
computeSigningRoot for AttestationData	27.148 us/op	26.717 us/op	1.02
hash AttestationData serialized data then Buffer.toString(base64)	1.5953 us/op	1.2649 us/op	1.26
toHexString serialized data	967.16 ns/op	823.34 ns/op	1.17
Buffer.toString(base64)	191.78 ns/op	167.13 ns/op	1.15

by benchmarkbot/action

nazarhussain · 2024-05-07T08:25:41Z

Unstable with Node 20

Beta with Node 22

@wemeetagain I don't see any abnormality in the metrics for the node upgrade to 22. If you feel so, please update all required jobs for the PRs to Node 22.

wemeetagain · 2024-05-07T14:22:39Z

Can you look thru our docs, contribution docs, readmes, etc for references to node 20 (or even node 18)?

wemeetagain · 2024-05-07T15:11:58Z

standup discussion: we will wait on this until after interop. Continue collecting metrics until then

wemeetagain · 2024-05-23T13:57:46Z

Metrics look really good.

22 vs 20
block production

Only thing that looks worse in 22 is slightly higher RSS

codecov-commenter · 2024-05-23T19:51:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.21%. Comparing base (3c5bb15) to head (422713a).
Report is 8 commits behind head on unstable.

Additional details and impacted files

@@            Coverage Diff            @@
##           unstable    #6729   +/-   ##
=========================================
  Coverage     62.20%   62.21%           
=========================================
  Files           570      571    +1     
  Lines         59987    60017   +30     
  Branches       1977     1983    +6     
=========================================
+ Hits          37316    37337   +21     
- Misses        22628    22637    +9     
  Partials         43       43

wemeetagain · 2024-05-23T20:09:43Z

@nazarhussain can you look into failing tests?

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

This reverts commit deafa4f.

* chore: n-historical state - track state persist count per epoch (#6699) * feat: add lodestar binaries to release (#6666) * feat: added binaries creation support * feat: added sanity checks * chore: define reusable workflow * chore: fix sanity check,; disable arm64 * chore: added workflow_dispatch * fix: needs cleanup * chore: update old space size Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: address comments * chore: address comments * chore: fixed typo * chore: typo Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: address comments * chore: wording Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: use frozen lock file Co-authored-by: Nico Flaig <nflaig@protonmail.com> --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> * feat: switch bls to napi rebuild (#6616) * chore: update package.json deps and run yarn * feat: remove unused blst config from vitest.browser.*.config.ts * test: move G2@INF test to base blst repo. No longer exported. * fix: add Uint8Array.from for Buffer return value in unit test so type matches for toEqual * refactor: update imports of CoordType to use bls instead of blst * feat: add blsAddVerificationRandomness cli option * feat: add randomBytesNonZero to utils * feat: implement verification randomness for same message * feat: implement napi blst and switch to libuv worker pool * chore: lint * fix: update comments for availableParallelism * feat: set UV_THREADPOOL_SIZE for perf tests * feat: set UV_THREADPOOL_SIZE=$(nproc) in lodestar entrance script * feat: remove case for serialized PublicKey in deserializeSet * feat: add back workBusy count logic to canAcceptWork * feat: automatically set threadpool size in beaconHandler * refactor: rename flag to disableSameMessageVerificationRandomness * fix: remove UV_THREADPOOL_SIZE from ./lodestar * docs: add TODO about updating metrics * fix: make benchmark multi threading cross-compatible * chore: add bls@8.0.0 * feat: default to added randomness * feat: add warning for no same message randomness * fix: passing to updated bls functions * feat: add blst peerDep * fix: default to same message randomness * chore: update yarn.lock * chore: remove unused function to clear lint * feat: break out setThreadPoolSize * docs: update packages/cli/src/cmds/beacon/setThreadPoolSize.ts Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: update location for blst dep * chore: run lint again * fix: remove peerDep from light-client * test: fix browser based tests * fix: bad relative imports * docs: add note to readme about switchable bls * docs: typo * chore: lint readme * fix: light-client unit tests * fix: light-client e2e test * feat: remove disableSameMessageVerificationRandomness * refactor: remove unused type * docs: update wordlist * fix: e2e tests * Lint package.json * Revert "fix: e2e tests" This reverts commit f71acd7. * Revert "fix: light-client e2e test" This reverts commit 23c11f0. * Revert "fix: light-client unit tests" This reverts commit fa7893e. * Revert "test: fix browser based tests" This reverts commit 98d04ab. * docs: update readme to remove switchable bls argument * fix: replace optimizeDeps in vitest.browser.config * chore: updated to bls 8.1.0 * feat: move setting threadpool size and warnings to applyPreset.ts * fix: remove setThreadpoolSize from beacon handler * feat: move libuv size logging into handler to use logger * refactor: rename applyPreset to preInitialization * refactor: logging about pool size * Update packages/cli/src/options/globalOptions.ts Co-authored-by: Nico Flaig <nflaig@protonmail.com> * refactor: rename prover applyPreset * docs: change comment in cli/index * fix: update logging for * fix: throw error for invalid uvThreadpoolSize * Update packages/cli/src/preInitialization.ts Co-authored-by: Nico Flaig <nflaig@protonmail.com> * Fix lint issues * Remove unused import * refactor: move bls pool logging back to multithread.ts * fix: log of threadcount --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: update references to consensus spec to v1.4.0 (#6704) * chore: update references to consensus spec to v1.4.0 * Remove unintended formatting changes * chore: update consensus spec version in README (#6705) * docs: correct plausible url (#6709) fix: correct plausible url * docs: incorrect scripts location (#6710) fix: incorrect scripts location * docs: no more broken images (#6708) * fix: no more broken images * fix: incorrect paths * feat: check aggregationBits length of `SignedAggregateAndProof` in gossip validation (#6700) * Add unit test * Update packages/beacon-node/src/chain/validation/aggregateAndProof.ts Co-authored-by: Nico Flaig <nflaig@protonmail.com> --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> * feat: add and track blob source for metrics (#6628) * feat: add and track blob source for metrics * adding blobsSource for blobsPromise * address feedback * apply feedback * updates * only allow non blobspromise blocks to be imported * feat: add support for browser bundle for lightclient (#6673) * Reorganize the code so it is accessible from one package * Add support for browser build for lightclient * Update the build config * Improve the bls vite plugin * Restructure the vite and vitest scripts * Simplify vite config * Remove unused polyfill * Fix the doc lint error * Add support for bundle test * Update the package json files * Add dist build to default build task * Fix spelling in the docs * Fix the lint error * Fix type error * Disable eslint errors * Increase the timeout for bundle test * Fix eslint bundle * Fix lint warning * Remove the unused config * Add the default export to bundle * Enable compression on th build * Update packages/light-client/README.md Co-authored-by: Nico Flaig <nflaig@protonmail.com> * Increase timeout for one test * Optimize package build task * Update the readme --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> * docs: fix plausible domain (#6712) * ci: add paths-ignore to workflows (#6713) * chore: added paths-ignore * chore: address comments * feat: add arm64 binary support (#6707) * feat: add arm64 binary support * chore: workaround yarn * chore: add comment * chore: workaround runner limitations * ci: publish binaries for release candidates (#6714) * feat: add types support to esm bundle for lightclient (#6685) * Add vite dts plugin * Restructure types export * Update vite build config * Remove unused file * Update the build process * Fix doc formatting * Build the dist for type tests * chore: update vitest (#6718) Update vitest * chore: do not build all binaries atomically (#6719) * feat: update libp2p deps (#6711) * feat: update libp2p deps * chore: fix linter/type errors * chore(deps): bump ejs from 3.1.9 to 3.1.10 (#6721) Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: revert "ci: add paths-ignore to workflows (#6713)" (#6730) Revert "ci: add paths-ignore to workflows (#6713)" This reverts commit e460bb1. * docs: restore docs pages lost during docusaurus migration (#6725) * ci: fix incorrect build caching (#6731) fix: incorrect build caching * fix: build error log during esm bundle build (#6737) Fix build error * chore: update fastify to v4.27.0 (#6740) * deps: upgrade vitest minor version (#6745) Upgrade vitest * chore: warn when heap limit is too low (#6722) * chore: warn when heap limit is too low * chore: units Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: address comments * chore: added faq element * chore: address comments Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: address comments Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: address comments --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> * feat: disable flood publish (#6755) * feat: disable flood publish * feat: add network.disableFloodPublish cli flag * chore: address PR comments * test: allow compact diff for test failures (#6783) * Allow the compact diff for tests * Update the doc * Update docs/pages/contribution/testing/index.md Co-authored-by: Julien <jeluard@users.noreply.github.com> * Fix linting on docs * Fix linting --------- Co-authored-by: Julien <jeluard@users.noreply.github.com> * chore: upgrade classic-level (#6793) * chore: upgrade classic-level * chore: address comments * feat(prover): support non-mutated verification provider in prover (#6727) * Restructure the assertions * Add an inspector to run the logic to detect providers * Update web3 provdier logic to use inspetor * Fix the types for proxy * Make the default type for mutation * Rename elrpc to elrpcprovider * Apply suggestions from code review Co-authored-by: Julien <jeluard@users.noreply.github.com> * Fix build error * Update the readme doc * Apply suggestions from code review Co-authored-by: Julien <jeluard@users.noreply.github.com> * Fix the docs linting * Add missing words --------- Co-authored-by: Julien <jeluard@users.noreply.github.com> * docs: added debugging section (#6743) * docs: added debugging section * chore: spell checks * chore: added extra docs * chore: address comments * chore: added extra configuration * chore: updated docs * chore: added extra configuration * chore: fix lint * chore: fix typos * chore: .gitignore * chore: address comments * chore: address comments * chore: review debugging section PR (#6807) * chore: update the naming conventions used in sim tests (#6805) * Rename simulation test to crucible * Rename SimulationEnvironment to Simulation * Use consistent function names * Update readme * Rename interfaces for consistent pattern * Fix lint error * feat: recognize grandine from agentVersion (#6808) * Add grandine * add grandine to wordlist * chore: refactor event loop interactions (#6806) * chore: refactor sleep(0) usage * chore: refactor setTimeout * chore: address comments * chore: cleanup * Apply suggestions from code review --------- Co-authored-by: Cayman <caymannava@gmail.com> * chore: fix broken docker (#6813) * chore: log newPayload engine api (#6810) * chore: add `get_proposer_head` check in fork choice spec test (#6814) * Check get_proposer_head * Fix enum typo * lint * chore: consolidate classic-level usage (#6795) * chore: do not rely on leveldown * chore: replace level with classic-level * chore: added docker support for osx (#6696) * chore: added docker support for osx * chore: address comments * chore: address comments * Update docker-compose.yml Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: address comments --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> * chore: fix vitest performance with spec tests artifacts in place (#6817) Fix vitest performance with spec tests in place * chore: clean up yarn lockfile (#6816) * feat: disable flood publish by default (#6815) * feat: use @chainsafe/blst directly (#6706) * feat: use @chainsafe/blst directly * chore: update to blst@1.0.1 * refactor: remove randomBytesNonZero and user blst exported version * chore: update blst references * test: catch invalid deserialization in spec tests and return false * feat: create signatureFromBytes and signatureFromBytesNoCheck in utils package * feat: implement signatureFromBytes from utils package * feat: implement signatureFromBytes everywhere * fix: light-client empty module for blst --------- Co-authored-by: matthewkeil <me@matthewkeil.com> * fix: avoid Buffer.from copies (#6723) * fix: avoid Buffer.from copies * chore: simplify shuffling * fix: use subarray instead of slice in shuffling * chore: remove unnecessary devDependencies * chore: rely on fastify 4.x behavior * chore: avoid copy in verifyMerkleBranch * use toBase64 * relax assertions in shuffle function * Update packages/state-transition/src/util/shuffle.ts Co-authored-by: twoeths <tuyen@chainsafe.io> --------- Co-authored-by: twoeths <tuyen@chainsafe.io> * chore: update nodejs to latest 22 (#6729) * Upgrade node js version to 22 * Update node types * Revert action config * Add package from git hash * Fix the build error * Update the docs for node-22 * Update docker version for Nodejs to 22 * Update package.json * Update package.json Co-authored-by: Nico Flaig <nflaig@protonmail.com> * Update readme docs * Add word in dictionary * Add word in dictionary --------- Co-authored-by: Cayman <caymannava@gmail.com> Co-authored-by: Nico Flaig <nflaig@protonmail.com> * deps: update systeminformation to 5.22.9 (#6823) * chore: add distutils to build phase of Dockerfile (#6845) * test: increase timeout of keystore tests (#6846) * test: increase timeout of keystore cache tests * Increase hook timeout * Consistent number formatting * chore: only log warning if media type is not supported (415) (#6847) * fix: revert napi bls (#6853) * Revert "feat: use @chainsafe/blst directly (#6706)" This reverts commit 66fe753. * Revert "feat: switch bls to napi rebuild (#6616)" This reverts commit 97d9aa8. * chore: bump package versions to 1.19.0 * chore: bump @chainsafe/blst to v0.2.11 (#6856) * fix: arm64 binaries creation issue (#6858) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: tuyennhv <tuyen@chainsafe.io> Co-authored-by: Julien <jeluard@users.noreply.github.com> Co-authored-by: Nico Flaig <nflaig@protonmail.com> Co-authored-by: Matthew Keil <me@matthewkeil.com> Co-authored-by: NC <adrninistrator1@protonmail.com> Co-authored-by: g11tech <develop@g11tech.io> Co-authored-by: Nazar Hussain <nazarhussain@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

wemeetagain · 2024-06-07T11:57:17Z

🎉 This PR is included in v1.19.0 🎉

nazarhussain added 3 commits May 3, 2024 06:18

Upgrade node js version to 22

4ddaa6d

Update node types

5f8c97c

Revert action config

94f5991

Add package from git hash

f787ca4

nflaig reviewed May 3, 2024

View reviewed changes

Fix the build error

cc2d80e

nazarhussain marked this pull request as ready for review May 7, 2024 13:55

nazarhussain requested a review from a team as a code owner May 7, 2024 13:55

Update the docs for node-22

938fa89

wemeetagain previously approved these changes May 7, 2024

View reviewed changes

Update docker version for Nodejs to 22

90d1704

nazarhussain dismissed wemeetagain’s stale review via 90d1704 May 7, 2024 14:55

nazarhussain added status-blocked This is blocked by another issue that requires resolving first. status-do-not-merge Merging this issue will break the build. Do not merge! and removed status-blocked This is blocked by another issue that requires resolving first. labels May 7, 2024

philknows added this to the v1.19.0 milestone May 21, 2024

Merge branch 'unstable' into nh/node-22

6fc54a0

wemeetagain removed the status-do-not-merge Merging this issue will break the build. Do not merge! label May 23, 2024

nflaig reviewed May 23, 2024

View reviewed changes

Comment thread package.json

Comment thread package.json Outdated

wemeetagain reviewed May 23, 2024

View reviewed changes

Comment thread package.json Outdated

Update package.json

a813d48

nflaig reviewed May 23, 2024

View reviewed changes

Comment thread package.json Outdated

Update package.json

7df13a7

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

nazarhussain self-assigned this May 24, 2024

nazarhussain added 3 commits May 24, 2024 17:59

Update readme docs

fb1983f

Add word in dictionary

a1f5cf5

Add word in dictionary

422713a

wemeetagain approved these changes May 24, 2024

View reviewed changes

wemeetagain merged commit deafa4f into unstable May 24, 2024

wemeetagain deleted the nh/node-22 branch May 24, 2024 17:56

twoeths added a commit that referenced this pull request May 29, 2024

Revert "chore: update nodejs to latest 22 (#6729)"

8a03aef

This reverts commit deafa4f.

Uh oh!

Uh oh!

Conversation

nazarhussain commented May 3, 2024

Uh oh!

nazarhussain commented May 3, 2024

Uh oh!

codecov Bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nflaig May 3, 2024

Choose a reason for hiding this comment

Uh oh!

nazarhussain May 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Performance Alert ⚠️

Uh oh!

nazarhussain commented May 7, 2024

Unstable with Node 20

Beta with Node 22

Uh oh!

wemeetagain commented May 7, 2024

Uh oh!

wemeetagain commented May 7, 2024

Uh oh!

wemeetagain commented May 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 23, 2024 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wemeetagain commented May 23, 2024

Uh oh!

Uh oh!

wemeetagain commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented May 3, 2024 •

edited

Loading

github-actions Bot commented May 3, 2024 •

edited

Loading

codecov-commenter commented May 23, 2024 •

edited by codecov Bot

Loading