chore: revert "fix: update @libp2p/tcp (#6676)" - #6701
Merged
Conversation
This reverts commit f5148b2.
jeluard
reviewed
Apr 23, 2024
| @@ -1,4 +1,4 @@ | |||
| import {concat} from "uint8arrays/concat"; | |||
Contributor
There was a problem hiding this comment.
Is this change related to the version downgrade? As uint8arrays is listed as a devDependencies of light-client, I wouldn't expect a change here?
Member
Author
There was a problem hiding this comment.
I just reverted the commit
Member
Author
There was a problem hiding this comment.
apparently related to the deps update, see f3634b8
jeluard
self-requested a review
April 23, 2024 17:36
jeluard
approved these changes
Apr 23, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6701 +/- ##
=========================================
Coverage 61.87% 61.87%
=========================================
Files 557 557
Lines 59201 59201
Branches 1915 1915
=========================================
Hits 36628 36628
Misses 22530 22530
Partials 43 43 |
wemeetagain
approved these changes
Apr 23, 2024
Member
|
馃帀 This PR is included in v1.18.0 馃帀 |
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.