chore: track leaked connections in grafana - #6675
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6675 +/- ##
=========================================
Coverage 61.80% 61.80%
=========================================
Files 556 556
Lines 59073 59073
Branches 1898 1898
=========================================
Hits 36508 36508
Misses 22522 22522
Partials 43 43 |
Contributor
Performance Report鉁旓笍 no performance regression detected 馃殌馃殌 Significant benchmark improvement detected
Full benchmark results
|
wemeetagain
approved these changes
Apr 17, 2024
Member
|
馃帀 This PR is included in v1.18.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Track leaked connections to see if it's respective to heap memory in the network thread
Description
lodestar_peer_manager_leaked_connections_countintroduced in feat: track leaked libp2p connections聽#6656rate()there so that we can see if it happens and respective to heap memory on network threadrelated to #6595