chore: allow to serve docs from root folder - #6571
Merged
Merged
Conversation
jeluard
force-pushed
the
jeluard/docusaurus-add-root-scripts
branch
from
March 20, 2024 14:04
d8fda02 to
bdbf3f8
Compare
jeluard
force-pushed
the
jeluard/docusaurus-add-root-scripts
branch
from
March 20, 2024 14:04
bdbf3f8 to
5c5f5e6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6571 +/- ##
============================================
+ Coverage 61.46% 61.48% +0.02%
============================================
Files 556 556
Lines 58850 58891 +41
Branches 1850 1854 +4
============================================
+ Hits 36171 36212 +41
Misses 22638 22638
Partials 41 41 |
Contributor
Performance Report鉁旓笍 no performance regression detected 馃殌馃殌 Significant benchmark improvement detected
Full benchmark results
|
nflaig
previously approved these changes
Mar 20, 2024
| "check-types": "lerna run check-types", | ||
| "check-spelling": "pyspelling -c .pyspelling.yml -v", | ||
| "docs:build": "lerna run check-readme && lerna run docs:build && ./scripts/prepare-docs.sh", | ||
| "docs:serve": "yarn --cwd docs install && yarn --cwd docs start", |
Member
There was a problem hiding this comment.
yarn --cwd docs install will this part be a no-op if dependencies are already installed?
Contributor
Author
There was a problem hiding this comment.
Right, it will be almost instant and no-op (success Already up-to-date.). I used this approach to have a single command to serve the docs, even the first time.
nflaig
reviewed
Mar 20, 2024
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
ensi321
approved these changes
Mar 21, 2024
ensi321
left a comment
Member
There was a problem hiding this comment.
Looks good! Simple change that drastically improves dev experience
nflaig
approved these changes
Mar 21, 2024
Member
|
馃帀 This PR is included in v1.18.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allow to serve docs using
yarn docs:serve