Skip to content

chore: improve missing docker engine detection #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nazarhussain merged 2 commits into from
Feb 28, 2024
Merged

chore: improve missing docker engine detection #6495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3feee61
chore: detect when docker is not installed
jeluard Feb 28, 2024
6a9609d
chore: improve e2e tests requirement
jeluard Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ To run tests:
- :test_tube: Run `yarn check-types` to check TypeScript types.
- :test_tube: Run `yarn lint` to run the linter (ESLint).

Note that to run `test:e2e`, first ensure that the environment is correctly setup by running the `run_e2e_env.sh` script.
Note that to run `test:e2e`, first ensure that the environment is correctly setup by running the `run_e2e_env.sh` script. This script requires a running docker engine.

```sh
./scripts/run_e2e_env.sh start
Expand Down
6 changes: 5 additions & 1 deletion scripts/run_e2e_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ function stop_app() {
kill -s TERM $(cat test-logs/e2e-test-env/simulation.pid)
}


docker version > /dev/null 2>&1
if [ $? -ne 0 ]; then
echo "Docker is not running. Please start Docker and try again."
exit 1
fi

case "$1" in
start) start_app ;;
Expand Down