chore: cleanup older dependencies - #6482
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6482 +/- ##
=========================================
Coverage 61.72% 61.72%
=========================================
Files 555 555
Lines 58204 58204
Branches 1839 1839
=========================================
Hits 35925 35925
Misses 22240 22240
Partials 39 39 |
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
jeluard
marked this pull request as ready for review
February 26, 2024 17:08
nflaig
reviewed
Feb 26, 2024
| "devDependencies": { | ||
| "@lodestar/logger": "^1.16.0" | ||
| "@lodestar/logger": "^1.16.0", | ||
| "@types/levelup": "^4.3.3" |
Member
There was a problem hiding this comment.
Why do we need to keep @types/levelup? I don't see this being used
jeluard
force-pushed
the
jeluard/dependencies-cleanup
branch
2 times, most recently
from
February 26, 2024 20:30
f4c3f29 to
8f14fd8
Compare
jeluard
force-pushed
the
jeluard/dependencies-cleanup
branch
from
February 26, 2024 21:28
8f14fd8 to
7039c8c
Compare
wemeetagain
approved these changes
Feb 26, 2024
Member
|
馃帀 This PR is included in v1.17.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove unused dependencies and move
devdependencies to the proper section.Used depcheck to identify all relevant
dependencies/devDependencies. We might consider automating those checks down the line.