Skip to content

refactor: update retry function #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 7 commits into from
Feb 21, 2024
Merged

refactor: update retry function #6451

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d817c8
refactor: update retry function
FaybianB Feb 19, 2024
9ed842b
chore: subtract 1 from retry values
FaybianB Feb 20, 2024
1bc3da9
Keep same number of retries in download test
nflaig Feb 21, 2024
c5491cb
Update retry function
nflaig Feb 21, 2024
0dbfa66
Fix jsonRpcHttpClient tests
nflaig Feb 21, 2024
9bfd885
Merge branch 'unstable' into update-retry-function
nflaig Feb 21, 2024
ca7dfde
Restore comment
nflaig Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/spec-test-util/src/downloadTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export async function downloadGenericSpecTests<TestNames extends string>(
log(`Downloaded ${url}`);
},
{
retries: 2,
retries: 3,
Copy link
Member

@nflaig nflaig Feb 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used async-retry library, keeping retries as is, to not change previous behavior

onRetry: (e, attempt) => {
log(`Download attempt ${attempt} for ${url} failed: ${e.message}`);
},
Expand Down