chore: extend chiado config from gnosis config - #6329
Merged
Conversation
nflaig
commented
Jan 19, 2024
| CAPELLA_FORK_EPOCH: 648704, // 2023-08-01T11:34:20.000Z | ||
| // Deneb | ||
| DENEB_FORK_VERSION: b("0x04000064"), | ||
| DENEB_FORK_EPOCH: Infinity, |
Member
Author
There was a problem hiding this comment.
This change is to safe guard against previous issue
See fix for the issue
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6329 +/- ##
=========================================
Coverage 76.61% 76.61%
=========================================
Files 248 248
Lines 25898 25898
Branches 1448 1448
=========================================
Hits 19842 19842
Misses 6026 6026
Partials 30 30 |
Contributor
Performance Report鉁旓笍 no performance regression detected 馃殌馃殌 Significant benchmark improvement detected
Full benchmark results
|
wemeetagain
approved these changes
Jan 22, 2024
Member
|
馃帀 This PR is included in v1.15.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As noted in #6284 (comment) is might better to extend the chiado config from the gnosis config instead of mainnet.
Both networks override the same mainnet values, there are of course a few values (e.g.
DEPOSIT_CHAIN_ID) that chiado still needs to override but this reduces maintenance of network configs and makes overall config more robust / less error prone.Description
Extend chiado config from gnosis config
I verified that config of both networks did not change by comparing the results of
/eth/v1/config/spec. Also made sure we are still able to join the networks.Note: This PR does not yet schedule Deneb fork on chiado (#6284)