Skip to content

Use bls-keygen to generate random private keys #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wemeetagain merged 3 commits into from
Jan 17, 2020
Merged

Use bls-keygen to generate random private keys #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b505bf
Use bls-keygen to generate random private keys
aunyks Jan 15, 2020
cf0247a
Don't import new bls-keygen where not needed
aunyks Jan 16, 2020
db540a6
Merge branch 'master' into bls-keygen-private-keys
aunyks Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/bls/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"benchmark": "node -r ./.babel-register test/benchmarks"
},
"dependencies": {
"@chainsafe/bls-keygen": "^0.0.2",
"@chainsafe/eth2-bls-wasm": "^0.2.0",
"@chainsafe/eth2.0-types": "^0.2.0",
"assert": "^1.4.1",
Expand Down
7 changes: 3 additions & 4 deletions packages/bls/src/privateKey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {SECRET_KEY_LENGTH} from "./constants";
import assert from "assert";
import {BLSSecretKey, Domain, bytes32} from "@chainsafe/eth2.0-types";
import {SecretKeyType} from "@chainsafe/eth2-bls-wasm";
import {generateRandomSecretKey} from "@chainsafe/bls-keygen";
import {getContext} from "./context";
import {PublicKey} from "./publicKey";
import {Signature} from "./signature";
Expand Down Expand Up @@ -38,10 +39,8 @@ export class PrivateKey {
}

public static random(): PrivateKey {
const context = getContext();
const secretKey = new context.SecretKey();
secretKey.setByCSPRNG();
return new PrivateKey(secretKey);
const randomKey: Buffer = generateRandomSecretKey();
return this.fromBytes(randomKey);
}

public getValue(): SecretKeyType {
Expand Down
Loading