refactor: rename data gas to blob gas for relevant deneb fields#5816
Merged
refactor: rename data gas to blob gas for relevant deneb fields#5816
Conversation
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
previously approved these changes
Jul 28, 2023
matthewkeil
approved these changes
Aug 1, 2023
Member
matthewkeil
left a comment
matthewkeil
left a comment
There was a problem hiding this comment.
Changes lgtm 🚀
I noticed that we do not have a test for
tests/core/pyspec/eth2spec/test/helpers/sharding.py from the spec. Is that the only spec we still need to add to our suite?
Also the question about the magic string for specVersion. Not sure if those would ever want to be different or not.
|
|
||
| export const ethereumConsensusSpecsTests: DownloadTestsOptions = { | ||
| specVersion: "v1.4.0-beta.0", | ||
| specVersion: "v1.4.0-beta.1", |
Member
There was a problem hiding this comment.
Out of curiosity, why do we have this magic string in this file and in packages/params/test/e2e/ensure-config-is-synced.test.ts?
Contributor
Author
There was a problem hiding this comment.
this corresponds to protocol spec test releases (which go hand in hand with spec releases) : https://github.com/ethereum/consensus-spec-tests/releases
Member
|
🎉 This PR is included in v1.10.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pursuant to
renaming data gas fields => blob gas
TODO: