feat: extend attestation validity till end of next epoch - eip7045#5731
Merged
feat: extend attestation validity till end of next epoch - eip7045#5731
Conversation
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
matthewkeil
reviewed
Jul 9, 2023
Member
matthewkeil
left a comment
matthewkeil
left a comment
There was a problem hiding this comment.
A couple of questions do just double check the conditionals. Otherwise things look good!!
packages/state-transition/src/block/processAttestationsAltairPlus.ts
Outdated
Show resolved
Hide resolved
packages/state-transition/src/block/processAttestationPhase0.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
thanks for looking into this, target epoch validations check this and this implementation closely follow the specs (check spec PR) |
dapplion
reviewed
Jul 10, 2023
packages/state-transition/src/block/processAttestationsAltairPlus.ts
Outdated
Show resolved
Hide resolved
Contributor
|
@g11tech is p2p change supposed for this PR or another one? https://github.com/ethereum/consensus-specs/pull/3360/files#diff-21cd1dde2a4815e714ef42d0cefa1bbd2997a4358ecf6e9e51025332c1d642fdR196 |
Contributor
Author
was thinking of doing a followup to this PR |
Contributor
|
@g11tech pushed to the PR a quick review:
Can you please add the p2p changes in this PR too? I should not be that big |
Contributor
Author
sounds good 👍 |
Contributor
Author
|
for the p2p validations, should we just update to the new ones irrespective of the fork since new validations are more relaxed than the pre-deneb. Even if for pre-deneb if some attestations gets passed through, the actual process attestation will reject it pre-deneb.. wdyt @tuyennhv @dapplion UPDATE: as per discussion with @dapplion : "p2p validation must match the spec for all forks" |
upgrade spec version Review PR update p2p validations fix tests
wemeetagain
approved these changes
Jul 19, 2023
Member
|
🎉 This PR is included in v1.10.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref:
ethereum/consensus-specs#3360
- [ ] modify upgrade deneb state?no upgrade changes needed