Switch apache milagro with herumi/bls-wasm

[mpetrunic]

• api is still intact (thank you wrappers haha)
• there are some additional methods like (PrivateKey.from(int)) - should replace that custom pk generation
• still needs arguments checking and exception catching
• It should be possible to turn off order checking (big performance improvement) but I can't figure out how to call that wasm method)

resolves #566

[codecov]

Codecov Report

Merging #570 into master will decrease coverage by 1.28%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   64.83%   63.54%   -1.29%     
==========================================
  Files         199      196       -3     
  Lines        3609     3454     -155     
  Branches      329      318      -11     
==========================================
- Hits         2340     2195     -145     
+ Misses       1172     1165       -7     
+ Partials       97       94       -3

[ec2]

Other than the thing about versioning, lgtm

[wemeetagain]

Looks great! Much simpler.

Separate thought, if we simplify our code (eg: validator and keystore code), we probably won't even need to use the OO interface to bls, maybe just use a simple IKeypair interface :)

interface IKeypair {
  private: Buffer;
  public: Buffer;
}

and the functional interface exported here in this file

function getPublicKey(priv: Buffer): Buffer;
function sign(priv: Buffer, msg: Buffer, domain: Buffer): Buffer;
function aggregateSignatures(sigs: Buffer[]): Buffer;
function aggregatePublicKeys(pubs: Buffer[]): Buffer;
function verify(pub: Buffer, msg: Buffer, sig: Buffer, domain: Buffer): boolean;
function verifyMultiple(pubs: Buffer[], msgs: Buffer[], sig: Buffer, domain: Buffer): boolean;

[mpetrunic]

Looks great! Much simpler.

Separate thought, if we simplify our code (eg: validator and keystore code), we probably won't even need to use the OO interface to bls, maybe just use a simple IKeypair interface :)

interface IKeypair {
  private: Buffer;
  public: Buffer;
}

and the functional interface exported here in this file

function getPublicKey(priv: Buffer): Buffer;
function sign(priv: Buffer, msg: Buffer, domain: Buffer): Buffer;
function aggregateSignatures(sigs: Buffer[]): Buffer;
function aggregatePublicKeys(pubs: Buffer[]): Buffer;
function verify(pub: Buffer, msg: Buffer, sig: Buffer, domain: Buffer): boolean;
function verifyMultiple(pubs: Buffer[], msgs: Buffer[], sig: Buffer, domain: Buffer): boolean;

Actually, I was thinking of removing those functional interfaces as they are somewhat slower and much less optimized (you have to deserialize buffer and allocate new array to create internal wasm implementation format). Example, keeping PrivateKey instance and using sign method on that instance removes unnecessary deserialization and allocation.

We could see potential speed up if we convert, our validator registry public keys into PublicKey instances once and just use instances. It would shave ~20-30% time on every aggregation and verification

[wemeetagain]

I see, good point. Public keys would be a good thing to store with an "optimized beacon state", along with the committees and other things.
We definitely shouldn't remove the functional interface though, as its convenient in the naive case. Buffer in, buffer out.