fix(logger): increase max listeners of file transports to 20 - #5537
Merged
Conversation
nflaig
marked this pull request as draft
May 24, 2023 17:21
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
DailyRotateFile max listeners to 20
nflaig
force-pushed
the
nflaig/fix-DailyRotateFile-max-listeners
branch
from
May 29, 2023 14:53
f96c5a1 to
791f125
Compare
nflaig
marked this pull request as ready for review
May 29, 2023 15:06
nflaig
force-pushed
the
nflaig/fix-DailyRotateFile-max-listeners
branch
from
May 29, 2023 17:19
791f125 to
bd73f9a
Compare
wemeetagain
approved these changes
May 30, 2023
Member
|
馃帀 This PR is included in v1.9.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5529
Description
Increase max listeners of file transports to prevent
MaxListenersExceededWarningwarnings. Each child logger (logger.child) adds a new listener. Setting a reasonable limit to still detect potential memory leaks.This workaround is also suggested in winstonjs/winston#2247 (comment) and seems appropriate in our case as based on winstonjs/winston#1685 (comment) it does not look like this is an issue, it should ok to increase max listeners limit to suppress the warnings.