feat: enable deneb spec tests

packages/beacon-node/src/api/impl/beacon/blocks/index.ts

@@ -275,7 +275,7 @@ export function getBeaconBlockApi({
       }
 
       if (!blobSidecars) {
-        throw Error("Not found in db");
+        throw Error(`blobSidecars not found in db for slot=${block.message.slot} root=${toHexString(blockRoot)}`);
       }
       return {
         executionOptimistic,

packages/beacon-node/src/db/repositories/blobSidecars.ts

@@ -19,9 +19,9 @@ export const BLOB_SIDECARS_IN_WRAPPER_INDEX = 44;
 export const BLOBSIDECAR_FIXED_SIZE = 131256;
 
 /**
- * blobSidecarsWrapper by block root (= hash_tree_root(SignedBeaconBlockAndBlobsSidecar.beacon_block.message))
+ * blobSidecarsWrapper by block root (= hash_tree_root(SignedBeaconBlock.message))
  *
- * Used to store unfinalized BlobsSidecar
+ * Used to store unfinalized BlobSidecars
  */
 export class BlobSidecarsRepository extends Repository<Uint8Array, BlobSidecarsWrapper> {
   constructor(config: ChainForkConfig, db: Db) {

packages/beacon-node/src/db/repositories/blobSidecarsArchive.ts

@@ -8,7 +8,7 @@ import {blobSidecarsWrapperSsz, BlobSidecarsWrapper} from "./blobSidecars.js";
 /**
  * blobSidecarsWrapper by slot
  *
- * Used to store unfinalized BlobsSidecar
+ * Used to store finalized BlobSidecars
  */
 export class BlobSidecarsArchiveRepository extends Repository<Slot, BlobSidecarsWrapper> {
   constructor(config: ChainForkConfig, db: Db) {

packages/beacon-node/test/spec/presets/index.test.ts

@@ -30,8 +30,6 @@ import {transition} from "./transition.js";
 // ],
 // ```
 const skipOpts: SkipOpts = {
-  // To be enabled in decouple blobs PR: https://github.com/ChainSafe/lodestar/pull/5181
-  skippedForks: ["deneb"],
   // TODO: capella
   // BeaconBlockBody proof in lightclient is the new addition in v1.3.0-rc.2-hotfix
   // Skip them for now to enable subsequently

packages/types/src/deneb/sszTypes.ts

@@ -4,6 +4,7 @@ import {
   FIELD_ELEMENTS_PER_BLOB,
   MAX_BLOBS_PER_BLOCK,
   MAX_REQUEST_BLOCKS,
+  MAX_REQUEST_BLOB_SIDECARS,
   BYTES_PER_FIELD_ELEMENT,
   BLOCK_BODY_EXECUTION_PAYLOAD_DEPTH as EXECUTION_PAYLOAD_DEPTH,
   EPOCHS_PER_SYNC_COMMITTEE_PERIOD,
@@ -84,6 +85,26 @@ export const PolynomialAndCommitment = new ContainerType(
 // ReqResp types
 // =============
 
+export const BlobSidecarsByRangeRequest = new ContainerType(
+  {
+    startSlot: Slot,
+    count: UintNum64,
+  },
+  {typeName: "BlobSidecarsByRangeRequest", jsonCase: "eth2"}
+);
+
+export const BlobIdentifier = new ContainerType(
+  {
+    blockRoot: Root,
+    index: BlobIndex,
+  },
+  {typeName: "BlobIdentifier", jsonCase: "eth2"}
+);
+
+export const BlobSidecarsByRootRequest = new ListCompositeType(BlobIdentifier, MAX_REQUEST_BLOB_SIDECARS);
+
+// TODO DENEB: cleanup the following types once blob migration is complete
+
 export const BlobsSidecarsByRangeRequest = new ContainerType(
   {
     startSlot: Slot,

packages/types/src/deneb/types.ts

@@ -22,6 +22,10 @@ export type Polynomial = ValueOf<typeof ssz.Polynomial>;
 export type PolynomialAndCommitment = ValueOf<typeof ssz.PolynomialAndCommitment>;
 export type BLSFieldElement = ValueOf<typeof ssz.BLSFieldElement>;
 
+export type BlobIdentifier = ValueOf<typeof ssz.BlobIdentifier>;
+export type BlobSidecarsByRangeRequest = ValueOf<typeof ssz.BlobSidecarsByRangeRequest>;
+export type BlobSidecarsByRootRequest = ValueOf<typeof ssz.BlobSidecarsByRootRequest>;
+// TODO DENEB: cleanup the following old blobs types once the migration is complete
 export type BlobsSidecarsByRangeRequest = ValueOf<typeof ssz.BlobsSidecarsByRangeRequest>;
 export type BeaconBlockAndBlobsSidecarByRootRequest = ValueOf<typeof ssz.BeaconBlockAndBlobsSidecarByRootRequest>;