feat: batch io operations when verifying & importing block - #5473
Merged
Conversation
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
twoeths
marked this pull request as ready for review
May 9, 2023 08:12
dapplion
reviewed
May 14, 2023
dapplion
reviewed
May 14, 2023
dapplion
reviewed
May 14, 2023
dapplion
left a comment
dapplion
left a comment
Contributor
There was a problem hiding this comment.
Pushed some changes, see
lodestar/packages/beacon-node/src/chain/blocks/index.ts
Lines 145 to 159 in 4ce2967
@tuyennhv we have to be careful here since this may open up attacks. We are exposing DB growth to potentially untrusted data. Blocks from gossip have proposer sig validated but blocks from sync have no validation at all. We may want to disable this feature for sync and only do for payloads with some validation like gossip or unknown block sync
twoeths
force-pushed
the
tuyen/batch_io_operations
branch
from
May 15, 2023 03:07
4ce2967 to
71c1dbd
Compare
Member
Author
|
@dapplion I added |
Contributor
agreed, anyway eager saving on sync makes no effective impact because of checkpoint sync |
dapplion
approved these changes
May 18, 2023
dapplion
left a comment
dapplion
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Both gossip and unknown block root are safe for eagerPersistBlock. Can you open an issue to add a test that asserts that unknown block sync won't send to the chain blocks with invalid root?
Member
Author
Member
|
馃帀 This PR is included in v1.9.0 馃帀 |
ensi321
added a commit
that referenced
this pull request
Aug 4, 2026
Conflict resolutions: - specTestIterator: keep the heze on_payload_attestation_message skip alongside unstable's new gloas should_apply_proposer_boost skip - ensure-config-is-synced: this branch implements the EIP-7805 inclusion list params in ChainConfig, so they no longer need to be ignored - processExecutionPayloadBid: read parentSlot before overwriting the bid (#5473) while keeping the heze ExecutionPayloadBid type branch - .ethspecify.yml: heze configs are wired to sources on this branch, so drop them from the "not implemented" ignore list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Promise.all()inverifyBlock(), take that chance to persist blocks (and blobs) to dbCloses #5415