fix: Fix notifier bug that crept in #5297

[g11tech]

Fix a bug that crept in

• Add execution blockNumber to the notifier log #5297

while displaying how much head differs from slot

[github-actions]

Performance Report

✔️ no performance regression detected

Full benchmark results

Benchmark suite	Current: d3e3455	Previous: 9d8b831	Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc	856.30 us/op	781.28 us/op	1.10
getPubkeys - validatorsArr - req 1000 vs - 250000 vc	61.769 us/op	66.243 us/op	0.93
BLS verify - blst-native	1.4497 ms/op	1.3332 ms/op	1.09
BLS verifyMultipleSignatures 3 - blst-native	2.7958 ms/op	2.6835 ms/op	1.04
BLS verifyMultipleSignatures 8 - blst-native	6.2051 ms/op	5.8685 ms/op	1.06
BLS verifyMultipleSignatures 32 - blst-native	21.771 ms/op	20.823 ms/op	1.05
BLS aggregatePubkeys 32 - blst-native	30.625 us/op	28.212 us/op	1.09
BLS aggregatePubkeys 128 - blst-native	117.32 us/op	111.35 us/op	1.05
getAttestationsForBlock	65.881 ms/op	92.400 ms/op	0.71
isKnown best case - 1 super set check	296.00 ns/op	303.00 ns/op	0.98
isKnown normal case - 2 super set checks	292.00 ns/op	266.00 ns/op	1.10
isKnown worse case - 16 super set checks	274.00 ns/op	261.00 ns/op	1.05
CheckpointStateCache - add get delete	6.2060 us/op	6.5920 us/op	0.94
validate gossip signedAggregateAndProof - struct	3.3785 ms/op	2.8870 ms/op	1.17
validate gossip attestation - struct	1.6026 ms/op	1.5906 ms/op	1.01
pickEth1Vote - no votes	1.5615 ms/op	1.5643 ms/op	1.00
pickEth1Vote - max votes	14.279 ms/op	14.686 ms/op	0.97
pickEth1Vote - Eth1Data hashTreeRoot value x2048	11.851 ms/op	14.560 ms/op	0.81
pickEth1Vote - Eth1Data hashTreeRoot tree x2048	18.860 ms/op	21.744 ms/op	0.87
pickEth1Vote - Eth1Data fastSerialize value x2048	885.56 us/op	855.42 us/op	1.04
pickEth1Vote - Eth1Data fastSerialize tree x2048	8.2461 ms/op	10.294 ms/op	0.80
bytes32 toHexString	764.00 ns/op	854.00 ns/op	0.89
bytes32 Buffer.toString(hex)	478.00 ns/op	497.00 ns/op	0.96
bytes32 Buffer.toString(hex) from Uint8Array	711.00 ns/op	742.00 ns/op	0.96
bytes32 Buffer.toString(hex) + 0x	480.00 ns/op	465.00 ns/op	1.03
Object access 1 prop	0.23000 ns/op	0.22700 ns/op	1.01
Map access 1 prop	0.18100 ns/op	0.17800 ns/op	1.02
Object get x1000	8.3960 ns/op	8.1990 ns/op	1.02
Map get x1000	0.79700 ns/op	0.64300 ns/op	1.24
Object set x1000	82.876 ns/op	81.369 ns/op	1.02
Map set x1000	66.269 ns/op	59.718 ns/op	1.11
Return object 10000 times	0.28580 ns/op	0.28130 ns/op	1.02
Throw Error 10000 times	4.9724 us/op	4.4312 us/op	1.12
fastMsgIdFn sha256 / 200 bytes	4.2160 us/op	3.7620 us/op	1.12
fastMsgIdFn h32 xxhash / 200 bytes	366.00 ns/op	310.00 ns/op	1.18
fastMsgIdFn h64 xxhash / 200 bytes	562.00 ns/op	479.00 ns/op	1.17
fastMsgIdFn sha256 / 1000 bytes	13.824 us/op	12.122 us/op	1.14
fastMsgIdFn h32 xxhash / 1000 bytes	541.00 ns/op	453.00 ns/op	1.19
fastMsgIdFn h64 xxhash / 1000 bytes	661.00 ns/op	549.00 ns/op	1.20
fastMsgIdFn sha256 / 10000 bytes	127.73 us/op	106.25 us/op	1.20
fastMsgIdFn h32 xxhash / 10000 bytes	2.4350 us/op	1.9920 us/op	1.22
fastMsgIdFn h64 xxhash / 10000 bytes	1.7970 us/op	1.4330 us/op	1.25
enrSubnets - fastDeserialize 64 bits	2.2000 us/op	1.7160 us/op	1.28
enrSubnets - ssz BitVector 64 bits	778.00 ns/op	688.00 ns/op	1.13
enrSubnets - fastDeserialize 4 bits	238.00 ns/op	196.00 ns/op	1.21
enrSubnets - ssz BitVector 4 bits	730.00 ns/op	601.00 ns/op	1.21
prioritizePeers score -10:0 att 32-0.1 sync 2-0	146.82 us/op	114.20 us/op	1.29
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25	180.46 us/op	146.00 us/op	1.24
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5	235.72 us/op	173.39 us/op	1.36
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75	421.49 us/op	336.99 us/op	1.25
prioritizePeers score 0:0 att 64-1 sync 4-1	522.10 us/op	410.65 us/op	1.27
array of 16000 items push then shift	2.0659 us/op	1.6683 us/op	1.24
LinkedList of 16000 items push then shift	11.601 ns/op	9.0850 ns/op	1.28
array of 16000 items push then pop	142.11 ns/op	89.396 ns/op	1.59
LinkedList of 16000 items push then pop	11.151 ns/op	8.5390 ns/op	1.31
array of 24000 items push then shift	3.0061 us/op	2.4638 us/op	1.22
LinkedList of 24000 items push then shift	11.437 ns/op	8.8960 ns/op	1.29
array of 24000 items push then pop	110.07 ns/op	77.726 ns/op	1.42
LinkedList of 24000 items push then pop	10.312 ns/op	8.8640 ns/op	1.16
intersect bitArray bitLen 8	15.796 ns/op	13.778 ns/op	1.15
intersect array and set length 8	96.734 ns/op	77.062 ns/op	1.26
intersect bitArray bitLen 128	53.872 ns/op	44.656 ns/op	1.21
intersect array and set length 128	1.4680 us/op	1.0874 us/op	1.35
Buffer.concat 32 items	3.4240 us/op	2.6830 us/op	1.28
Uint8Array.set 32 items	2.6220 us/op	2.5080 us/op	1.05
pass gossip attestations to forkchoice per slot	3.3836 ms/op	3.8370 ms/op	0.88
computeDeltas	3.4558 ms/op	3.6377 ms/op	0.95
computeProposerBoostScoreFromBalances	1.9929 ms/op	1.9737 ms/op	1.01
altair processAttestation - 250000 vs - 7PWei normalcase	3.7841 ms/op	5.5813 ms/op	0.68
altair processAttestation - 250000 vs - 7PWei worstcase	4.5557 ms/op	8.1185 ms/op	0.56
altair processAttestation - setStatus - 1/6 committees join	152.39 us/op	220.70 us/op	0.69
altair processAttestation - setStatus - 1/3 committees join	328.64 us/op	451.88 us/op	0.73
altair processAttestation - setStatus - 1/2 committees join	430.36 us/op	419.93 us/op	1.02
altair processAttestation - setStatus - 2/3 committees join	508.39 us/op	525.42 us/op	0.97
altair processAttestation - setStatus - 4/5 committees join	777.75 us/op	683.88 us/op	1.14
altair processAttestation - setStatus - 100% committees join	821.91 us/op	791.55 us/op	1.04
altair processBlock - 250000 vs - 7PWei normalcase	19.158 ms/op	18.085 ms/op	1.06
altair processBlock - 250000 vs - 7PWei normalcase hashState	27.180 ms/op	24.375 ms/op	1.12
altair processBlock - 250000 vs - 7PWei worstcase	53.498 ms/op	52.248 ms/op	1.02
altair processBlock - 250000 vs - 7PWei worstcase hashState	74.554 ms/op	71.895 ms/op	1.04
phase0 processBlock - 250000 vs - 7PWei normalcase	2.0526 ms/op	2.0459 ms/op	1.00
phase0 processBlock - 250000 vs - 7PWei worstcase	31.063 ms/op	29.579 ms/op	1.05
altair processEth1Data - 250000 vs - 7PWei normalcase	509.54 us/op	663.36 us/op	0.77
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15	7.4060 us/op	9.6690 us/op	0.77
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219	19.798 us/op	43.906 us/op	0.45
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42	9.0400 us/op	15.578 us/op	0.58
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18	6.7240 us/op	8.8570 us/op	0.76
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020	79.797 us/op	109.69 us/op	0.73
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777	637.59 us/op	761.07 us/op	0.84
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384	913.54 us/op	1.2428 ms/op	0.74
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384	984.79 us/op	1.0190 ms/op	0.97
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384	2.6591 ms/op	3.1614 ms/op	0.84
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384	1.6854 ms/op	1.9076 ms/op	0.88
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384	3.9151 ms/op	4.8830 ms/op	0.80
Tree 40 250000 create	313.38 ms/op	362.20 ms/op	0.87
Tree 40 250000 get(125000)	202.91 ns/op	248.80 ns/op	0.82
Tree 40 250000 set(125000)	988.29 ns/op	2.6657 us/op	0.37
Tree 40 250000 toArray()	17.730 ms/op	35.020 ms/op	0.51
Tree 40 250000 iterate all - toArray() + loop	18.182 ms/op	40.615 ms/op	0.45
Tree 40 250000 iterate all - get(i)	69.280 ms/op	87.952 ms/op	0.79
MutableVector 250000 create	11.263 ms/op	16.633 ms/op	0.68
MutableVector 250000 get(125000)	6.6000 ns/op	11.935 ns/op	0.55
MutableVector 250000 set(125000)	274.90 ns/op	624.68 ns/op	0.44
MutableVector 250000 toArray()	3.3480 ms/op	5.3284 ms/op	0.63
MutableVector 250000 iterate all - toArray() + loop	3.2945 ms/op	6.1511 ms/op	0.54
MutableVector 250000 iterate all - get(i)	1.5644 ms/op	2.9633 ms/op	0.53
Array 250000 create	2.9205 ms/op	4.7649 ms/op	0.61
Array 250000 clone - spread	1.3111 ms/op	1.9092 ms/op	0.69
Array 250000 get(125000)	0.63900 ns/op	1.3360 ns/op	0.48
Array 250000 set(125000)	0.71000 ns/op	1.5460 ns/op	0.46
Array 250000 iterate all - loop	85.641 us/op	132.38 us/op	0.65
effectiveBalanceIncrements clone Uint8Array 300000	35.092 us/op	58.857 us/op	0.60
effectiveBalanceIncrements clone MutableVector 300000	424.00 ns/op	439.00 ns/op	0.97
effectiveBalanceIncrements rw all Uint8Array 300000	173.99 us/op	189.80 us/op	0.92
effectiveBalanceIncrements rw all MutableVector 300000	87.689 ms/op	98.766 ms/op	0.89
phase0 afterProcessEpoch - 250000 vs - 7PWei	122.73 ms/op	117.01 ms/op	1.05
phase0 beforeProcessEpoch - 250000 vs - 7PWei	40.192 ms/op	42.459 ms/op	0.95
altair processEpoch - mainnet_e81889	337.39 ms/op	343.00 ms/op	0.98
mainnet_e81889 - altair beforeProcessEpoch	67.218 ms/op	67.899 ms/op	0.99
mainnet_e81889 - altair processJustificationAndFinalization	16.486 us/op	28.015 us/op	0.59
mainnet_e81889 - altair processInactivityUpdates	5.3747 ms/op	6.9590 ms/op	0.77
mainnet_e81889 - altair processRewardsAndPenalties	63.708 ms/op	57.872 ms/op	1.10
mainnet_e81889 - altair processRegistryUpdates	2.7870 us/op	3.0660 us/op	0.91
mainnet_e81889 - altair processSlashings	405.00 ns/op	617.00 ns/op	0.66
mainnet_e81889 - altair processEth1DataReset	475.00 ns/op	622.00 ns/op	0.76
mainnet_e81889 - altair processEffectiveBalanceUpdates	1.2509 ms/op	1.2920 ms/op	0.97
mainnet_e81889 - altair processSlashingsReset	5.0440 us/op	6.3430 us/op	0.80
mainnet_e81889 - altair processRandaoMixesReset	4.5530 us/op	11.738 us/op	0.39
mainnet_e81889 - altair processHistoricalRootsUpdate	617.00 ns/op	2.4840 us/op	0.25
mainnet_e81889 - altair processParticipationFlagUpdates	2.3070 us/op	10.417 us/op	0.22
mainnet_e81889 - altair processSyncCommitteeUpdates	457.00 ns/op	3.2600 us/op	0.14
mainnet_e81889 - altair afterProcessEpoch	118.08 ms/op	186.55 ms/op	0.63
phase0 processEpoch - mainnet_e58758	315.85 ms/op	527.17 ms/op	0.60
mainnet_e58758 - phase0 beforeProcessEpoch	121.76 ms/op	200.12 ms/op	0.61
mainnet_e58758 - phase0 processJustificationAndFinalization	16.007 us/op	31.239 us/op	0.51
mainnet_e58758 - phase0 processRewardsAndPenalties	49.317 ms/op	86.215 ms/op	0.57
mainnet_e58758 - phase0 processRegistryUpdates	8.1210 us/op	16.506 us/op	0.49
mainnet_e58758 - phase0 processSlashings	457.00 ns/op	1.4890 us/op	0.31
mainnet_e58758 - phase0 processEth1DataReset	505.00 ns/op	1.4340 us/op	0.35
mainnet_e58758 - phase0 processEffectiveBalanceUpdates	1.0099 ms/op	2.1542 ms/op	0.47
mainnet_e58758 - phase0 processSlashingsReset	3.7880 us/op	11.098 us/op	0.34
mainnet_e58758 - phase0 processRandaoMixesReset	4.5310 us/op	13.861 us/op	0.33
mainnet_e58758 - phase0 processHistoricalRootsUpdate	917.00 ns/op	2.2070 us/op	0.42
mainnet_e58758 - phase0 processParticipationRecordUpdates	5.6280 us/op	12.214 us/op	0.46
mainnet_e58758 - phase0 afterProcessEpoch	100.98 ms/op	121.75 ms/op	0.83
phase0 processEffectiveBalanceUpdates - 250000 normalcase	1.2756 ms/op	2.4450 ms/op	0.52
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5	1.5672 ms/op	2.3571 ms/op	0.66
altair processInactivityUpdates - 250000 normalcase	22.775 ms/op	34.580 ms/op	0.66
altair processInactivityUpdates - 250000 worstcase	25.357 ms/op	34.666 ms/op	0.73
phase0 processRegistryUpdates - 250000 normalcase	9.2220 us/op	17.233 us/op	0.54
phase0 processRegistryUpdates - 250000 badcase_full_deposits	263.06 us/op	505.30 us/op	0.52
phase0 processRegistryUpdates - 250000 worstcase 0.5	109.31 ms/op	207.03 ms/op	0.53
altair processRewardsAndPenalties - 250000 normalcase	55.581 ms/op	96.391 ms/op	0.58
altair processRewardsAndPenalties - 250000 worstcase	53.451 ms/op	88.436 ms/op	0.60
phase0 getAttestationDeltas - 250000 normalcase	7.1143 ms/op	11.316 ms/op	0.63
phase0 getAttestationDeltas - 250000 worstcase	6.8737 ms/op	13.543 ms/op	0.51
phase0 processSlashings - 250000 worstcase	3.4522 ms/op	7.3050 ms/op	0.47
altair processSyncCommitteeUpdates - 250000	216.13 ms/op	250.37 ms/op	0.86
BeaconState.hashTreeRoot - No change	322.00 ns/op	398.00 ns/op	0.81
BeaconState.hashTreeRoot - 1 full validator	60.789 us/op	74.690 us/op	0.81
BeaconState.hashTreeRoot - 32 full validator	563.76 us/op	694.75 us/op	0.81
BeaconState.hashTreeRoot - 512 full validator	7.0128 ms/op	7.4179 ms/op	0.95
BeaconState.hashTreeRoot - 1 validator.effectiveBalance	72.441 us/op	71.693 us/op	1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance	1.0604 ms/op	1.0501 ms/op	1.01
BeaconState.hashTreeRoot - 512 validator.effectiveBalance	15.563 ms/op	17.312 ms/op	0.90
BeaconState.hashTreeRoot - 1 balances	60.936 us/op	60.699 us/op	1.00
BeaconState.hashTreeRoot - 32 balances	560.54 us/op	604.59 us/op	0.93
BeaconState.hashTreeRoot - 512 balances	6.2177 ms/op	5.4764 ms/op	1.14
BeaconState.hashTreeRoot - 250000 balances	91.640 ms/op	101.48 ms/op	0.90
aggregationBits - 2048 els - zipIndexesInBitList	36.508 us/op	29.951 us/op	1.22
regular array get 100000 times	50.821 us/op	48.778 us/op	1.04
wrappedArray get 100000 times	54.576 us/op	43.089 us/op	1.27
arrayWithProxy get 100000 times	18.934 ms/op	23.221 ms/op	0.82
ssz.Root.equals	694.00 ns/op	703.00 ns/op	0.99
byteArrayEquals	720.00 ns/op	730.00 ns/op	0.99
shuffle list - 16384 els	8.4121 ms/op	7.9405 ms/op	1.06
shuffle list - 250000 els	124.04 ms/op	131.29 ms/op	0.94
processSlot - 1 slots	11.032 us/op	12.383 us/op	0.89
processSlot - 32 slots	1.7240 ms/op	1.6036 ms/op	1.08
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei	37.584 ms/op	43.661 ms/op	0.86
getCommitteeAssignments - req 1 vs - 250000 vc	3.3249 ms/op	3.0026 ms/op	1.11
getCommitteeAssignments - req 100 vs - 250000 vc	4.7901 ms/op	4.2233 ms/op	1.13
getCommitteeAssignments - req 1000 vs - 250000 vc	5.4484 ms/op	4.5796 ms/op	1.19
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei	5.7700 ns/op	5.2400 ns/op	1.10
state getBlockRootAtSlot - 250000 vs - 7PWei	1.1513 us/op	669.68 ns/op	1.72
computeProposers - vc 250000	12.723 ms/op	11.621 ms/op	1.09
computeEpochShuffling - vc 250000	128.93 ms/op	110.76 ms/op	1.16
getNextSyncCommittee - vc 250000	221.67 ms/op	184.33 ms/op	1.20
computeSigningRoot for AttestationData	17.196 us/op	13.376 us/op	1.29
hash AttestationData serialized data then Buffer.toString(base64)	2.8708 us/op	2.5382 us/op	1.13
toHexString serialized data	1.6040 us/op	1.1151 us/op	1.44
Buffer.toString(base64)	440.12 ns/op	333.08 ns/op	1.32

by benchmarkbot/action

[wemeetagain]

🎉 This PR is included in v1.8.0 🎉