Add option to override preset with custom values from file - #5387
Merged
Conversation
Adds CLI flag `--presetFile` which invokes `setActivePreset` with custom values from file to override values of the active preset.
wemeetagain
reviewed
Apr 19, 2023
| }, | ||
|
|
||
| presetFile: { | ||
| hidden: true, |
wemeetagain
approved these changes
Apr 19, 2023
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
Member
|
馃帀 This PR is included in v1.8.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up to #4601 to expose
setActivePresetthrough the CLI and not just at the library level.Presets are more extensive than runtime configurations, and generally only applicable during compile-time. However, to support various private networks, simulation networks or CI/CD integration tests we require more flexibility.
The main motivation for this PR is to support running Lodestar VC in Obol Network CI/CD integration tests where they use a custom configuration that requires to override preset values such as
SLOTS_PER_EPOCHandEPOCHS_PER_SYNC_COMMITTEE_PERIOD.Description
Adds CLI flag
--presetFilewhich invokessetActivePresetwith custom values from file to override values of the active preset.Usage