Add eth_getCode support to prover - #5364
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (verifiedHandler !== undefined) { | ||
| logger.verbose("Verified request handler found", {method: payload.method}); | ||
| return verifiedHandler({payload, handler, proofProvider, logger}); | ||
| return verifiedHandler({payload, handler, proofProvider, logger, network}); |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
nazarhussain
force-pushed
the
nh/prover-get-code
branch
from
April 17, 2023 08:28
99a59df to
14df5f8
Compare
nazarhussain
commented
Apr 17, 2023
Comment on lines
+8
to
+10
| "noEmit": true, | ||
| // To be used in the test fixtures | ||
| "resolveJsonModule": true |
Contributor
Author
There was a problem hiding this comment.
This is required to change here, because yarn lint on the repo is run with the top level config file, not the package specific.
wemeetagain
reviewed
Apr 17, 2023
| import {validExecutionPayload} from "../../fixtures/cl_payload.js"; | ||
| import {UNVERIFIED_RESPONSE_CODE} from "../../../src/constants.js"; | ||
| import eth_getBalance_eoa from "../../fixtures/sepolia/eth_getBalance_eoa_proof.json" assert {type: "json"}; | ||
| import eth_getBalance_contract from "../../fixtures/sepolia/eth_getBalance_contract_proof.json" assert {type: "json"}; |
Member
There was a problem hiding this comment.
wemeetagain
reviewed
Apr 17, 2023
| import {writeFile, mkdir} from "node:fs/promises"; | ||
| import path from "node:path"; | ||
| import url from "node:url"; | ||
| // eslint-disable-next-line import/no-extraneous-dependencies |
Contributor
Author
There was a problem hiding this comment.
It requires to specify axios and few other packages as dependencies, while we just need it for development. So why had to disable this.
Member
|
馃帀 This PR is included in v1.8.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make the
@lodestar/provermore feature rich.Description
eth_getCode.Closes #4706
Steps to test or reproduce