Skip to content

Add note about setting default nodejs version when using nvm - #5348

Merged
wemeetagain merged 1 commit into
unstablefrom
nflaig/nvm-default-version
Apr 6, 2023
Merged

Add note about setting default nodejs version when using nvm#5348
wemeetagain merged 1 commit into
unstablefrom
nflaig/nvm-default-version

Conversation

@nflaig

@nflaig nflaig commented Apr 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

nvm sets the node version to default after reboot which might break Lodestar because modules are compiled on a different node version during yarn install, see discord.

Description

Add note to source installation page that a default version via nvm alias default <version> && nvm use default should bet set to ensure the node version does not change after reboot.

@nflaig
nflaig requested a review from a team as a code owner April 6, 2023 08:13
@nflaig
nflaig force-pushed the nflaig/nvm-default-version branch from 38902a4 to b42f1dd Compare April 6, 2023 08:16
@nflaig
nflaig force-pushed the nflaig/nvm-default-version branch from b42f1dd to b14b9e7 Compare April 6, 2023 08:17
@github-actions

github-actions Bot commented Apr 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance Report

鉁旓笍 no performance regression detected

Full benchmark results
Benchmark suite Current: 651838d Previous: ddc58ce Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 756.84 us/op 716.23 us/op 1.06
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 46.028 us/op 45.155 us/op 1.02
BLS verify - blst-native 1.2038 ms/op 1.1948 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 2.4671 ms/op 2.4293 ms/op 1.02
BLS verifyMultipleSignatures 8 - blst-native 5.3467 ms/op 5.1293 ms/op 1.04
BLS verifyMultipleSignatures 32 - blst-native 19.333 ms/op 18.513 ms/op 1.04
BLS aggregatePubkeys 32 - blst-native 25.894 us/op 24.752 us/op 1.05
BLS aggregatePubkeys 128 - blst-native 100.82 us/op 97.301 us/op 1.04
getAttestationsForBlock 64.623 ms/op 51.823 ms/op 1.25
isKnown best case - 1 super set check 251.00 ns/op 266.00 ns/op 0.94
isKnown normal case - 2 super set checks 268.00 ns/op 262.00 ns/op 1.02
isKnown worse case - 16 super set checks 271.00 ns/op 258.00 ns/op 1.05
CheckpointStateCache - add get delete 5.0390 us/op 4.8040 us/op 1.05
validate gossip signedAggregateAndProof - struct 2.7630 ms/op 2.6683 ms/op 1.04
validate gossip attestation - struct 1.3151 ms/op 1.3044 ms/op 1.01
pickEth1Vote - no votes 1.3126 ms/op 1.2527 ms/op 1.05
pickEth1Vote - max votes 9.5280 ms/op 10.793 ms/op 0.88
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.8292 ms/op 8.8673 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.169 ms/op 14.392 ms/op 0.98
pickEth1Vote - Eth1Data fastSerialize value x2048 712.87 us/op 664.17 us/op 1.07
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.2671 ms/op 7.1571 ms/op 1.29
bytes32 toHexString 633.00 ns/op 471.00 ns/op 1.34
bytes32 Buffer.toString(hex) 426.00 ns/op 339.00 ns/op 1.26
bytes32 Buffer.toString(hex) from Uint8Array 612.00 ns/op 546.00 ns/op 1.12
bytes32 Buffer.toString(hex) + 0x 393.00 ns/op 338.00 ns/op 1.16
Object access 1 prop 0.18800 ns/op 0.16200 ns/op 1.16
Map access 1 prop 0.16500 ns/op 0.15900 ns/op 1.04
Object get x1000 6.5840 ns/op 7.4250 ns/op 0.89
Map get x1000 0.66700 ns/op 0.60700 ns/op 1.10
Object set x1000 69.026 ns/op 50.576 ns/op 1.36
Map set x1000 53.505 ns/op 42.256 ns/op 1.27
Return object 10000 times 0.24450 ns/op 0.23200 ns/op 1.05
Throw Error 10000 times 4.2226 us/op 4.1579 us/op 1.02
fastMsgIdFn sha256 / 200 bytes 3.5530 us/op 3.4430 us/op 1.03
fastMsgIdFn h32 xxhash / 200 bytes 317.00 ns/op 280.00 ns/op 1.13
fastMsgIdFn h64 xxhash / 200 bytes 442.00 ns/op 416.00 ns/op 1.06
fastMsgIdFn sha256 / 1000 bytes 11.549 us/op 11.839 us/op 0.98
fastMsgIdFn h32 xxhash / 1000 bytes 440.00 ns/op 434.00 ns/op 1.01
fastMsgIdFn h64 xxhash / 1000 bytes 502.00 ns/op 478.00 ns/op 1.05
fastMsgIdFn sha256 / 10000 bytes 101.69 us/op 101.94 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9480 us/op 1.8990 us/op 1.03
fastMsgIdFn h64 xxhash / 10000 bytes 1.4010 us/op 1.2850 us/op 1.09
enrSubnets - fastDeserialize 64 bits 1.3780 us/op 1.2710 us/op 1.08
enrSubnets - ssz BitVector 64 bits 524.00 ns/op 477.00 ns/op 1.10
enrSubnets - fastDeserialize 4 bits 193.00 ns/op 169.00 ns/op 1.14
enrSubnets - ssz BitVector 4 bits 510.00 ns/op 494.00 ns/op 1.03
prioritizePeers score -10:0 att 32-0.1 sync 2-0 116.93 us/op 94.784 us/op 1.23
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 156.13 us/op 131.86 us/op 1.18
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 224.21 us/op 160.51 us/op 1.40
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 301.91 us/op 292.28 us/op 1.03
prioritizePeers score 0:0 att 64-1 sync 4-1 361.53 us/op 349.31 us/op 1.03
array of 16000 items push then shift 1.6430 us/op 1.5663 us/op 1.05
LinkedList of 16000 items push then shift 8.9460 ns/op 8.7740 ns/op 1.02
array of 16000 items push then pop 99.359 ns/op 87.635 ns/op 1.13
LinkedList of 16000 items push then pop 8.8800 ns/op 8.4900 ns/op 1.05
array of 24000 items push then shift 2.4151 us/op 2.4011 us/op 1.01
LinkedList of 24000 items push then shift 9.1690 ns/op 8.9690 ns/op 1.02
array of 24000 items push then pop 78.289 ns/op 75.959 ns/op 1.03
LinkedList of 24000 items push then pop 8.5140 ns/op 8.4340 ns/op 1.01
intersect bitArray bitLen 8 13.134 ns/op 13.139 ns/op 1.00
intersect array and set length 8 79.369 ns/op 77.648 ns/op 1.02
intersect bitArray bitLen 128 43.666 ns/op 43.439 ns/op 1.01
intersect array and set length 128 1.0831 us/op 1.0638 us/op 1.02
Buffer.concat 32 items 2.7280 us/op 2.8380 us/op 0.96
Uint8Array.set 32 items 2.2590 us/op 2.8010 us/op 0.81
pass gossip attestations to forkchoice per slot 2.7066 ms/op 3.0680 ms/op 0.88
computeDeltas 2.9190 ms/op 3.0120 ms/op 0.97
computeProposerBoostScoreFromBalances 1.7854 ms/op 1.7996 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei normalcase 2.6924 ms/op 2.6385 ms/op 1.02
altair processAttestation - 250000 vs - 7PWei worstcase 3.3660 ms/op 3.2345 ms/op 1.04
altair processAttestation - setStatus - 1/6 committees join 144.36 us/op 149.67 us/op 0.96
altair processAttestation - setStatus - 1/3 committees join 280.39 us/op 276.77 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 370.65 us/op 366.00 us/op 1.01
altair processAttestation - setStatus - 2/3 committees join 484.69 us/op 473.21 us/op 1.02
altair processAttestation - setStatus - 4/5 committees join 670.63 us/op 674.55 us/op 0.99
altair processAttestation - setStatus - 100% committees join 780.30 us/op 758.90 us/op 1.03
altair processBlock - 250000 vs - 7PWei normalcase 16.450 ms/op 18.002 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 25.875 ms/op 26.657 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase 47.867 ms/op 54.820 ms/op 0.87
altair processBlock - 250000 vs - 7PWei worstcase hashState 66.201 ms/op 67.381 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9208 ms/op 2.1229 ms/op 0.90
phase0 processBlock - 250000 vs - 7PWei worstcase 28.111 ms/op 27.880 ms/op 1.01
altair processEth1Data - 250000 vs - 7PWei normalcase 469.21 us/op 475.21 us/op 0.99
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 8.8040 us/op 7.0450 us/op 1.25
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 29.534 us/op 20.352 us/op 1.45
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 11.304 us/op 11.582 us/op 0.98
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 8.1740 us/op 8.4500 us/op 0.97
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 107.55 us/op 87.363 us/op 1.23
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 658.66 us/op 618.60 us/op 1.06
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 888.24 us/op 925.32 us/op 0.96
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 866.22 us/op 912.78 us/op 0.95
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.3199 ms/op 2.3579 ms/op 0.98
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.6098 ms/op 1.4748 ms/op 1.09
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 4.7868 ms/op 4.3713 ms/op 1.10
Tree 40 250000 create 388.87 ms/op 335.39 ms/op 1.16
Tree 40 250000 get(125000) 195.18 ns/op 194.79 ns/op 1.00
Tree 40 250000 set(125000) 1.0638 us/op 985.09 ns/op 1.08
Tree 40 250000 toArray() 23.363 ms/op 22.492 ms/op 1.04
Tree 40 250000 iterate all - toArray() + loop 24.596 ms/op 18.384 ms/op 1.34
Tree 40 250000 iterate all - get(i) 79.059 ms/op 74.365 ms/op 1.06
MutableVector 250000 create 12.052 ms/op 10.672 ms/op 1.13
MutableVector 250000 get(125000) 6.3950 ns/op 6.3880 ns/op 1.00
MutableVector 250000 set(125000) 307.88 ns/op 316.14 ns/op 0.97
MutableVector 250000 toArray() 3.8287 ms/op 3.3486 ms/op 1.14
MutableVector 250000 iterate all - toArray() + loop 3.3924 ms/op 2.8725 ms/op 1.18
MutableVector 250000 iterate all - get(i) 1.5195 ms/op 1.5285 ms/op 0.99
Array 250000 create 3.7108 ms/op 2.6130 ms/op 1.42
Array 250000 clone - spread 1.2908 ms/op 1.1156 ms/op 1.16
Array 250000 get(125000) 0.67500 ns/op 0.56900 ns/op 1.19
Array 250000 set(125000) 0.66800 ns/op 0.64000 ns/op 1.04
Array 250000 iterate all - loop 84.192 us/op 85.079 us/op 0.99
effectiveBalanceIncrements clone Uint8Array 300000 36.411 us/op 33.117 us/op 1.10
effectiveBalanceIncrements clone MutableVector 300000 373.00 ns/op 345.00 ns/op 1.08
effectiveBalanceIncrements rw all Uint8Array 300000 168.11 us/op 170.61 us/op 0.99
effectiveBalanceIncrements rw all MutableVector 300000 87.051 ms/op 81.912 ms/op 1.06
phase0 afterProcessEpoch - 250000 vs - 7PWei 114.58 ms/op 115.41 ms/op 0.99
phase0 beforeProcessEpoch - 250000 vs - 7PWei 43.680 ms/op 40.301 ms/op 1.08
altair processEpoch - mainnet_e81889 337.55 ms/op 332.43 ms/op 1.02
mainnet_e81889 - altair beforeProcessEpoch 75.284 ms/op 51.703 ms/op 1.46
mainnet_e81889 - altair processJustificationAndFinalization 19.395 us/op 17.054 us/op 1.14
mainnet_e81889 - altair processInactivityUpdates 5.8371 ms/op 6.2430 ms/op 0.93
mainnet_e81889 - altair processRewardsAndPenalties 66.875 ms/op 63.451 ms/op 1.05
mainnet_e81889 - altair processRegistryUpdates 2.8480 us/op 3.7400 us/op 0.76
mainnet_e81889 - altair processSlashings 522.00 ns/op 527.00 ns/op 0.99
mainnet_e81889 - altair processEth1DataReset 503.00 ns/op 628.00 ns/op 0.80
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2534 ms/op 1.2844 ms/op 0.98
mainnet_e81889 - altair processSlashingsReset 8.4170 us/op 5.5010 us/op 1.53
mainnet_e81889 - altair processRandaoMixesReset 4.6600 us/op 5.2950 us/op 0.88
mainnet_e81889 - altair processHistoricalRootsUpdate 1.3930 us/op 1.0290 us/op 1.35
mainnet_e81889 - altair processParticipationFlagUpdates 2.1220 us/op 2.8340 us/op 0.75
mainnet_e81889 - altair processSyncCommitteeUpdates 681.00 ns/op 490.00 ns/op 1.39
mainnet_e81889 - altair afterProcessEpoch 127.46 ms/op 127.19 ms/op 1.00
phase0 processEpoch - mainnet_e58758 372.95 ms/op 368.16 ms/op 1.01
mainnet_e58758 - phase0 beforeProcessEpoch 152.22 ms/op 142.16 ms/op 1.07
mainnet_e58758 - phase0 processJustificationAndFinalization 20.597 us/op 17.900 us/op 1.15
mainnet_e58758 - phase0 processRewardsAndPenalties 68.687 ms/op 69.891 ms/op 0.98
mainnet_e58758 - phase0 processRegistryUpdates 13.952 us/op 9.5600 us/op 1.46
mainnet_e58758 - phase0 processSlashings 850.00 ns/op 686.00 ns/op 1.24
mainnet_e58758 - phase0 processEth1DataReset 782.00 ns/op 1.2470 us/op 0.63
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0887 ms/op 1.8410 ms/op 0.59
mainnet_e58758 - phase0 processSlashingsReset 6.3530 us/op 3.7290 us/op 1.70
mainnet_e58758 - phase0 processRandaoMixesReset 7.4790 us/op 10.732 us/op 0.70
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0300 us/op 827.00 ns/op 1.25
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.6410 us/op 4.5770 us/op 1.67
mainnet_e58758 - phase0 afterProcessEpoch 100.34 ms/op 98.725 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2505 ms/op 1.2196 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.0692 ms/op 1.5163 ms/op 1.36
altair processInactivityUpdates - 250000 normalcase 29.966 ms/op 25.982 ms/op 1.15
altair processInactivityUpdates - 250000 worstcase 29.097 ms/op 26.778 ms/op 1.09
phase0 processRegistryUpdates - 250000 normalcase 11.138 us/op 6.9640 us/op 1.60
phase0 processRegistryUpdates - 250000 badcase_full_deposits 273.02 us/op 269.12 us/op 1.01
phase0 processRegistryUpdates - 250000 worstcase 0.5 138.56 ms/op 127.12 ms/op 1.09
altair processRewardsAndPenalties - 250000 normalcase 63.844 ms/op 66.175 ms/op 0.96
altair processRewardsAndPenalties - 250000 worstcase 65.004 ms/op 73.291 ms/op 0.89
phase0 getAttestationDeltas - 250000 normalcase 7.2039 ms/op 6.7085 ms/op 1.07
phase0 getAttestationDeltas - 250000 worstcase 6.9216 ms/op 6.6873 ms/op 1.04
phase0 processSlashings - 250000 worstcase 3.6898 ms/op 3.6456 ms/op 1.01
altair processSyncCommitteeUpdates - 250000 181.72 ms/op 193.36 ms/op 0.94
BeaconState.hashTreeRoot - No change 279.00 ns/op 278.00 ns/op 1.00
BeaconState.hashTreeRoot - 1 full validator 54.226 us/op 53.164 us/op 1.02
BeaconState.hashTreeRoot - 32 full validator 511.37 us/op 555.16 us/op 0.92
BeaconState.hashTreeRoot - 512 full validator 5.1125 ms/op 5.3322 ms/op 0.96
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 64.476 us/op 69.851 us/op 0.92
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 906.37 us/op 1.0240 ms/op 0.89
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.996 ms/op 15.274 ms/op 0.79
BeaconState.hashTreeRoot - 1 balances 51.148 us/op 58.784 us/op 0.87
BeaconState.hashTreeRoot - 32 balances 468.04 us/op 484.88 us/op 0.97
BeaconState.hashTreeRoot - 512 balances 4.6168 ms/op 5.2844 ms/op 0.87
BeaconState.hashTreeRoot - 250000 balances 74.322 ms/op 87.179 ms/op 0.85
aggregationBits - 2048 els - zipIndexesInBitList 18.412 us/op 26.229 us/op 0.70
regular array get 100000 times 35.500 us/op 36.031 us/op 0.99
wrappedArray get 100000 times 33.178 us/op 36.455 us/op 0.91
arrayWithProxy get 100000 times 17.023 ms/op 18.911 ms/op 0.90
ssz.Root.equals 563.00 ns/op 637.00 ns/op 0.88
byteArrayEquals 563.00 ns/op 594.00 ns/op 0.95
shuffle list - 16384 els 7.0512 ms/op 7.2320 ms/op 0.97
shuffle list - 250000 els 101.92 ms/op 107.37 ms/op 0.95
processSlot - 1 slots 8.8620 us/op 10.486 us/op 0.85
processSlot - 32 slots 1.3932 ms/op 1.7897 ms/op 0.78
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 36.823 ms/op 38.380 ms/op 0.96
getCommitteeAssignments - req 1 vs - 250000 vc 3.0107 ms/op 3.1858 ms/op 0.95
getCommitteeAssignments - req 100 vs - 250000 vc 4.2495 ms/op 4.4284 ms/op 0.96
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5913 ms/op 4.7572 ms/op 0.97
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6800 ns/op 5.4200 ns/op 0.86
state getBlockRootAtSlot - 250000 vs - 7PWei 578.18 ns/op 1.1827 us/op 0.49
computeProposers - vc 250000 10.969 ms/op 11.897 ms/op 0.92
computeEpochShuffling - vc 250000 103.83 ms/op 107.09 ms/op 0.97
getNextSyncCommittee - vc 250000 179.96 ms/op 194.89 ms/op 0.92

by benchmarkbot/action

@wemeetagain
wemeetagain merged commit 7979491 into unstable Apr 6, 2023
@wemeetagain
wemeetagain deleted the nflaig/nvm-default-version branch April 6, 2023 16:20
@wemeetagain

wemeetagain commented May 4, 2023

Copy link
Copy Markdown
Member

馃帀 This PR is included in v1.8.0 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nflaig @wemeetagain