Add support for eth_getTransactionCount to prover - #5338
Merged
Conversation
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (verifiedHandler !== undefined) { | ||
| logger.verbose("Verified request handler found", {method: payload.method}); | ||
| return verifiedHandler({payload, handler, proofProvider, logger}); |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call
twoeths
reviewed
Apr 5, 2023
| import {generateRPCResponseForPayload, generateUnverifiedResponseForPayload} from "../utils/json_rpc.js"; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| export const eth_getTransactionCount: ELVerifiedRequestHandler< |
Member
There was a problem hiding this comment.
@nazarhussain since it shares most of the steps from ethGetBalance, can we refactor to use a common method? could be in a separate PR
Contributor
Author
There was a problem hiding this comment.
Sure will refactor in upcoming PRs.
twoeths
approved these changes
Apr 5, 2023
Member
|
馃帀 This PR is included in v1.8.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for web3 method
eth_getTransactionCountDescription
Add support for web3 method
eth_getTransactionCountPartially: #4706
Steps to test or reproduce
Run all tests.