Handle unknown block root attestations - #5327
Merged
twoeths merged 10 commits intoApr 7, 2023
Merged
Conversation
twoeths
changed the title
twoeths
force-pushed
the
tuyen/unknown_block_root_attestations
branch
from
April 4, 2023 07:27
fe12837 to
afec1c3
Compare
Member
Author
|
Some metrics captured
==> it'll be improved if we trigger block search once we receive an unknown block root attestation, that's to be done in a separate work once we merge |
twoeths
marked this pull request as ready for review
April 4, 2023 14:35
dapplion
reviewed
Apr 5, 2023
dapplion
reviewed
Apr 5, 2023
dapplion
reviewed
Apr 5, 2023
dapplion
reviewed
Apr 5, 2023
dapplion
reviewed
Apr 6, 2023
dapplion
reviewed
Apr 6, 2023
twoeths
added a commit
that referenced
this pull request
Apr 7, 2023
* Add sszBytes utils * Unknown Block Root queues * Use Uint8Array.subarray() * Merge tuyen/new_gossip_queues * Avoid forEach pattern * Process unknown attestations: yield to event loop * Fix metrics * Name variable and function as *attDataBase64 everywhere * Handle invalid serialized data * Check ssz data length of gossip messages
wemeetagain
pushed a commit
that referenced
this pull request
Apr 7, 2023
* Add sszBytes utils * Unknown Block Root queues * Use Uint8Array.subarray() * Merge tuyen/new_gossip_queues * Avoid forEach pattern * Process unknown attestations: yield to event loop * Fix metrics * Name variable and function as *attDataBase64 everywhere * Handle invalid serialized data * Check ssz data length of gossip messages
Member
|
馃帀 This PR is included in v1.8.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now if a gossip attestation is validated and has unknown block root, it'll be reprocessed once the block comes. This has some drawback:
Description