Handle gossip messages asynchronously - #5316
Merged
twoeths merged 2 commits intoMar 31, 2023
Merged
Conversation
twoeths
marked this pull request as ready for review
March 29, 2023 03:53
wemeetagain
approved these changes
Mar 30, 2023
dapplion
approved these changes
Mar 31, 2023
twoeths
added a commit
that referenced
this pull request
Apr 7, 2023
* Handle gossip messages async * Add comments
wemeetagain
pushed a commit
that referenced
this pull request
Apr 7, 2023
* Handle gossip messages async * Add comments
Member
|
馃帀 This PR is included in v1.8.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
vc, more time to callnotifyNewPayloadengine apionGossipsubMessagesynchronouslyreportMessageValidationResultsynchronouslyRPCcontains thousands of gossip messagesstable/unstable) when we push gossip messages toJobItemQueuewe always usesetTimeout()which helps avoid the I/O lag issue, we also yield to the macro queue every 50ms thereDescription
setTimeoutto break our gossip handler to multiple event loops which helps the I/O lag issue (which make it equivalent to the current behavior ofstablebranch)part of #5247