Skip to content

Release v1.4.2 - #5105

Merged
wemeetagain merged 3 commits into
stablefrom
rc/v1.4.2
Feb 7, 2023
Merged

Release v1.4.2#5105
wemeetagain merged 3 commits into
stablefrom
rc/v1.4.2

Conversation

@wemeetagain

@wemeetagain wemeetagain commented Feb 6, 2023

Copy link
Copy Markdown
Member

wemeetagain and others added 3 commits February 6, 2023 03:41
@wemeetagain
v1.4.2
3c8aa8a
@g11tech @wemeetagain
Fix the args order in evaluating isBetterUpdate for new partial update (
781fe3d 
#5090)
@twoeths @wemeetagain
Fix PeerScore.update() function (#5094)
68c82ba 
* Fix PeerScore.update() function

* Introduce negativeGossipScoreIgnoreThreshold

* Track peer scores by client

* Reset gossip score by client
@wemeetagain
wemeetagain requested a review from a team as a code owner February 6, 2023 08:46
@github-actions

github-actions Bot commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

Performance Report

鉁旓笍 no performance regression detected

Full benchmark results
Benchmark suite Current: 36d1dd2 Previous: - Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.3011 ms/op
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 74.331 us/op
BLS verify - blst-native 2.0395 ms/op
BLS verifyMultipleSignatures 3 - blst-native 4.2696 ms/op
BLS verifyMultipleSignatures 8 - blst-native 9.1504 ms/op
BLS verifyMultipleSignatures 32 - blst-native 33.582 ms/op
BLS aggregatePubkeys 32 - blst-native 44.183 us/op
BLS aggregatePubkeys 128 - blst-native 168.58 us/op
getAttestationsForBlock 97.363 ms/op
isKnown best case - 1 super set check 462.00 ns/op
isKnown normal case - 2 super set checks 453.00 ns/op
isKnown worse case - 16 super set checks 463.00 ns/op
CheckpointStateCache - add get delete 9.2140 us/op
validate gossip signedAggregateAndProof - struct 4.8756 ms/op
validate gossip attestation - struct 2.3635 ms/op
pickEth1Vote - no votes 2.5021 ms/op
pickEth1Vote - max votes 18.312 ms/op
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.469 ms/op
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.097 ms/op
pickEth1Vote - Eth1Data fastSerialize value x2048 1.4682 ms/op
pickEth1Vote - Eth1Data fastSerialize tree x2048 10.629 ms/op
bytes32 toHexString 1.1530 us/op
bytes32 Buffer.toString(hex) 653.00 ns/op
bytes32 Buffer.toString(hex) from Uint8Array 1.0500 us/op
bytes32 Buffer.toString(hex) + 0x 655.00 ns/op
Object access 1 prop 0.30300 ns/op
Map access 1 prop 0.29100 ns/op
Object get x1000 18.640 ns/op
Map get x1000 1.1180 ns/op
Object set x1000 117.58 ns/op
Map set x1000 74.403 ns/op
Return object 10000 times 0.40800 ns/op
Throw Error 10000 times 7.8599 us/op
fastMsgIdFn sha256 / 200 bytes 4.7850 us/op
fastMsgIdFn h32 xxhash / 200 bytes 515.00 ns/op
fastMsgIdFn h64 xxhash / 200 bytes 694.00 ns/op
fastMsgIdFn sha256 / 1000 bytes 15.183 us/op
fastMsgIdFn h32 xxhash / 1000 bytes 657.00 ns/op
fastMsgIdFn h64 xxhash / 1000 bytes 773.00 ns/op
fastMsgIdFn sha256 / 10000 bytes 133.69 us/op
fastMsgIdFn h32 xxhash / 10000 bytes 2.6700 us/op
fastMsgIdFn h64 xxhash / 10000 bytes 1.8650 us/op
enrSubnets - fastDeserialize 64 bits 2.6640 us/op
enrSubnets - ssz BitVector 64 bits 932.00 ns/op
enrSubnets - fastDeserialize 4 bits 315.00 ns/op
enrSubnets - ssz BitVector 4 bits 945.00 ns/op
prioritizePeers score -10:0 att 32-0.1 sync 2-0 198.25 us/op
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 235.29 us/op
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 348.44 us/op
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 587.69 us/op
prioritizePeers score 0:0 att 64-1 sync 4-1 661.76 us/op
array of 16000 items push then shift 2.9177 us/op
LinkedList of 16000 items push then shift 19.470 ns/op
array of 16000 items push then pop 251.64 ns/op
LinkedList of 16000 items push then pop 18.617 ns/op
array of 24000 items push then shift 4.4589 us/op
LinkedList of 24000 items push then shift 21.278 ns/op
array of 24000 items push then pop 217.91 ns/op
LinkedList of 24000 items push then pop 19.821 ns/op
intersect bitArray bitLen 8 32.468 ns/op
intersect array and set length 8 183.78 ns/op
intersect bitArray bitLen 128 125.84 ns/op
intersect array and set length 128 2.5455 us/op
Buffer.concat 32 items 6.0640 us/op
Uint8Array.set 32 items 4.6930 us/op
pass gossip attestations to forkchoice per slot 7.3262 ms/op
computeDeltas 7.2211 ms/op
computeProposerBoostScoreFromBalances 3.0094 ms/op
altair processAttestation - 250000 vs - 7PWei normalcase 3.9134 ms/op
altair processAttestation - 250000 vs - 7PWei worstcase 6.4273 ms/op
altair processAttestation - setStatus - 1/6 committees join 224.97 us/op
altair processAttestation - setStatus - 1/3 committees join 433.95 us/op
altair processAttestation - setStatus - 1/2 committees join 624.67 us/op
altair processAttestation - setStatus - 2/3 committees join 802.80 us/op
altair processAttestation - setStatus - 4/5 committees join 1.1181 ms/op
altair processAttestation - setStatus - 100% committees join 1.3332 ms/op
altair processBlock - 250000 vs - 7PWei normalcase 28.861 ms/op
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.496 ms/op
altair processBlock - 250000 vs - 7PWei worstcase 88.382 ms/op
altair processBlock - 250000 vs - 7PWei worstcase hashState 107.85 ms/op
phase0 processBlock - 250000 vs - 7PWei normalcase 3.8863 ms/op
phase0 processBlock - 250000 vs - 7PWei worstcase 51.595 ms/op
altair processEth1Data - 250000 vs - 7PWei normalcase 761.03 us/op
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 19.737 us/op
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 49.568 us/op
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 25.996 us/op
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 22.788 us/op
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 185.83 us/op
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 1.2550 ms/op
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 1.6746 ms/op
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 1.6536 ms/op
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 4.9984 ms/op
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 3.1984 ms/op
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 7.7663 ms/op
Tree 40 250000 create 672.86 ms/op
Tree 40 250000 get(125000) 326.84 ns/op
Tree 40 250000 set(125000) 2.1330 us/op
Tree 40 250000 toArray() 34.424 ms/op
Tree 40 250000 iterate all - toArray() + loop 35.907 ms/op
Tree 40 250000 iterate all - get(i) 115.02 ms/op
MutableVector 250000 create 16.819 ms/op
MutableVector 250000 get(125000) 14.590 ns/op
MutableVector 250000 set(125000) 631.31 ns/op
MutableVector 250000 toArray() 6.7241 ms/op
MutableVector 250000 iterate all - toArray() + loop 6.8461 ms/op
MutableVector 250000 iterate all - get(i) 3.9989 ms/op
Array 250000 create 6.2950 ms/op
Array 250000 clone - spread 2.8293 ms/op
Array 250000 get(125000) 1.2560 ns/op
Array 250000 set(125000) 1.2670 ns/op
Array 250000 iterate all - loop 190.41 us/op
effectiveBalanceIncrements clone Uint8Array 300000 74.550 us/op
effectiveBalanceIncrements clone MutableVector 300000 862.00 ns/op
effectiveBalanceIncrements rw all Uint8Array 300000 285.87 us/op
effectiveBalanceIncrements rw all MutableVector 300000 204.20 ms/op
phase0 afterProcessEpoch - 250000 vs - 7PWei 210.33 ms/op
phase0 beforeProcessEpoch - 250000 vs - 7PWei 111.46 ms/op
altair processEpoch - mainnet_e81889 644.89 ms/op
mainnet_e81889 - altair beforeProcessEpoch 163.39 ms/op
mainnet_e81889 - altair processJustificationAndFinalization 38.055 us/op
mainnet_e81889 - altair processInactivityUpdates 12.338 ms/op
mainnet_e81889 - altair processRewardsAndPenalties 103.24 ms/op
mainnet_e81889 - altair processRegistryUpdates 8.5670 us/op
mainnet_e81889 - altair processSlashings 1.7540 us/op
mainnet_e81889 - altair processEth1DataReset 1.8920 us/op
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.7935 ms/op
mainnet_e81889 - altair processSlashingsReset 12.455 us/op
mainnet_e81889 - altair processRandaoMixesReset 17.112 us/op
mainnet_e81889 - altair processHistoricalRootsUpdate 2.1620 us/op
mainnet_e81889 - altair processParticipationFlagUpdates 9.0580 us/op
mainnet_e81889 - altair processSyncCommitteeUpdates 2.1360 us/op
mainnet_e81889 - altair afterProcessEpoch 216.61 ms/op
phase0 processEpoch - mainnet_e58758 582.37 ms/op
mainnet_e58758 - phase0 beforeProcessEpoch 253.65 ms/op
mainnet_e58758 - phase0 processJustificationAndFinalization 30.719 us/op
mainnet_e58758 - phase0 processRewardsAndPenalties 153.71 ms/op
mainnet_e58758 - phase0 processRegistryUpdates 22.668 us/op
mainnet_e58758 - phase0 processSlashings 1.8460 us/op
mainnet_e58758 - phase0 processEth1DataReset 1.9050 us/op
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.3546 ms/op
mainnet_e58758 - phase0 processSlashingsReset 10.262 us/op
mainnet_e58758 - phase0 processRandaoMixesReset 15.015 us/op
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.9780 us/op
mainnet_e58758 - phase0 processParticipationRecordUpdates 13.149 us/op
mainnet_e58758 - phase0 afterProcessEpoch 184.34 ms/op
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.4354 ms/op
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.7703 ms/op
altair processInactivityUpdates - 250000 normalcase 43.659 ms/op
altair processInactivityUpdates - 250000 worstcase 42.315 ms/op
phase0 processRegistryUpdates - 250000 normalcase 16.588 us/op
phase0 processRegistryUpdates - 250000 badcase_full_deposits 576.34 us/op
phase0 processRegistryUpdates - 250000 worstcase 0.5 224.01 ms/op
altair processRewardsAndPenalties - 250000 normalcase 98.955 ms/op
altair processRewardsAndPenalties - 250000 worstcase 133.96 ms/op
phase0 getAttestationDeltas - 250000 normalcase 14.028 ms/op
phase0 getAttestationDeltas - 250000 worstcase 14.369 ms/op
phase0 processSlashings - 250000 worstcase 6.3004 ms/op
altair processSyncCommitteeUpdates - 250000 295.92 ms/op
BeaconState.hashTreeRoot - No change 490.00 ns/op
BeaconState.hashTreeRoot - 1 full validator 71.953 us/op
BeaconState.hashTreeRoot - 32 full validator 744.13 us/op
BeaconState.hashTreeRoot - 512 full validator 7.4802 ms/op
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 87.703 us/op
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3235 ms/op
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.799 ms/op
BeaconState.hashTreeRoot - 1 balances 61.832 us/op
BeaconState.hashTreeRoot - 32 balances 664.02 us/op
BeaconState.hashTreeRoot - 512 balances 6.6437 ms/op
BeaconState.hashTreeRoot - 250000 balances 98.235 ms/op
aggregationBits - 2048 els - zipIndexesInBitList 30.652 us/op
regular array get 100000 times 77.835 us/op
wrappedArray get 100000 times 74.192 us/op
arrayWithProxy get 100000 times 31.645 ms/op
ssz.Root.equals 1.1760 us/op
byteArrayEquals 1.2230 us/op
shuffle list - 16384 els 12.833 ms/op
shuffle list - 250000 els 189.15 ms/op
processSlot - 1 slots 13.317 us/op
processSlot - 32 slots 1.9478 ms/op
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 381.75 us/op
getCommitteeAssignments - req 1 vs - 250000 vc 6.2591 ms/op
getCommitteeAssignments - req 100 vs - 250000 vc 8.6001 ms/op
getCommitteeAssignments - req 1000 vs - 250000 vc 8.9623 ms/op
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 10.390 ns/op
state getBlockRootAtSlot - 250000 vs - 7PWei 1.2681 us/op
computeProposers - vc 250000 17.862 ms/op
computeEpochShuffling - vc 250000 200.52 ms/op
getNextSyncCommittee - vc 250000 298.97 ms/op

by benchmarkbot/action

@twoeths
twoeths marked this pull request as draft February 6, 2023 09:06
@twoeths

twoeths commented Feb 7, 2023

Copy link
Copy Markdown
Member
  • Lodestar sent more goodbye requests on beta/mainnet nodes, on a 7-day timeframe

Screen Shot 2023-02-07 at 13 35 09

Screen Shot 2023-02-07 at 13 35 19

  • Mesh peers are a bit low but I assume it'd take time to build up as we don't change gossipsub part (this is still the same mesh peers I see in other prod nodes)

Screen Shot 2023-02-07 at 13 37 10

Except for that I don't see other differences, this is not a big change anyway

@wemeetagain
wemeetagain marked this pull request as ready for review February 7, 2023 19:51
@wemeetagain
wemeetagain merged commit 440c59f into stable Feb 7, 2023
@wemeetagain
wemeetagain deleted the rc/v1.4.2 branch February 7, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twoeths twoeths twoeths approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wemeetagain @twoeths @g11tech