Remove unused eslint disable directives

packages/api/src/beacon/client/debug.ts

@@ -38,7 +38,6 @@ export function getClient(_config: IChainForkConfig, httpClient: IHttpClient): A
           timeoutMs: GET_STATE_TIMEOUT_MS,
         });
         // Casting to any otherwise Typescript doesn't like the multi-type return
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-explicit-any
         return {
           ok: true,
           response: new Uint8Array(res.body),
@@ -58,7 +57,6 @@ export function getClient(_config: IChainForkConfig, httpClient: IHttpClient): A
           timeoutMs: GET_STATE_TIMEOUT_MS,
         });
         // Casting to any otherwise Typescript doesn't like the multi-type return
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-explicit-any
         return {ok: true, response: new Uint8Array(res.body), status: res.status} as ApiClientResponse<{
           [HttpStatusCode.OK]: Uint8Array;
         }>;

packages/api/src/beacon/routes/beacon/index.ts

@@ -48,7 +48,7 @@ export type ReqTypes = {
   [K in keyof ReturnType<typeof getReqSerializers>]: ReturnType<ReturnType<typeof getReqSerializers>[K]["writeReq"]>;
 };
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function getReqSerializers(config: IChainForkConfig) {
   return {
     getGenesis: reqEmpty,

packages/api/src/beacon/routes/events.ts

@@ -200,7 +200,7 @@ export function getTypeByEvent(): {[K in EventType]: Type<EventData[K]>} {
   };
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function getEventSerdes() {
   const typeByEvent = getTypeByEvent();
 

packages/api/src/beacon/routes/lodestar.ts

@@ -213,7 +213,6 @@ export function getReqSerializers(): ReqSerializers<Api, ReqTypes> {
   };
 }
 
-/* eslint-disable @typescript-eslint/naming-convention */
 export function getReturnTypes(): ReturnTypes<Api> {
   return {
     writeHeapdump: sameType(),

packages/api/src/interfaces.ts

@@ -1,7 +1,7 @@
 import {HttpStatusCode, HttpSuccessCodes} from "./utils/client/httpStatusCode.js";
 import {Resolves} from "./utils/types.js";
 
-/* eslint-disable @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any */
+/* eslint-disable @typescript-eslint/no-explicit-any */
 
 export type APIClientHandler = (...args: any) => PromiseLike<ApiClientResponse>;
 export type APIServerHandler = (...args: any) => PromiseLike<unknown>;

packages/api/src/keymanager/routes.ts

@@ -349,7 +349,6 @@ export function getReqSerializers(): ReqSerializers<Api, ReqTypes> {
   };
 }
 
-/* eslint-disable @typescript-eslint/naming-convention */
 export function getReturnTypes(): ReturnTypes<Api> {
   return {
     listKeys: jsonType("snake"),

packages/api/src/utils/client/client.ts

@@ -12,7 +12,7 @@ import {FetchOpts, HttpError, IHttpClient} from "./httpClient.js";
  * Format FetchFn opts from Fn arguments given a route definition and request serializer.
  * For routes that return only JSOn use @see getGenericJsonClient
  */
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function getFetchOptsSerializer<Fn extends (...args: any) => any, ReqType extends ReqGeneric>(
   routeDef: RouteDef,
   reqSerializer: ReqSerializer<Fn, ReqType>,
@@ -36,7 +36,7 @@ export function getFetchOptsSerializer<Fn extends (...args: any) => any, ReqType
 /**
  * Generate `getFetchOptsSerializer()` functions for all routes in `Api`
  */
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function getFetchOptsSerializers<
   Api extends Record<string, APIClientHandler>,
   ReqTypes extends {[K in keyof Api]: ReqGeneric}

packages/api/src/utils/server/genericJsonServer.ts

@@ -1,5 +1,4 @@
 import {mapValues} from "@lodestar/utils";
-// eslint-disable-next-line import/no-extraneous-dependencies
 import {IChainForkConfig} from "@lodestar/config";
 import {ReqGeneric, TypeJson, Resolves, RouteGroupDefinition} from "../types.js";
 import {getFastifySchema} from "../schema.js";
@@ -9,7 +8,7 @@ import {ServerRoute} from "./types.js";
 
 // See /packages/api/src/routes/index.ts for reasoning
 
-/* eslint-disable @typescript-eslint/no-explicit-any, @typescript-eslint/naming-convention */
+/* eslint-disable @typescript-eslint/no-explicit-any */
 
 export type ServerRoutes<
   Api extends Record<string, APIServerHandler>,

packages/api/src/utils/server/types.ts

@@ -19,7 +19,7 @@ export type ServerRoute<Req extends ReqGeneric = ReqGeneric> = {
   id: string;
 };
 
-/* eslint-disable @typescript-eslint/no-explicit-any, @typescript-eslint/naming-convention */
+/* eslint-disable @typescript-eslint/naming-convention */
 
 /** Adaptor for Fastify v3.x.x route type which has a ton of arguments */
 export type FastifyHandler<Req extends ReqGeneric> = fastify.RouteHandlerMethod<

packages/api/test/unit/beacon/testData/config.ts

@@ -5,8 +5,6 @@ import {activePreset, presetToJson} from "@lodestar/params";
 import {Api} from "../../../../src/beacon/routes/config.js";
 import {GenericServerTestCases} from "../../../utils/genericServerTest.js";
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 const configJson = chainConfigToJson(chainConfig);
 const presetJson = presetToJson(activePreset);
 const jsonSpec = {...configJson, ...presetJson};

packages/api/test/utils/genericServerTest.ts

@@ -49,7 +49,6 @@ export function runGenericServerTest<
       mockApi[routeId].resolves(testCases[routeId].res);
 
       // Do the call
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const res = await (client[routeId] as APIClientHandler)(...(testCase.args as any[]));
 
       // Use spy to assert argument serialization

packages/beacon-node/src/api/impl/events/index.ts

@@ -18,7 +18,7 @@ export function getEventsApi({chain}: Pick<ApiModules, "chain" | "config">): Ser
         const handler = (data: any): void => {
           // TODO: What happens if this handler throws? Does it break the other chain.emitter listeners?
 
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
           onEvent({type: topic, message: data});
         };
 

packages/beacon-node/src/api/impl/lodestar/index.ts

@@ -119,7 +119,6 @@ export function getLodestarApi({
     },
 
     async runGC() {
-      // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
       if (!global.gc) throw Error("You must expose GC running the Node.js process with 'node --expose_gc'");
       global.gc();
     },

packages/beacon-node/src/chain/blocks/index.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-assignment */
 import {allForks} from "@lodestar/types";
 import {toHex} from "@lodestar/utils";
 import {JobItemQueue} from "../../util/queue/index.js";

packages/beacon-node/src/chain/blocks/utils/ownBanner.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-useless-escape */
 export const CAPELLA_OWL_BANNER = String.raw`
 
                                       /^----^\

packages/beacon-node/src/chain/blocks/utils/pandaMergeTransitionBanner.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-useless-escape */
 // Note: 1 extra new line for space
 // Note: String.raw preserve backslash character
 //       see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/raw

packages/beacon-node/src/chain/bls/multithread/worker.ts

@@ -16,8 +16,6 @@ import {chunkifyMaximizeChunkSize} from "./utils.js";
  */
 const BATCHABLE_MIN_PER_CHUNK = 16;
 
-/* eslint-disable no-console */
-
 // Cloned data from instatiation
 const workerData = worker.workerData as WorkerData;
 if (!workerData) throw Error("workerData must be defined");

packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts

@@ -194,7 +194,6 @@ export class AggregatedAttestationPool {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 interface AttestationWithIndex {
   attestation: phase0.Attestation;
   trueBitsCount: number;

packages/beacon-node/src/chain/options.ts

@@ -4,7 +4,6 @@ import {ArchiverOpts} from "./archiver/index.js";
 import {ForkChoiceOpts} from "./forkChoice/index.js";
 import {LightClientServerOpts} from "./lightClient/index.js";
 
-// eslint-disable-next-line @typescript-eslint/ban-types
 export type IChainOptions = BlockProcessOpts &
   ForkChoiceOpts &
   ArchiverOpts &

packages/beacon-node/src/chain/reprocess.ts

@@ -24,7 +24,6 @@ enum ReprocessStatus {
 
 type AwaitingAttestationPromise = {
   resolve: (foundBlock: boolean) => void;
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   promise: Promise<boolean>;
   // there are multiple subnet/aggregated attestations waiting for same promise
   awaitingAttestationsCount: number;

packages/beacon-node/src/constants/network.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
-
 /**
  * For more info on some of these constants:
  * https://github.com/ethereum/consensus-specs/blob/v1.1.10/specs/phase0/p2p-interface.md#configuration
@@ -28,7 +26,6 @@ export enum GoodByeReasonCode {
   BANNED = 251,
 }
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 export const GOODBYE_KNOWN_CODES: Record<string, string> = {
   0: "Unknown",
 

packages/beacon-node/src/db/repositories/stateArchive.ts

@@ -6,8 +6,6 @@ import {Db, Bucket, Repository} from "@lodestar/db";
 import {getStateTypeFromBytes} from "../../util/multifork.js";
 import {getRootIndexKey, storeRootIndex} from "./stateArchiveIndex.js";
 
-/* eslint-disable @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-call */
-
 export class StateArchiveRepository extends Repository<Slot, BeaconStateAllForks> {
   constructor(config: IChainForkConfig, db: Db) {
     // Pick some type but won't be used. Casted to any because no type can match `BeaconStateAllForks`

packages/beacon-node/src/eth1/provider/jwt.ts

@@ -1,9 +1,7 @@
 import type {TAlgorithm} from "jwt-simple";
 // TODO: fix jwt-simple types
-// eslint-disable-next-line import/default
 import jwt from "jwt-simple";
 
-// eslint-disable-next-line import/no-named-as-default-member
 const {encode, decode} = jwt;
 
 /** jwt token has iat which is issued at unix timestamp, and an optional exp for expiry */

packages/beacon-node/src/eth1/provider/utils.ts

@@ -3,8 +3,6 @@ import {bytesToBigInt, bigIntToBytes} from "@lodestar/utils";
 import {fromHexString, toHexString} from "@chainsafe/ssz";
 import {ErrorParseJson} from "./jsonRpcHttpClient.js";
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 /** QUANTITY as defined in ethereum execution layer JSON RPC https://eth.wiki/json-rpc/API */
 export type QUANTITY = string;
 /** DATA as defined in ethereum execution layer JSON RPC https://eth.wiki/json-rpc/API */

packages/beacon-node/src/metrics/metrics/beacon.ts

@@ -7,7 +7,7 @@ export type IBeaconMetrics = ReturnType<typeof createBeaconMetrics>;
  * https://github.com/ethereum/beacon-metrics/ and
  * https://hackmd.io/D5FmoeFZScim_squBFl8oA
  */
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createBeaconMetrics(register: RegistryMetricCreator) {
   return {
     // From https://github.com/ethereum/beacon-metrics/blob/master/metrics.md

packages/beacon-node/src/metrics/metrics/lodestar.ts

@@ -7,7 +7,7 @@ export type ILodestarMetrics = ReturnType<typeof createLodestarMetrics>;
 /**
  * Extra Lodestar custom metrics
  */
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function createLodestarMetrics(
   register: RegistryMetricCreator,
   metadata?: LodestarMetadata,

packages/beacon-node/src/network/gossip/gossipsub.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import {GossipSub, GossipsubEvents} from "@chainsafe/libp2p-gossipsub";
 import {SignaturePolicy, TopicStr} from "@chainsafe/libp2p-gossipsub/types";
 import {PeerScore, PeerScoreParams} from "@chainsafe/libp2p-gossipsub/score";

packages/beacon-node/src/network/gossip/topic.ts

@@ -69,7 +69,7 @@ function stringifyGossipTopicType(topic: GossipTopic): string {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function getGossipSSZType(topic: GossipTopic) {
   switch (topic.type) {
     case GossipType.beacon_block:

packages/beacon-node/src/network/util.ts

@@ -9,8 +9,6 @@ import type {DefaultDialer} from "libp2p/connection-manager/dialer/index.js";
 import type {ENR} from "@chainsafe/discv5";
 import type {Libp2p} from "./interface.js";
 
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
 // peers
 
 /**

packages/beacon-node/src/util/kzg.ts

@@ -32,7 +32,6 @@ export let ckzg: {
 
 // Global variable __dirname no longer available in ES6 modules.
 // Solutions: https://stackoverflow.com/questions/46745014/alternative-for-dirname-in-node-js-when-using-es6-modules
-// eslint-disable-next-line @typescript-eslint/naming-convention
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 export const TRUSTED_SETUP_BIN_FILEPATH = path.join(__dirname, "../../trusted_setup.bin");
 const TRUSTED_SETUP_JSON_FILEPATH = path.join(__dirname, "../../trusted_setup.json");
@@ -49,7 +48,6 @@ export async function initCKZG(): Promise<void> {
   /* eslint-disable import/no-extraneous-dependencies, @typescript-eslint/ban-ts-comment */
   // @ts-ignore
   ckzg = (await import("c-kzg")) as typeof ckzg;
-  /* eslint-enable import/no-extraneous-dependencies, @typescript-eslint/ban-ts-comment */
 }
 
 /**

packages/beacon-node/test/e2e/doppelganger/doppelganger.test.ts

@@ -15,7 +15,6 @@ import {getDevBeaconNode} from "../../utils/node/beacon.js";
 import {waitForEvent} from "../../utils/events/resolver.js";
 import {BeaconNode} from "../../../src/node/index.js";
 
-/* eslint-disable @typescript-eslint/no-unsafe-call,@typescript-eslint/no-unsafe-member-access,@typescript-eslint/no-unsafe-assignment */
 // TODO: Reconsider this tests latter.
 // Doppelganger testing can be split in two items:
 // 1. Can a running beacon node detect liveness of the validator?

packages/beacon-node/test/e2e/eth1/eth1ForBlockProduction.test.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 import "mocha";
 import {promisify} from "node:util";
 import {expect} from "chai";
@@ -79,7 +78,6 @@ describe.skip("eth1 / Eth1Provider", function () {
     });
 
     // Resolves when Eth1ForBlockProduction has fetched both blocks and deposits
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
     const {eth1Datas, deposits} = await (async function resolveWithEth1DataAndDeposits() {
       // eslint-disable-next-line no-constant-condition
       while (true) {

packages/beacon-node/test/e2e/network/peers/peerManager.test.ts

@@ -162,7 +162,6 @@ describe("network / peers / PeerManager", function () {
     const {chain, libp2p, networkEventBus} = await mockModules();
 
     // Simualate a peer connection, get() should return truthy
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
     getConnectionsMap(libp2p.connectionManager).set(peerId1.toString(), [libp2pConnectionOutboud]);
 
     // Subscribe to `peerConnected` event, which must fire after checking peer relevance
@@ -179,7 +178,6 @@ describe("network / peers / PeerManager", function () {
     const {chain, libp2p, reqResp, peerManager, networkEventBus} = await mockModules();
 
     // Simualate a peer connection, get() should return truthy
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
     getConnectionsMap(libp2p.connectionManager).set(peerId1.toString(), [libp2pConnectionOutboud]);
 
     // Subscribe to `peerConnected` event, which must fire after checking peer relevance
@@ -193,7 +191,6 @@ describe("network / peers / PeerManager", function () {
     reqResp.metadata.resolves(remoteMetadata);
 
     // Simualate a peer connection, get() should return truthy
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
     getConnectionsMap(libp2p.connectionManager).set(peerId1.toString(), [libp2pConnectionOutboud]);
     (libp2p.connectionManager as DefaultConnectionManager).dispatchEvent(
       new CustomEvent("peer:connect", {detail: libp2pConnectionOutboud})

packages/beacon-node/test/e2e/network/reqresp.test.ts

@@ -83,7 +83,6 @@ describe("network / ReqResp", function () {
     const peerIdB = await createSecp256k1PeerId();
     const [libp2pA, libp2pB] = await Promise.all([createNode(multiaddr), createNode(multiaddr, peerIdB)]);
 
-    // eslint-disable-next-line
     const notImplemented = async function* <T>(): AsyncIterable<T> {
       throw Error("not implemented");
     };

packages/beacon-node/test/sim/mergemock.test.ts

@@ -24,7 +24,7 @@ import {shell} from "./shell.js";
 // ETH_PORT=8661 ENGINE_PORT=8551 yarn mocha test/sim/mergemock.test.ts
 // ```
 
-/* eslint-disable no-console, @typescript-eslint/naming-convention, quotes */
+/* eslint-disable no-console, @typescript-eslint/naming-convention */
 
 const jwtSecretHex = "0xdc6457099f127cf0bac78de8b297df04951281909db4f58b43def7c7151e765d";
 

packages/beacon-node/test/sim/withdrawal-interop.test.ts

@@ -29,7 +29,7 @@ import {shell} from "./shell.js";
 // EL_BINARY_DIR=g11tech/geth:withdrawals EL_SCRIPT_DIR=gethdocker yarn mocha test/sim/withdrawal-interop.test.ts
 // ```
 
-/* eslint-disable no-console, @typescript-eslint/naming-convention, quotes */
+/* eslint-disable no-console, @typescript-eslint/naming-convention */
 
 const jwtSecretHex = "0xdc6457099f127cf0bac78de8b297df04951281909db4f58b43def7c7151e765d";
 const retryAttempts = defaultExecutionEngineHttpOpts.retryAttempts;

packages/beacon-node/test/spec/bls/index.test.ts

@@ -12,8 +12,6 @@ const skippedTestNames = [
   "deserialization_succeeds_infinity_with_true_b_flag.yaml",
 ];
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 /**
  * File path structure:
  * ```

packages/beacon-node/test/spec/general/ssz_generic.ts

@@ -6,8 +6,6 @@ import {parseSszGenericInvalidTestcase, parseSszGenericValidTestcase} from "../u
 import {runValidSszTest} from "../utils/runValidSszTest.js";
 import {getTestType} from "./ssz_generic_types.js";
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 // Mapping of sszGeneric() fn arguments to the path in spec tests
 //
 //       / config  / fork   / test runner      / test handler / test suite   / test case

packages/beacon-node/test/spec/presets/fork_choice.ts

@@ -26,8 +26,6 @@ import {assertCorrectProgressiveBalances} from "../config.js";
 
 /* eslint-disable @typescript-eslint/naming-convention */
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 const ANCHOR_STATE_FILE_NAME = "anchor_state";
 const ANCHOR_BLOCK_FILE_NAME = "anchor_block";
 const BLOCK_FILE_NAME = "^(block)_([0-9a-zA-Z]+)$";

packages/beacon-node/test/spec/presets/ssz_static.ts

@@ -17,15 +17,6 @@ import {runValidSszTest} from "../utils/runValidSszTest.js";
 //
 // Docs: https://github.com/ethereum/consensus-specs/blob/master/tests/formats/ssz_static/core.md
 
-/* eslint-disable
-  @typescript-eslint/naming-convention,
-  @typescript-eslint/no-unsafe-assignment,
-  @typescript-eslint/no-unsafe-call,
-  @typescript-eslint/no-unsafe-member-access,
-  no-console
-*/
-
-// eslint-disable-next-line
 type Types = Record<string, Type<any>>;
 
 // Mapping of sszGeneric() fn arguments to the path in spec tests