Skip to content

Fix network disconnect peers e2e test on CI #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wemeetagain merged 2 commits into from
Nov 10, 2022
Merged

Fix network disconnect peers e2e test on CI #4747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
623af5a
Increase sleep time for peer disconnect network e2e test
twoeths Nov 10, 2022
0ca2c67
Skip flaky eth1 test
wemeetagain Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/beacon-node/test/e2e/eth1/stream.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {Eth1Provider} from "../../../src/eth1/provider/eth1Provider.js";
import {getGoerliRpcUrl} from "../../testParams.js";
import {Eth1Options} from "../../../src/eth1/options.js";

describe("Eth1 streams", function () {
describe.skip("Eth1 streams", function () {
this.timeout("2 min");

let controller: AbortController;
Expand Down
4 changes: 2 additions & 2 deletions packages/beacon-node/test/e2e/network/network.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ describe("network", function () {
await connected;

const disconnection = Promise.all([onPeerDisconnect(netA), onPeerDisconnect(netB)]);
await sleep(100);
await sleep(200);

await disconnect(netA, netB.peerId);
await disconnection;
await sleep(200);
await sleep(400);

expect(Array.from(netA.getConnectionsByPeer().values()).length).to.equal(0);
expect(Array.from(netB.getConnectionsByPeer().values()).length).to.equal(0);
Expand Down