Skip to content

Remove @chainsafe/abort-controller - #4195

Merged
g11tech merged 1 commit into
unstablefrom
dapplion/AbortController
Jun 26, 2022
Merged

Remove @chainsafe/abort-controller#4195
g11tech merged 1 commit into
unstablefrom
dapplion/AbortController

Conversation

@dapplion

@dapplion dapplion commented Jun 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Description

  • Remove @chainsafe/abort-controller usage in src
  • Remove from dicv5 to prune from yarn.lock. NOTE: Already removed from discv5 once the dep is bumped should be removed
  • Archive @chainsafe/abort-controller @wemeetagain

@dapplion
dapplion requested a review from a team as a code owner June 26, 2022 08:10
@github-actions

github-actions Bot commented Jun 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance Report

鉁旓笍 no performance regression detected

Full benchmark results
Benchmark suite Current: 46b94dd Previous: 31adf55 Ratio
altair processAttestation - 250000 vs - 7PWei normalcase 3.4111 ms/op 4.3352 ms/op 0.79
altair processAttestation - 250000 vs - 7PWei worstcase 5.3301 ms/op 6.9889 ms/op 0.76
altair processAttestation - setStatus - 1/6 committees join 197.58 us/op 242.56 us/op 0.81
altair processAttestation - setStatus - 1/3 committees join 384.96 us/op 466.59 us/op 0.83
altair processAttestation - setStatus - 1/2 committees join 532.89 us/op 652.50 us/op 0.82
altair processAttestation - setStatus - 2/3 committees join 690.28 us/op 847.23 us/op 0.81
altair processAttestation - setStatus - 4/5 committees join 940.63 us/op 1.1573 ms/op 0.81
altair processAttestation - setStatus - 100% committees join 1.1080 ms/op 1.3802 ms/op 0.80
altair processBlock - 250000 vs - 7PWei normalcase 27.809 ms/op 29.980 ms/op 0.93
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.235 ms/op 39.954 ms/op 0.86
altair processBlock - 250000 vs - 7PWei worstcase 78.658 ms/op 96.624 ms/op 0.81
altair processBlock - 250000 vs - 7PWei worstcase hashState 96.543 ms/op 123.96 ms/op 0.78
phase0 processBlock - 250000 vs - 7PWei normalcase 3.3961 ms/op 4.1150 ms/op 0.83
phase0 processBlock - 250000 vs - 7PWei worstcase 45.382 ms/op 56.054 ms/op 0.81
altair processEth1Data - 250000 vs - 7PWei normalcase 723.77 us/op 786.11 us/op 0.92
Tree 40 250000 create 783.09 ms/op 877.40 ms/op 0.89
Tree 40 250000 get(125000) 286.92 ns/op 352.31 ns/op 0.81
Tree 40 250000 set(125000) 2.4474 us/op 2.6691 us/op 0.92
Tree 40 250000 toArray() 32.188 ms/op 37.012 ms/op 0.87
Tree 40 250000 iterate all - toArray() + loop 32.920 ms/op 37.548 ms/op 0.88
Tree 40 250000 iterate all - get(i) 109.28 ms/op 134.96 ms/op 0.81
MutableVector 250000 create 16.968 ms/op 17.417 ms/op 0.97
MutableVector 250000 get(125000) 14.791 ns/op 16.400 ns/op 0.90
MutableVector 250000 set(125000) 618.86 ns/op 679.24 ns/op 0.91
MutableVector 250000 toArray() 6.7452 ms/op 8.3281 ms/op 0.81
MutableVector 250000 iterate all - toArray() + loop 6.7259 ms/op 7.8262 ms/op 0.86
MutableVector 250000 iterate all - get(i) 3.4387 ms/op 4.2966 ms/op 0.80
Array 250000 create 5.7696 ms/op 6.4229 ms/op 0.90
Array 250000 clone - spread 3.6000 ms/op 3.6479 ms/op 0.99
Array 250000 get(125000) 1.5260 ns/op 1.6980 ns/op 0.90
Array 250000 set(125000) 1.5020 ns/op 1.6800 ns/op 0.89
Array 250000 iterate all - loop 167.74 us/op 209.89 us/op 0.80
effectiveBalanceIncrements clone Uint8Array 300000 80.181 us/op 87.984 us/op 0.91
effectiveBalanceIncrements clone MutableVector 300000 1.1170 us/op 1.2490 us/op 0.89
effectiveBalanceIncrements rw all Uint8Array 300000 254.79 us/op 315.57 us/op 0.81
effectiveBalanceIncrements rw all MutableVector 300000 204.12 ms/op 222.04 ms/op 0.92
phase0 afterProcessEpoch - 250000 vs - 7PWei 188.77 ms/op 248.27 ms/op 0.76
phase0 beforeProcessEpoch - 250000 vs - 7PWei 75.591 ms/op 77.520 ms/op 0.98
altair processEpoch - mainnet_e81889 605.43 ms/op 587.21 ms/op 1.03
mainnet_e81889 - altair beforeProcessEpoch 100.33 ms/op 143.93 ms/op 0.70
mainnet_e81889 - altair processJustificationAndFinalization 33.301 us/op 41.104 us/op 0.81
mainnet_e81889 - altair processInactivityUpdates 12.265 ms/op 13.164 ms/op 0.93
mainnet_e81889 - altair processRewardsAndPenalties 156.34 ms/op 154.32 ms/op 1.01
mainnet_e81889 - altair processRegistryUpdates 4.9920 us/op 6.8090 us/op 0.73
mainnet_e81889 - altair processSlashings 1.1340 us/op 1.6190 us/op 0.70
mainnet_e81889 - altair processEth1DataReset 1.2910 us/op 1.8420 us/op 0.70
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.6257 ms/op 3.2180 ms/op 0.82
mainnet_e81889 - altair processSlashingsReset 9.7220 us/op 17.025 us/op 0.57
mainnet_e81889 - altair processRandaoMixesReset 9.0920 us/op 13.716 us/op 0.66
mainnet_e81889 - altair processHistoricalRootsUpdate 1.1820 us/op 2.1400 us/op 0.55
mainnet_e81889 - altair processParticipationFlagUpdates 4.4740 us/op 6.4190 us/op 0.70
mainnet_e81889 - altair processSyncCommitteeUpdates 1.1510 us/op 1.7870 us/op 0.64
mainnet_e81889 - altair afterProcessEpoch 195.99 ms/op 238.64 ms/op 0.82
phase0 processEpoch - mainnet_e58758 519.68 ms/op 598.15 ms/op 0.87
mainnet_e58758 - phase0 beforeProcessEpoch 201.71 ms/op 255.07 ms/op 0.79
mainnet_e58758 - phase0 processJustificationAndFinalization 35.625 us/op 24.894 us/op 1.43
mainnet_e58758 - phase0 processRewardsAndPenalties 86.066 ms/op 85.201 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 15.277 us/op 18.099 us/op 0.84
mainnet_e58758 - phase0 processSlashings 1.3690 us/op 1.4950 us/op 0.92
mainnet_e58758 - phase0 processEth1DataReset 1.2160 us/op 1.5000 us/op 0.81
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1981 ms/op 2.4947 ms/op 0.88
mainnet_e58758 - phase0 processSlashingsReset 7.6870 us/op 8.4760 us/op 0.91
mainnet_e58758 - phase0 processRandaoMixesReset 9.4090 us/op 10.662 us/op 0.88
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.3120 us/op 1.6540 us/op 0.79
mainnet_e58758 - phase0 processParticipationRecordUpdates 8.1890 us/op 10.226 us/op 0.80
mainnet_e58758 - phase0 afterProcessEpoch 163.78 ms/op 226.10 ms/op 0.72
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.9885 ms/op 3.6044 ms/op 0.83
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.3238 ms/op 3.7759 ms/op 0.88
altair processInactivityUpdates - 250000 normalcase 27.095 ms/op 31.704 ms/op 0.85
altair processInactivityUpdates - 250000 worstcase 27.841 ms/op 32.161 ms/op 0.87
phase0 processRegistryUpdates - 250000 normalcase 8.0730 us/op 13.381 us/op 0.60
phase0 processRegistryUpdates - 250000 badcase_full_deposits 584.03 us/op 512.83 us/op 1.14
phase0 processRegistryUpdates - 250000 worstcase 0.5 211.06 ms/op 274.41 ms/op 0.77
altair processRewardsAndPenalties - 250000 normalcase 115.53 ms/op 143.59 ms/op 0.80
altair processRewardsAndPenalties - 250000 worstcase 78.417 ms/op 93.368 ms/op 0.84
phase0 getAttestationDeltas - 250000 normalcase 12.706 ms/op 16.217 ms/op 0.78
phase0 getAttestationDeltas - 250000 worstcase 12.950 ms/op 15.848 ms/op 0.82
phase0 processSlashings - 250000 worstcase 5.4491 ms/op 6.7282 ms/op 0.81
altair processSyncCommitteeUpdates - 250000 284.37 ms/op 345.18 ms/op 0.82
BeaconState.hashTreeRoot - No change 566.00 ns/op 689.00 ns/op 0.82
BeaconState.hashTreeRoot - 1 full validator 62.864 us/op 76.010 us/op 0.83
BeaconState.hashTreeRoot - 32 full validator 737.79 us/op 679.28 us/op 1.09
BeaconState.hashTreeRoot - 512 full validator 6.4236 ms/op 7.6407 ms/op 0.84
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 79.988 us/op 101.01 us/op 0.79
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.2173 ms/op 1.3520 ms/op 0.90
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.179 ms/op 18.667 ms/op 0.81
BeaconState.hashTreeRoot - 1 balances 61.194 us/op 79.006 us/op 0.77
BeaconState.hashTreeRoot - 32 balances 528.57 us/op 669.34 us/op 0.79
BeaconState.hashTreeRoot - 512 balances 5.1123 ms/op 6.1492 ms/op 0.83
BeaconState.hashTreeRoot - 250000 balances 98.640 ms/op 120.42 ms/op 0.82
aggregationBits - 2048 els - zipIndexesInBitList 29.818 us/op 37.411 us/op 0.80
regular array get 100000 times 67.425 us/op 84.337 us/op 0.80
wrappedArray get 100000 times 67.418 us/op 84.397 us/op 0.80
arrayWithProxy get 100000 times 30.738 ms/op 37.787 ms/op 0.81
ssz.Root.equals 450.00 ns/op 593.00 ns/op 0.76
byteArrayEquals 440.00 ns/op 595.00 ns/op 0.74
shuffle list - 16384 els 11.264 ms/op 13.766 ms/op 0.82
shuffle list - 250000 els 165.91 ms/op 202.34 ms/op 0.82
processSlot - 1 slots 11.630 us/op 15.671 us/op 0.74
processSlot - 32 slots 1.7027 ms/op 2.2613 ms/op 0.75
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 383.86 us/op 492.67 us/op 0.78
getCommitteeAssignments - req 1 vs - 250000 vc 5.3308 ms/op 6.5752 ms/op 0.81
getCommitteeAssignments - req 100 vs - 250000 vc 7.3146 ms/op 9.1543 ms/op 0.80
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7843 ms/op 9.7887 ms/op 0.80
computeProposers - vc 250000 18.614 ms/op 22.508 ms/op 0.83
computeEpochShuffling - vc 250000 169.43 ms/op 204.72 ms/op 0.83
getNextSyncCommittee - vc 250000 272.72 ms/op 333.24 ms/op 0.82
pass gossip attestations to forkchoice per slot 5.8047 ms/op 3.9423 ms/op 1.47
computeDeltas 3.8792 ms/op 3.8574 ms/op 1.01
computeProposerBoostScoreFromBalances 907.21 us/op 1.1321 ms/op 0.80
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.0477 ms/op 2.2857 ms/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 79.549 us/op 88.461 us/op 0.90
BLS verify - blst-native 1.8593 ms/op 2.3247 ms/op 0.80
BLS verifyMultipleSignatures 3 - blst-native 3.8087 ms/op 4.7544 ms/op 0.80
BLS verifyMultipleSignatures 8 - blst-native 8.1900 ms/op 10.239 ms/op 0.80
BLS verifyMultipleSignatures 32 - blst-native 29.751 ms/op 37.165 ms/op 0.80
BLS aggregatePubkeys 32 - blst-native 39.185 us/op 49.674 us/op 0.79
BLS aggregatePubkeys 128 - blst-native 153.08 us/op 192.61 us/op 0.79
getAttestationsForBlock 67.093 ms/op 73.192 ms/op 0.92
isKnown best case - 1 super set check 430.00 ns/op 555.00 ns/op 0.77
isKnown normal case - 2 super set checks 415.00 ns/op 538.00 ns/op 0.77
isKnown worse case - 16 super set checks 418.00 ns/op 538.00 ns/op 0.78
CheckpointStateCache - add get delete 10.532 us/op 12.614 us/op 0.83
validate gossip signedAggregateAndProof - struct 4.2595 ms/op 5.3184 ms/op 0.80
validate gossip attestation - struct 2.0277 ms/op 2.5177 ms/op 0.81
altair verifyImport mainnet_s3766816:31 6.1815 s/op 7.4656 s/op 0.83
pickEth1Vote - no votes 2.0357 ms/op 2.5127 ms/op 0.81
pickEth1Vote - max votes 22.569 ms/op 26.196 ms/op 0.86
pickEth1Vote - Eth1Data hashTreeRoot value x2048 11.549 ms/op 13.915 ms/op 0.83
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 19.131 ms/op 23.488 ms/op 0.81
pickEth1Vote - Eth1Data fastSerialize value x2048 1.5421 ms/op 1.8121 ms/op 0.85
pickEth1Vote - Eth1Data fastSerialize tree x2048 16.648 ms/op 17.745 ms/op 0.94
bytes32 toHexString 1.0660 us/op 1.2930 us/op 0.82
bytes32 Buffer.toString(hex) 687.00 ns/op 896.00 ns/op 0.77
bytes32 Buffer.toString(hex) from Uint8Array 917.00 ns/op 1.1640 us/op 0.79
bytes32 Buffer.toString(hex) + 0x 695.00 ns/op 889.00 ns/op 0.78
Object access 1 prop 0.33900 ns/op 0.47500 ns/op 0.71
Map access 1 prop 0.29600 ns/op 0.41800 ns/op 0.71
Object get x1000 18.402 ns/op 25.442 ns/op 0.72
Map get x1000 0.99200 ns/op 1.2720 ns/op 0.78
Object set x1000 110.37 ns/op 137.06 ns/op 0.81
Map set x1000 66.069 ns/op 83.608 ns/op 0.79
Return object 10000 times 0.37300 ns/op 0.47350 ns/op 0.79
Throw Error 10000 times 5.9491 us/op 7.4267 us/op 0.80
enrSubnets - fastDeserialize 64 bits 2.5670 us/op 3.1040 us/op 0.83
enrSubnets - ssz BitVector 64 bits 714.00 ns/op 929.00 ns/op 0.77
enrSubnets - fastDeserialize 4 bits 357.00 ns/op 491.00 ns/op 0.73
enrSubnets - ssz BitVector 4 bits 704.00 ns/op 919.00 ns/op 0.77
prioritizePeers score -10:0 att 32-0.1 sync 2-0 89.993 us/op 113.47 us/op 0.79
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 131.75 us/op 153.69 us/op 0.86
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 213.96 us/op 253.12 us/op 0.85
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 390.38 us/op 535.91 us/op 0.73
prioritizePeers score 0:0 att 64-1 sync 4-1 463.29 us/op 571.63 us/op 0.81
RateTracker 1000000 limit, 1 obj count per request 184.19 ns/op 223.83 ns/op 0.82
RateTracker 1000000 limit, 2 obj count per request 137.05 ns/op 168.60 ns/op 0.81
RateTracker 1000000 limit, 4 obj count per request 112.00 ns/op 138.92 ns/op 0.81
RateTracker 1000000 limit, 8 obj count per request 100.82 ns/op 126.15 ns/op 0.80
RateTracker with prune 4.2460 us/op 5.0680 us/op 0.84
array of 16000 items push then shift 3.1709 us/op 3.8584 us/op 0.82
LinkedList of 16000 items push then shift 25.426 ns/op 27.168 ns/op 0.94
array of 16000 items push then pop 240.56 ns/op 278.78 ns/op 0.86
LinkedList of 16000 items push then pop 22.334 ns/op 23.860 ns/op 0.94
array of 24000 items push then shift 4.5543 us/op 5.7040 us/op 0.80
LinkedList of 24000 items push then shift 26.157 ns/op 29.129 ns/op 0.90
array of 24000 items push then pop 183.52 ns/op 231.29 ns/op 0.79
LinkedList of 24000 items push then pop 22.133 ns/op 23.914 ns/op 0.93
intersect bitArray bitLen 8 11.425 ns/op 14.859 ns/op 0.77
intersect array and set length 8 156.50 ns/op 195.86 ns/op 0.80
intersect bitArray bitLen 128 71.953 ns/op 90.249 ns/op 0.80
intersect array and set length 128 2.1951 us/op 2.6715 us/op 0.82

by benchmarkbot/action

g11tech
g11tech previously approved these changes Jun 26, 2022
View reviewed changes
@dapplion
dapplion force-pushed the dapplion/AbortController branch from 1014127 to 6aa10e6 Compare June 26, 2022 10:32
@g11tech
g11tech force-pushed the dapplion/AbortController branch from 6aa10e6 to 99e8630 Compare June 26, 2022 11:27
@g11tech
g11tech enabled auto-merge (squash) June 26, 2022 11:27
@g11tech
g11tech merged commit 0553523 into unstable Jun 26, 2022
@g11tech
g11tech deleted the dapplion/AbortController branch June 26, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@g11tech g11tech g11tech approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dapplion @g11tech