Simplify HttpClient global AbortSignal handling - #4108
Closed
dapplion wants to merge 2 commits into
Closed
Conversation
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
dapplion
changed the title
wemeetagain
approved these changes
Jun 3, 2022
wemeetagain
reviewed
Jun 3, 2022
| this.logger = logger ?? null; | ||
| } | ||
|
|
||
| setAbortSignal(signal: AbortSignal): void { |
Member
There was a problem hiding this comment.
should this only be allowed once? Eg: if (this.signal) throw .. else this.signal = signal
Contributor
Author
There was a problem hiding this comment.
No, to allow the validator client to work it must allowed N times. Every time the validator is started a new signal is created, so it must be set to the HttpClient every time.
Member
There was a problem hiding this comment.
I forget that our validator can start and stop (and restart). I still think its weird.
ightevenmckane1
suggested changes
Jun 5, 2022
ightevenmckane1
left a comment
ightevenmckane1
left a comment
There was a problem hiding this comment.
Looking back on mergers and file changes and deletions and restrictions on main branches.Like to know more on these changes.
Member
|
closing in favor of #4178 and subsequent refactors that it allows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify how global signals are provided to the HttpClient instance.
Description
Instead of providing a function to get the global signal everytime, add a method to update the global signal only when necessary. In my opinion it makes consuming the library less awkward, and this complexity is hidden for consumers that don't need to update the signals.