Skip to content

Bump ssz - #4093

Merged
g11tech merged 2 commits into
unstablefrom
tuyen/ssz-0.9.2
May 31, 2022
Merged

Bump ssz#4093
g11tech merged 2 commits into
unstablefrom
tuyen/ssz-0.9.2

Conversation

@twoeths

@twoeths twoeths commented May 31, 2022

Copy link
Copy Markdown
Member

Motivation

Fix block proposal error

error: Req req-137a produceBlock error  code=ETH1_ERROR_WRONG_DEPOSIT_ROOT, root=0x0aaa0f8770b01734c82342a56ef0de51e9e3eec86a124b0abbde1356e8b82dd7, expectedRoot=0xd70a234731285c6804c2a4f56711ddb8c82c99740f207854891028af34e27e5e
Error: ETH1_ERROR_WRONG_DEPOSIT_ROOT

Description

The root cause was fixed in ssz 0.9.2, bump ssz

Closes #4088

@twoeths
twoeths requested a review from a team as a code owner May 31, 2022 06:46
@github-actions

github-actions Bot commented May 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance Report

鉁旓笍 no performance regression detected

Full benchmark results
Benchmark suite Current: 93fcf13 Previous: d5d3d6b Ratio
BeaconState.hashTreeRoot - No change 472.00 ns/op 534.00 ns/op 0.88
BeaconState.hashTreeRoot - 1 full validator 66.989 us/op 68.019 us/op 0.98
BeaconState.hashTreeRoot - 32 full validator 659.60 us/op 687.93 us/op 0.96
BeaconState.hashTreeRoot - 512 full validator 6.9846 ms/op 7.3072 ms/op 0.96
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 83.427 us/op 86.953 us/op 0.96
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1278 ms/op 1.1937 ms/op 0.94
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 14.764 ms/op 16.336 ms/op 0.90
BeaconState.hashTreeRoot - 1 balances 64.586 us/op 65.927 us/op 0.98
BeaconState.hashTreeRoot - 32 balances 566.00 us/op 570.71 us/op 0.99
BeaconState.hashTreeRoot - 512 balances 5.3851 ms/op 5.5274 ms/op 0.97
BeaconState.hashTreeRoot - 250000 balances 113.50 ms/op 125.37 ms/op 0.91
processSlot - 1 slots 11.717 us/op 12.630 us/op 0.93
processSlot - 32 slots 1.8055 ms/op 1.9256 ms/op 0.94
getCommitteeAssignments - req 1 vs - 250000 vc 5.3608 ms/op 6.5733 ms/op 0.82
getCommitteeAssignments - req 100 vs - 250000 vc 7.8804 ms/op 9.0007 ms/op 0.88
getCommitteeAssignments - req 1000 vs - 250000 vc 8.3974 ms/op 9.7818 ms/op 0.86
computeProposers - vc 250000 16.639 ms/op 19.248 ms/op 0.86
computeEpochShuffling - vc 250000 172.44 ms/op 204.01 ms/op 0.85
getNextSyncCommittee - vc 250000 274.34 ms/op 315.79 ms/op 0.87
altair processAttestation - 250000 vs - 7PWei normalcase 3.2139 ms/op 4.1682 ms/op 0.77
altair processAttestation - 250000 vs - 7PWei worstcase 4.8275 ms/op 6.0953 ms/op 0.79
altair processAttestation - setStatus - 1/6 committees join 156.51 us/op 236.76 us/op 0.66
altair processAttestation - setStatus - 1/3 committees join 318.97 us/op 446.12 us/op 0.72
altair processAttestation - setStatus - 1/2 committees join 459.37 us/op 623.53 us/op 0.74
altair processAttestation - setStatus - 2/3 committees join 606.32 us/op 833.56 us/op 0.73
altair processAttestation - setStatus - 4/5 committees join 837.43 us/op 1.1410 ms/op 0.73
altair processAttestation - setStatus - 100% committees join 1.0208 ms/op 1.3437 ms/op 0.76
altair processBlock - 250000 vs - 7PWei normalcase 21.265 ms/op 28.686 ms/op 0.74
altair processBlock - 250000 vs - 7PWei normalcase hashState 33.529 ms/op 39.130 ms/op 0.86
altair processBlock - 250000 vs - 7PWei worstcase 73.710 ms/op 86.454 ms/op 0.85
altair processBlock - 250000 vs - 7PWei worstcase hashState 104.02 ms/op 115.59 ms/op 0.90
altair processEth1Data - 250000 vs - 7PWei normalcase 665.45 us/op 969.79 us/op 0.69
altair processEpoch - mainnet_e81889 529.28 ms/op 653.52 ms/op 0.81
mainnet_e81889 - altair beforeProcessEpoch 71.717 ms/op 149.41 ms/op 0.48
mainnet_e81889 - altair processJustificationAndFinalization 29.301 us/op 33.780 us/op 0.87
mainnet_e81889 - altair processInactivityUpdates 8.4719 ms/op 13.240 ms/op 0.64
mainnet_e81889 - altair processRewardsAndPenalties 114.65 ms/op 159.40 ms/op 0.72
mainnet_e81889 - altair processRegistryUpdates 5.5820 us/op 6.7820 us/op 0.82
mainnet_e81889 - altair processSlashings 1.1970 us/op 2.3360 us/op 0.51
mainnet_e81889 - altair processEth1DataReset 1.2550 us/op 1.9570 us/op 0.64
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.4517 ms/op 3.1090 ms/op 0.79
mainnet_e81889 - altair processSlashingsReset 8.1390 us/op 9.8740 us/op 0.82
mainnet_e81889 - altair processRandaoMixesReset 7.5620 us/op 12.068 us/op 0.63
mainnet_e81889 - altair processHistoricalRootsUpdate 1.5360 us/op 2.1440 us/op 0.72
mainnet_e81889 - altair processParticipationFlagUpdates 4.4070 us/op 5.7350 us/op 0.77
mainnet_e81889 - altair processSyncCommitteeUpdates 1.1140 us/op 1.8950 us/op 0.59
mainnet_e81889 - altair afterProcessEpoch 197.27 ms/op 235.64 ms/op 0.84
altair processInactivityUpdates - 250000 normalcase 26.000 ms/op 39.024 ms/op 0.67
altair processInactivityUpdates - 250000 worstcase 21.487 ms/op 33.624 ms/op 0.64
altair processRewardsAndPenalties - 250000 normalcase 91.839 ms/op 151.16 ms/op 0.61
altair processRewardsAndPenalties - 250000 worstcase 89.555 ms/op 89.842 ms/op 1.00
altair processSyncCommitteeUpdates - 250000 279.91 ms/op 327.61 ms/op 0.85
Tree 40 250000 create 593.30 ms/op 882.91 ms/op 0.67
Tree 40 250000 get(125000) 247.44 ns/op 344.36 ns/op 0.72
Tree 40 250000 set(125000) 1.9806 us/op 2.6228 us/op 0.76
Tree 40 250000 toArray() 24.060 ms/op 36.367 ms/op 0.66
Tree 40 250000 iterate all - toArray() + loop 24.409 ms/op 37.792 ms/op 0.65
Tree 40 250000 iterate all - get(i) 107.15 ms/op 133.79 ms/op 0.80
MutableVector 250000 create 12.299 ms/op 17.632 ms/op 0.70
MutableVector 250000 get(125000) 11.009 ns/op 15.974 ns/op 0.69
MutableVector 250000 set(125000) 526.81 ns/op 732.15 ns/op 0.72
MutableVector 250000 toArray() 4.9659 ms/op 7.7001 ms/op 0.64
MutableVector 250000 iterate all - toArray() + loop 5.0861 ms/op 7.9299 ms/op 0.64
MutableVector 250000 iterate all - get(i) 2.7225 ms/op 4.0330 ms/op 0.68
Array 250000 create 5.0300 ms/op 6.5880 ms/op 0.76
Array 250000 clone - spread 3.1094 ms/op 4.1583 ms/op 0.75
Array 250000 get(125000) 1.4620 ns/op 1.7560 ns/op 0.83
Array 250000 set(125000) 1.4560 ns/op 1.7320 ns/op 0.84
Array 250000 iterate all - loop 150.90 us/op 207.18 us/op 0.73
effectiveBalanceIncrements clone Uint8Array 300000 59.723 us/op 89.042 us/op 0.67
effectiveBalanceIncrements clone MutableVector 300000 647.00 ns/op 765.00 ns/op 0.85
effectiveBalanceIncrements rw all Uint8Array 300000 247.33 us/op 310.86 us/op 0.80
effectiveBalanceIncrements rw all MutableVector 300000 138.04 ms/op 186.08 ms/op 0.74
aggregationBits - 2048 els - zipIndexesInBitList 21.360 us/op 29.656 us/op 0.72
regular array get 100000 times 60.544 us/op 81.756 us/op 0.74
wrappedArray get 100000 times 79.665 us/op 83.395 us/op 0.96
arrayWithProxy get 100000 times 32.563 ms/op 41.800 ms/op 0.78
ssz.Root.equals 461.00 ns/op 537.00 ns/op 0.86
byteArrayEquals 440.00 ns/op 531.00 ns/op 0.83
phase0 processBlock - 250000 vs - 7PWei normalcase 3.0650 ms/op 4.0504 ms/op 0.76
phase0 processBlock - 250000 vs - 7PWei worstcase 49.345 ms/op 54.110 ms/op 0.91
phase0 afterProcessEpoch - 250000 vs - 7PWei 189.97 ms/op 224.69 ms/op 0.85
phase0 beforeProcessEpoch - 250000 vs - 7PWei 55.451 ms/op 78.984 ms/op 0.70
phase0 processEpoch - mainnet_e58758 464.62 ms/op 595.85 ms/op 0.78
mainnet_e58758 - phase0 beforeProcessEpoch 168.21 ms/op 255.19 ms/op 0.66
mainnet_e58758 - phase0 processJustificationAndFinalization 32.562 us/op 34.085 us/op 0.96
mainnet_e58758 - phase0 processRewardsAndPenalties 60.259 ms/op 149.36 ms/op 0.40
mainnet_e58758 - phase0 processRegistryUpdates 17.272 us/op 17.092 us/op 1.01
mainnet_e58758 - phase0 processSlashings 1.5230 us/op 2.0250 us/op 0.75
mainnet_e58758 - phase0 processEth1DataReset 1.5030 us/op 2.0660 us/op 0.73
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.8497 ms/op 2.8014 ms/op 0.66
mainnet_e58758 - phase0 processSlashingsReset 7.9390 us/op 9.9250 us/op 0.80
mainnet_e58758 - phase0 processRandaoMixesReset 8.5840 us/op 10.519 us/op 0.82
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.6170 us/op 2.3080 us/op 0.70
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.7740 us/op 11.520 us/op 0.67
mainnet_e58758 - phase0 afterProcessEpoch 165.52 ms/op 194.84 ms/op 0.85
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.1027 ms/op 3.5451 ms/op 0.59
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.3913 ms/op 3.7206 ms/op 0.64
phase0 processRegistryUpdates - 250000 normalcase 10.038 us/op 14.955 us/op 0.67
phase0 processRegistryUpdates - 250000 badcase_full_deposits 675.92 us/op 535.57 us/op 1.26
phase0 processRegistryUpdates - 250000 worstcase 0.5 167.28 ms/op 251.06 ms/op 0.67
phase0 getAttestationDeltas - 250000 normalcase 11.344 ms/op 15.988 ms/op 0.71
phase0 getAttestationDeltas - 250000 worstcase 11.779 ms/op 16.130 ms/op 0.73
phase0 processSlashings - 250000 worstcase 5.3556 ms/op 6.6390 ms/op 0.81
shuffle list - 16384 els 11.562 ms/op 13.483 ms/op 0.86
shuffle list - 250000 els 170.02 ms/op 198.63 ms/op 0.86
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 346.56 us/op 614.27 us/op 0.56
pass gossip attestations to forkchoice per slot 2.8642 ms/op 3.9007 ms/op 0.73
computeDeltas 3.1283 ms/op 3.6311 ms/op 0.86
computeProposerBoostScoreFromBalances 803.85 us/op 1.1162 ms/op 0.72
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.5368 ms/op 2.0075 ms/op 0.77
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 62.200 us/op 97.807 us/op 0.64
BLS verify - blst-native 2.2081 ms/op 2.2994 ms/op 0.96
BLS verifyMultipleSignatures 3 - blst-native 4.5096 ms/op 4.7294 ms/op 0.95
BLS verifyMultipleSignatures 8 - blst-native 9.7191 ms/op 10.301 ms/op 0.94
BLS verifyMultipleSignatures 32 - blst-native 35.337 ms/op 36.232 ms/op 0.98
BLS aggregatePubkeys 32 - blst-native 47.209 us/op 48.993 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 183.88 us/op 188.72 us/op 0.97
getAttestationsForBlock 50.217 ms/op 78.337 ms/op 0.64
isKnown best case - 1 super set check 488.00 ns/op 550.00 ns/op 0.89
isKnown normal case - 2 super set checks 486.00 ns/op 514.00 ns/op 0.95
isKnown worse case - 16 super set checks 477.00 ns/op 523.00 ns/op 0.91
CheckpointStateCache - add get delete 10.339 us/op 12.397 us/op 0.83
validate gossip signedAggregateAndProof - struct 5.0140 ms/op 5.1869 ms/op 0.97
validate gossip attestation - struct 2.3630 ms/op 2.4787 ms/op 0.95
altair verifyImport mainnet_s3766816:31 6.7984 s/op 7.4371 s/op 0.91
pickEth1Vote - no votes 2.1008 ms/op 2.5218 ms/op 0.83
pickEth1Vote - max votes 21.750 ms/op 26.136 ms/op 0.83
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.268 ms/op 13.594 ms/op 0.98
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.148 ms/op 24.028 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize value x2048 1.3926 ms/op 1.8487 ms/op 0.75
pickEth1Vote - Eth1Data fastSerialize tree x2048 12.301 ms/op 16.872 ms/op 0.73
bytes32 toHexString 938.00 ns/op 1.2110 us/op 0.77
bytes32 Buffer.toString(hex) 721.00 ns/op 820.00 ns/op 0.88
bytes32 Buffer.toString(hex) from Uint8Array 963.00 ns/op 1.0330 us/op 0.93
bytes32 Buffer.toString(hex) + 0x 743.00 ns/op 791.00 ns/op 0.94
Object access 1 prop 0.37200 ns/op 0.41800 ns/op 0.89
Map access 1 prop 0.33700 ns/op 0.36000 ns/op 0.94
Object get x1000 11.122 ns/op 21.353 ns/op 0.52
Map get x1000 1.0160 ns/op 1.2060 ns/op 0.84
Object set x1000 68.425 ns/op 132.35 ns/op 0.52
Map set x1000 44.918 ns/op 78.176 ns/op 0.57
Return object 10000 times 0.44290 ns/op 0.46020 ns/op 0.96
Throw Error 10000 times 6.0332 us/op 7.3402 us/op 0.82
enrSubnets - fastDeserialize 64 bits 2.5090 us/op 3.1000 us/op 0.81
enrSubnets - ssz BitVector 64 bits 784.00 ns/op 876.00 ns/op 0.89
enrSubnets - fastDeserialize 4 bits 380.00 ns/op 437.00 ns/op 0.87
enrSubnets - ssz BitVector 4 bits 823.00 ns/op 875.00 ns/op 0.94
prioritizePeers score -10:0 att 32-0.1 sync 2-0 78.354 us/op 112.98 us/op 0.69
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 123.92 us/op 150.85 us/op 0.82
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 185.19 us/op 249.98 us/op 0.74
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 368.17 us/op 532.58 us/op 0.69
prioritizePeers score 0:0 att 64-1 sync 4-1 448.15 us/op 571.75 us/op 0.78
RateTracker 1000000 limit, 1 obj count per request 174.47 ns/op 221.77 ns/op 0.79
RateTracker 1000000 limit, 2 obj count per request 128.23 ns/op 167.63 ns/op 0.76
RateTracker 1000000 limit, 4 obj count per request 102.70 ns/op 138.60 ns/op 0.74
RateTracker 1000000 limit, 8 obj count per request 91.310 ns/op 126.94 ns/op 0.72
RateTracker with prune 3.5960 us/op 5.0490 us/op 0.71
array of 16000 items push then shift 51.557 us/op 3.7983 us/op 13.57
LinkedList of 16000 items push then shift 15.640 ns/op 26.682 ns/op 0.59
array of 16000 items push then pop 177.57 ns/op 266.68 ns/op 0.67
LinkedList of 16000 items push then pop 13.807 ns/op 23.052 ns/op 0.60
array of 24000 items push then shift 77.331 us/op 5.4475 us/op 14.20
LinkedList of 24000 items push then shift 17.403 ns/op 27.233 ns/op 0.64
array of 24000 items push then pop 163.96 ns/op 224.54 ns/op 0.73
LinkedList of 24000 items push then pop 14.592 ns/op 23.441 ns/op 0.62
intersect bitArray bitLen 8 10.674 ns/op 14.573 ns/op 0.73
intersect array and set length 8 121.31 ns/op 190.15 ns/op 0.64
intersect bitArray bitLen 128 55.657 ns/op 89.375 ns/op 0.62
intersect array and set length 128 1.6621 us/op 2.5843 us/op 0.64

by benchmarkbot/action

@g11tech
g11tech merged commit d2e0045 into unstable May 31, 2022
@g11tech
g11tech deleted the tuyen/ssz-0.9.2 branch May 31, 2022 12:35
@kalbroni7 kalbroni7 mentioned this pull request Jul 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@g11tech g11tech g11tech approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error proposing blocks in Ropsten beacon chain

2 participants

@twoeths @g11tech