Correct Aggregate Inclusion metric - #4081
Closed
twoeths wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Tested in contabo-8
|
twoeths
marked this pull request as ready for review
May 29, 2022 10:01
wemeetagain
reviewed
May 30, 2022
wemeetagain
left a comment
wemeetagain
left a comment
Member
There was a problem hiding this comment.
wont this introduce false positives too? invalid attestations being counted
dapplion
suggested changes
May 30, 2022
dapplion
left a comment
dapplion
left a comment
Contributor
There was a problem hiding this comment.
Initially I though it was important to track all aggregate for inclusion.
However, seeing the costs and dangers of doing so I am fine by only tracking novel aggregate inclusion. The metric will still fulfill it's purpose, which is showing that we got aggregated. To detect poor gossip performance we can still check the duplicate factor in gossip metrics. The combination of both should provide the same level of info as before.
So I would vote for closing this PR and ignoring my warning for v0.37.0 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Due to #4019, Aggregate Inclusion metric dropped. We want to get it back to the previous state.
Description
chain.seenAggregatedAttestations.isKnown()check, about 70% of AggregateAndProof gossip messages were caught by that