Persist invalid SSZ objects only if enabled - #3797
Merged
Merged
Conversation
dapplion
requested review from
g11tech,
twoeths and
wemeetagain
as code owners
February 27, 2022 04:08
dapplion
marked this pull request as draft
February 27, 2022 04:08
dapplion
added
prio-high
Contributor
Author
|
Note: without this PR, the persist invalid SSZ objects is a DOS vector as it will fill the disk with junk until running out of space |
twoeths
force-pushed
the
dapplion/persist-ssz-if-enabled
branch
from
May 27, 2022 04:52
66473e2 to
a607841
Compare
twoeths
marked this pull request as ready for review
May 27, 2022 06:39
g11tech
approved these changes
May 27, 2022
wemeetagain
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the the beacon node persists to disk invalid SSZ objects. This functionality is absolutely critical to debug consensus bugs and issues with gossip validation. However, this feature should not be enabled by default in production servers. Only us or debuggers should use this feature.
Description
Closes #4069
part of #4002