Publish exact dependencies for nighly release - #3679
Merged
Conversation
g11tech
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
January 29, 2022 09:05
Codecov Report
@@ Coverage Diff @@
## master #3679 +/- ##
=======================================
Coverage 37.20% 37.20%
=======================================
Files 322 322
Lines 8717 8717
Branches 1349 1349
=======================================
Hits 3243 3243
Misses 5332 5332
Partials 142 142 |
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
dapplion
approved these changes
Jan 29, 2022
dapplion
left a comment
Contributor
There was a problem hiding this comment.
Thanks for looking into this! I agree it's a good approach, consumers of this versions are okay not getting semver PATCH updates since this should be used in testing environments
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
npm install is not able to resolve the dev versioned dependencies specified with
^operator for e.g.@chainsafe/lodestar-config@^0.34.0-dev.4resolves to =>0.34.0whennpm install @chainsafe/lodestar-cli@^0.34.0-dev.4is done.On a bit of digging through on internet, people have tried using
--exactversion in lerna publish to make npm resolve the exact package. Hopefully this fixes the dependency resolution in the install, and wll fix the nightly buildCloses #3676