Fix nightly release workflow - #3637
Merged
Merged
Conversation
g11tech
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
January 18, 2022 19:02
Codecov Report
@@ Coverage Diff @@
## master #3637 +/- ##
=======================================
Coverage 37.18% 37.18%
=======================================
Files 320 320
Lines 8629 8629
Branches 1336 1336
=======================================
Hits 3209 3209
Misses 5272 5272
Partials 148 148 |
|
Code Climate has analyzed commit 94e67f6 and detected 0 issues on this pull request. View more on Code Climate. |
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
dapplion
approved these changes
Jan 18, 2022
dapplion
left a comment
dapplion
left a comment
Contributor
There was a problem hiding this comment.
Lerna is more confusing than a proof of stake protocol lol let's see if this works
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A previous PR #3601 which aimed to fix how the nightly
--canaryversions were being tagged, usedfrom-packageinlerna publish. However it was discovered that usingfrom-packageflag totatly ignore any other options with lerna comparing the published versions against package.json's version.This PR restores the original
lerna publish --canary...and adds comments as to how to make sure it produces correct publishing tag.Description
Lerna publish ignores what are called
lightweightorcommittags (dogit for-each-ref refs/tagsto get tag type). It only takes into care the properannotatedtags, which can be produced by git tag -a option, or better through lerna publish. It seems like, the tags post 0.32 are light weight:and lerna publish --canarary gives these tags as 0.32.0 is the last proper annotated tag:
So original lerna publish --canary --force-publish will work correctly with the correct tagging.