Skip to content

Improve processEffectiveBalanceUpdates #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dapplion merged 3 commits into from
Jul 29, 2021
Merged

Improve processEffectiveBalanceUpdates #2902

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28f69cc
Improve processEffectiveBalanceUpdates
twoeths Jul 29, 2021
f39a129
Change the condition to check effectiveBalance
twoeths Jul 29, 2021
aa53fed
Avoid new variables
twoeths Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/beacon-state-transition/src/allForks/epoch/processEffectiveBalanceUpdates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ export function processEffectiveBalanceUpdates(
// update effective balances with hysteresis
(process.balances ?? state.balances).forEach((balance: bigint, i: number) => {
const effectiveBalance = process.validators[i].effectiveBalance;
if (balance + DOWNWARD_THRESHOLD < effectiveBalance || effectiveBalance + UPWARD_THRESHOLD < balance) {
if (
// Too big
effectiveBalance > balance + DOWNWARD_THRESHOLD ||
// Too small. Check effectiveBalance < MAX_EFFECTIVE_BALANCE to prevent unnecessary updates
(effectiveBalance < MAX_EFFECTIVE_BALANCE && effectiveBalance < balance - UPWARD_THRESHOLD)
) {
validators.update(i, {
effectiveBalance: bigIntMin(balance - (balance % EFFECTIVE_BALANCE_INCREMENT), MAX_EFFECTIVE_BALANCE),
});
Expand Down