apply feedback

ChainSafe · Dec 8, 2023 · 28c4e1f · 28c4e1f
1 parent 62b8f94
commit 28c4e1f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/beacon-node/src/chain/blocks/types.ts b/packages/beacon-node/src/chain/blocks/types.ts
@@ -99,7 +99,9 @@ export const getBlockInput = {
       });
     }
 
-    this.blockInputCache.set(blockHex, blockCache);
+    if (!this.blockInputCache.has(blockHex)) {
+      this.blockInputCache.set(blockHex, blockCache);
+    }
     const {block: signedBlock, blockBytes, blobsCache, availabilityPromise, resolveAvailability} = blockCache;
 
     if (signedBlock !== undefined) {

diff --git a/packages/beacon-node/src/chain/blocks/verifyBlocksDataAvailability.ts b/packages/beacon-node/src/chain/blocks/verifyBlocksDataAvailability.ts
@@ -97,6 +97,10 @@ async function maybeValidateBlobs(
   }
 }
 
+/**
+ * Wait for blobs to become available with a cutoff time. If fails then throw DATA_UNAVAILABLE error
+ * which may try unknownblock/blobs fill (by root).
+ */
 async function raceWithCutoff<T>(
   chain: {config: ChainForkConfig; genesisTime: UintNum64},
   blockInput: BlockInput,