[do not merge] feat(bindings): asyncAggregateWithRandomness by indices - #561
Closed
spiral-ladder wants to merge 2 commits into
Closed
[do not merge] feat(bindings): asyncAggregateWithRandomness by indices#561spiral-ladder wants to merge 2 commits into
spiral-ladder wants to merge 2 commits into
Conversation
… index
BREAKING: sets change shape from {pk: PublicKey, sig} to {index, sig}.
Public keys resolve from the process-wide pubkey cache on the JS thread
during setup, so callers skip the per-set getOrThrow and PublicKey object
crossing on the gossip attestation path. The aggregation math (parallel
Pippenger MSM on the BLS pool) is unchanged; the old by-object plumbing
in blst.zig is replaced by bindings/napi/aggregate_by_index.zig.
Unknown validator indices throw PubkeyIndexNotFound synchronously —
matching the previous behavior where the caller's getOrThrow threw.
The synchronous aggregateWithRandomness keeps its by-object shape as
the generic primitive for arbitrary (non-registry) keys.
twoeths
reviewed
Aug 13, 2026
twoeths
left a comment
twoeths
left a comment
Member
There was a problem hiding this comment.
as a library, we can define a completely new api for this and let lodestar decide
A scripted edit double-applied an import replacement, leaving duplicate identifiers that failed biome ci with parse errors.
Member
Author
yeah agree, this is just to show the diff |
spiral-ladder
changed the title
Member
Author
|
now that we fully switched to native verification in #562 we no longer need async agg with randomness, closing |
github-project-automation
Bot
moved this from In Progress
to Done
in Lodestar Team Coordination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.