Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions bindings/napi/blst.zig
Original file line number Diff line number Diff line change
Expand Up @@ -848,9 +848,12 @@ pub fn asyncAggregateWithRandomness(sets: js.Array) !js.Value {
data.sig_ptrs[i] = &data.sigs[i];
}

data.deferred = try env.createPromise();

const deferred_cleanup_value = try env.getUndefined();
const resource_name = try env.createStringUtf8("asyncAggregateWithRandomness");

// Until queue succeeds, this function owns the unqueued work handle. Deletion should
// not fail after successful creation. If that invariant breaks, later error cleanup may
// free `data` while the work handle still points to it.
const work = try env.createAsyncWork(
AsyncAggRandData,
null,
Expand All @@ -859,8 +862,18 @@ pub fn asyncAggregateWithRandomness(sets: js.Array) !js.Value {
asyncAggRand_complete,
data,
);
errdefer work.delete() catch |err| {
std.log.err("failed to delete unqueued async BLS work: {s}", .{@errorName(err)});
};

data.work = work.work;

// Settle the unreturned Promise so Node can release its deferred handle.
data.deferred = try env.createPromise();
errdefer data.deferred.resolve(deferred_cleanup_value) catch |err| {
std.log.err("failed to settle unreturned async BLS promise: {s}", .{@errorName(err)});
};

try work.queue();

return .{ .val = data.deferred.getPromise() };
Expand Down
Loading