revert: refactor(clock): single public Clock; internalize SlotClock - #489
Closed
GrapeBaBa wants to merge 2 commits into
Closed
revert: refactor(clock): single public Clock; internalize SlotClock#489GrapeBaBa wants to merge 2 commits into
GrapeBaBa wants to merge 2 commits into
Conversation
GrapeBaBa
changed the title
GrapeBaBa
changed the title
twoeths
approved these changes
Jul 15, 2026
Member
|
My feeling is that we don't need to revert commits that aren't signed. |
Contributor
Author
ok, so I can just close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #463 since merged mistake which not using signed commit