Repository navigation
feat: publish ARM64 musl bindings #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4fcb93f
feat: publish ARM64 musl bindings
nflaig 3d40493
fix: update ARM64 musl dependencies
nflaig 7f8fd0f
chore: update hashtree-z sha
matthewkeil 24d5c11
Merge branch 'nflaig/arm64-musl' of github.com:ChainSafe/lodestar-z i…
matthewkeil 5aed1ce
fix: keep ZAPI on v2
nflaig 473c3e8
Merge branch 'main' into nflaig/arm64-musl
spiral-ladder 2e3665f
chore: bump zapi to v2.x.0
spiral-ladder 1126d38
Merge branch 'main' into nflaig/arm64-musl
spiral-ladder 0cf92e5
fix: backport ARM64 musl support to ZAPI 2
nflaig b3b4cf1
chore: use backported zapi with prepare script
wemeetagain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this entry makes the publish workflow parse
zapi.targetswith the declared@chainsafe/zapidependency (pnpm zapi build-artifactsin.github/workflows/publish-bindings.yml), butpackage.json/pnpm-lock.yamlstill pin@chainsafe/zapito 2.0.0. That version's config parser only accepts its built-in target list, which does not includeaarch64-unknown-linux-musl, so the release job will fail withUnsupported targetbefore it can publish any bindings; runtime loading also keeps using the oldrequireNapiLibrarymapping. Please bump@chainsafe/zapiand the lockfile to the release containing ChainSafe/zapi#47 in the same change.Useful? React with 👍 / 👎.