fix(bindings): stop leaking the state-preload scratch slices - #471
Closed
GrapeBaBa wants to merge 1 commit into
Closed
fix(bindings): stop leaking the state-preload scratch slices#471GrapeBaBa wants to merge 1 commit into
GrapeBaBa wants to merge 1 commit into
Conversation
preloadValidatorsAndBalances discarded the slices returned by getAllReadonlyValues/getAll without freeing them — every call leaked ~240 MB of decoded validator values plus ~16 MB of balances from the global allocator (the TODO's "GC clears it anyway" reasoning does not apply on the Zig side). Free the scratch immediately, and warm the validator view via getAllReadonly (pointers) instead of decoding every validator into values — the cache warming is identical and the scratch drops from ~240 MB to ~16 MB.
Contributor
Author
|
Superseded by #459, which already frees both preload scratch slices. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preloadValidatorsAndBalancesdiscarded the slices returned bygetAllReadonlyValues/getAllwithout freeing them — every call leaked ~240 MB of decoded validator values plus ~16 MB of balances from the global allocator (the TODO's "GC clears it anyway" reasoning does not apply on the Zig side).getAllReadonly(pointers) instead of decoding every validator into values — the cache warming is identical (both routes go throughgetReadonly) and the scratch drops from ~240 MB to ~16 MB.Follow-up: once a void
prefetchAlllands on the list views (#466), this site can drop the scratch allocation entirely.