feat(STF): implement Gloas Fork by guha-rahul · Pull Request #462 · ChainSafe/lodestar-z

guha-rahul · 2026-07-02T10:09:54Z

This pr implements

The Gloas fork including EIP-7732
upgrades to use test vectors v1.7.0-alpha.11
supersedes feat(STF): implement Gloas Fork #303

spiral-ladder

first pass, mostly on utils/gloas.zig

spiral-ladder · 2026-07-06T12:25:38Z

+}
+
+pub fn canBuilderCoverBid(allocator: Allocator, state: *BeaconState(.gloas), builder_index: u64, bid_amount: u64) !bool {
+    var builders = try state.inner.get("builders");


Suggested change

var builders = try state.inner.get("builders");

var builders = try state.inner.getReadonly("builders");

spiral-ladder · 2026-07-06T13:36:21Z

+    var data: PtcWindowEpochCacheData = undefined;
+
+    for (0..preset.SLOTS_PER_EPOCH) |i| {
+        try ptc_window.getValue(undefined, i, &data.previous[i]);


out of scope of this PR, but would be nice if we had getReadonlyByRange for this usecase

spiral-ladder · 2026-07-06T15:43:29Z

One overarching thought that is out of scope of this PR is that I still kinda dislike the whole dumping of everything into utils/gloas.zig. We should probably separate the functions meaningfully by name. With that said that's not required here, in fact the current form makes it easier to review, but I'd like to have a followup PR to rearrange stuff eventually

spiral-ladder · 2026-07-06T17:31:07Z

#464 might've broken nextValue for this PR - refactored it to make use of some comptime facts to be more explicit, see PR for details

GrapeBaBa · 2026-07-11T05:36:11Z

I suggest to add some OOM/Double free fault injection test using the test_allocators and also run process_epoch/process_block bench before and after this change to see if any regression

…mmittees

guha-rahul · 2026-08-11T13:55:52Z

I suggest to add some OOM/Double free fault injection test using the test_allocators and also run process_epoch/process_block bench before and after this change to see if any regression

I did the benchmarking and found near to no regresssions.

spiral-ladder

reviewed process_withdrawals.zig and utils/gloas.zig

spiral-ladder · 2026-08-23T13:56:38Z

-    const processed_partial_withdrawals_count = expected_withdrawals_result.processed_partial_withdrawals_count;
-    const expected_withdrawals = expected_withdrawals_result.withdrawals.items;
-    const num_withdrawals = expected_withdrawals.len;
+    // [New in EIP-7732] Return early if parent block is empty


I think we can do without the [new in ...] comments

Suggested change

// [New in EIP-7732] Return early if parent block is empty

spiral-ladder · 2026-08-23T14:20:16Z

+    const latest_withdrawal = if (expected_withdrawals.len > 0) expected_withdrawals[expected_withdrawals.len - 1] else null;
+    if (latest_withdrawal) |lw| {
+        try state.setNextWithdrawalIndex(lw.index + 1);


We can probably skip the optional here

Suggested change

const latest_withdrawal = if (expected_withdrawals.len > 0) expected_withdrawals[expected_withdrawals.len - 1] else null;

if (latest_withdrawal) |lw| {

try state.setNextWithdrawalIndex(lw.index + 1);

if (expected_withdrawals.len > 0) {

try state.setNextWithdrawalIndex(expected_withdrawals[expected_withdrawals.len - 1].index + 1);

}

later below expected_withdrawals.len == preset.MAX_WITHDRAWALS_PER_PAYLOAD check necessarily means expected_withdrawals.len > 0

spiral-ladder · 2026-08-23T14:21:03Z

-/// Called by the block proposer to find a list of withdrawals to include in the block.
-///
-/// This list is assumed to be bounded by `preset.MAX_WITHDRAWALS_PER_PAYLOAD`.
-///
-/// Caller should deinit `withdrawal_balances` with .deinit() after use.
+// Consumer should deinit WithdrawalsResult with .deinit() after use


why was this removed? it's also not a doc comment (triple slash instead of double slash)

spiral-ladder · 2026-08-23T15:19:16Z

+/// Convert a builder index to a flagged validator index for use in Withdrawal containers.
+/// Spec: https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.1/specs/gloas/beacon-chain.md#new-convert_builder_index_to_validator_index
+pub fn convertBuilderIndexToValidatorIndex(builder_index: u64) u64 {
+    return if (hasBuilderIndexFlag(builder_index)) builder_index else builder_index | c.BUILDER_INDEX_FLAG;


this is idempotent so we don't need the if check

Suggested change

return if (hasBuilderIndexFlag(builder_index)) builder_index else builder_index | c.BUILDER_INDEX_FLAG;

return builder_index | c.BUILDER_INDEX_FLAG;

spiral-ladder · 2026-08-23T15:19:47Z

+/// Convert a flagged validator index back to a builder index.
+/// Spec: https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.1/specs/gloas/beacon-chain.md#new-convert_validator_index_to_builder_index
+pub fn convertValidatorIndexToBuilderIndex(validator_index: u64) u64 {
+    return if (hasBuilderIndexFlag(validator_index)) validator_index & ~c.BUILDER_INDEX_FLAG else validator_index;


Suggested change

return if (hasBuilderIndexFlag(validator_index)) validator_index & ~c.BUILDER_INDEX_FLAG else validator_index;

return validator_index & ~c.BUILDER_INDEX_FLAG;

spiral-ladder · 2026-08-23T15:23:33Z

+
+/// Check if a validator index represents a builder (has the builder flag set).
+/// Spec: https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.1/specs/gloas/beacon-chain.md#new-is_builder_index
+pub fn isBuilderIndex(validator_index: u64) bool {


this is just wrapping hasBuilderIndexFlag? We should move that here instead to align with spec

spiral-ladder · 2026-08-23T15:36:47Z

+    };
+
+    var domain: ct.primitive.Domain.Type = undefined;
+    computeDomain(c.DOMAIN_BUILDER_DEPOSIT, config.chain.GENESIS_FORK_VERSION, c.ZERO_HASH, &domain) catch return false;


a bit long, add a trailing comma and fmt

Suggested change

computeDomain(c.DOMAIN_BUILDER_DEPOSIT, config.chain.GENESIS_FORK_VERSION, c.ZERO_HASH, &domain) catch return false;

computeDomain(c.DOMAIN_BUILDER_DEPOSIT, config.chain.GENESIS_FORK_VERSION, c.ZERO_HASH, &domain,) catch return false;

spiral-ladder · 2026-08-23T15:40:43Z

+
+pub fn isAttestationSameSlotRootCache(root_cache: *RootCache(.gloas), data: *const ct.phase0.AttestationData.Type) !bool {


this should maybe even be in root_cache.zig

Suggested change

pub fn isAttestationSameSlotRootCache(root_cache: *RootCache(.gloas), data: *const ct.phase0.AttestationData.Type) !bool {

/// Use cached block roots to avoid repeated state root lookups while matching the spec's is_attestation_same_slot behavior.

pub fn isAttestationSameSlotRootCache(root_cache: *RootCache(.gloas), data: *const ct.phase0.AttestationData.Type) !bool {

spiral-ladder · 2026-08-23T15:59:56Z

We should also keep this aligned with the spec test version in https://github.com/ChainSafe/lodestar/blob/62b30e7337e3bbc1098037b0e856ef6b2f106466/spec-tests-version.json

edit: but this will need #99

guha-rahul and others added 16 commits July 2, 2026 04:07

update types and constants for alpha.11

adff6c1

process builder deposit and exit requests

d5d9743

remove builder voluntary exit handling

f1c7b92

process parent executionpayload

1c2a745

update Gloas execution payload bid checks

e92b837

update Gloas churn and preset constants

9e9ec68

update Gloas fork upgrade builder onboarding

11b2d37

account for builder withdrawals

45bc63f

update epoch processing and proposer lookahead

77a55a0

only clear slashed proposer pending payment

dd3bea3

support current gloas operation vectors

824870f

clean up

b95d6f6

add utility helpers

144abd5

port remaining Gloas STF helpers

4818d70

Merge branch 'ChainSafe:main' into gloas

e0e7fab

fix compile errors

2b63b1c

guha-rahul requested a review from a team as a code owner July 2, 2026 10:09

guha-rahul added 5 commits July 2, 2026 15:48

fix getExpectedWithdrawals call sites

09aea6d

enforce Capella payload parent hash

b712803

remove stale payload envelope processor

2da2377

mirror PTC window in epoch cache

af826e9

remove unused helper functions

8084292

guha-rahul marked this pull request as draft July 5, 2026 10:35

spiral-ladder reviewed Jul 6, 2026

View reviewed changes

guha-rahul added 4 commits July 7, 2026 14:19

add doc comments as upstream

7feecea

more comments and getReadonly instead of get

ec5fcdb

make PendingDepositsLookup self-contained

27def7e

refactor pending deposits lookup

8cd5adb

guha-rahul mentioned this pull request Jul 7, 2026

Add readonly range access for SSZ list views #467

Open

guha-rahul added 2 commits July 7, 2026 15:52

nit order

42264fc

merge main into gloas

83d93d2

compute PTC from epoch shufflings

32e4623

matthewkeil added this to Lodestar Team Coordination Jul 27, 2026

matthewkeil moved this to Ready in Lodestar Team Coordination Jul 27, 2026

matthewkeil assigned guha-rahul Jul 27, 2026

guha-rahul added 7 commits August 11, 2026 17:39

merge main into gloas

d58bfb9

refactor(state-transition): thread std.Io through gloas paths

70ab912

fix(state-transition): correct error-path cleanup in shuffling and co…

3085fa9

…mmittees

test(state-transition): add gloas block generator

3b465d1

test(state-transition): add gloas OOM/double-free fault injection suite

7bb374f

merge main into gloas

8920763

merge main into gloas

63b6365

guha-rahul marked this pull request as ready for review August 11, 2026 13:55

andreolf mentioned this pull request Aug 21, 2026

feat(ssz): add getReadonlyByRange for composite tree views #586

Closed

Merge branch 'main' into gloas

4a4aa44

spiral-ladder requested changes Aug 23, 2026

View reviewed changes

guha-rahul closed this Aug 25, 2026

github-project-automation Bot moved this from Ready to Done in Lodestar Team Coordination Aug 25, 2026

	var builders = try state.inner.get("builders");
	var builders = try state.inner.getReadonly("builders");

	return if (hasBuilderIndexFlag(builder_index)) builder_index else builder_index \| c.BUILDER_INDEX_FLAG;
	return builder_index \| c.BUILDER_INDEX_FLAG;

	return if (hasBuilderIndexFlag(validator_index)) validator_index & ~c.BUILDER_INDEX_FLAG else validator_index;
	return validator_index & ~c.BUILDER_INDEX_FLAG;

	computeDomain(c.DOMAIN_BUILDER_DEPOSIT, config.chain.GENESIS_FORK_VERSION, c.ZERO_HASH, &domain) catch return false;
	computeDomain(c.DOMAIN_BUILDER_DEPOSIT, config.chain.GENESIS_FORK_VERSION, c.ZERO_HASH, &domain,) catch return false;


		pub fn isAttestationSameSlotRootCache(root_cache: RootCache(.gloas), data: const ct.phase0.AttestationData.Type) !bool {

Uh oh!

Conversation

guha-rahul commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spiral-ladder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spiral-ladder commented Jul 6, 2026

Uh oh!

spiral-ladder commented Jul 6, 2026

Uh oh!

GrapeBaBa commented Jul 11, 2026

Uh oh!

guha-rahul commented Aug 11, 2026

Uh oh!

spiral-ladder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spiral-ladder commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guha-rahul commented Jul 2, 2026 •

edited

Loading

spiral-ladder commented Aug 23, 2026 •

edited

Loading