fix: do not set start index for deposit request pre fulu - #440
Merged
spiral-ladder merged 1 commit intoJun 22, 2026
Merged
Conversation
This was causing a spec test failure in v1.7.0-alpha.10 spec tests, reproducible with `zig build test:spec_tests -Dpreset=minimal -Dspec_tests.filters="fulu transition transition_with_deposit_request_right_after_fork"`. See: https://github.com/ChainSafe/lodestar/blob/f6b2af6879db8092cdaf0dad41b3a098ff391a4a/packages/state-transition/src/block/processDepositRequest.ts#L133
spiral-ladder
changed the title
spiral-ladder
merged commit Jun 22, 2026
a6c4e29
into
bing/spec-tests-version
21 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing a spec test failure, reproducible with
zig build test:spec_tests -Dpreset=minimal -Dspec_tests.filters="fulu transition transition_with_deposit_request_right_after_fork"after #441 is mergedSee: https://github.com/ChainSafe/lodestar/blob/f6b2af6879db8092cdaf0dad41b3a098ff391a4a/packages/state-transition/src/block/processDepositRequest.ts#L133