-
Notifications
You must be signed in to change notification settings - Fork 16
chore: remove merge transition code #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0f06678
599dfdb
940f16c
675215d
8fbf38f
3ce4390
787ab66
2288018
6b149a7
fd96543
0aaabd3
a417fd9
4dffaeb
0c6d3ad
760dccc
78a8427
dc66acb
67ebed4
596aa1d
5196f67
07652a8
246aa29
fc4f1b8
09a214f
7647102
12dd46e
5837b0d
53018d0
cd5e017
8462c8f
ddbf084
37181bd
3f3e3b7
20a41a5
eabd6fc
4d02bac
08503f8
f0e6bc5
c5681b4
f9f8a89
e73c6d4
c5753a5
d8b795b
2276bc5
eb609db
8bbbb34
04a869a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,9 +75,7 @@ pub fn processExecutionPayload( | |
| // the state transition sync | ||
| // | ||
| // Equivalent to `assert executionEngine.notifyNewPayload(payload) | ||
| if (external_data.execution_payload_status == .pre_merge) { | ||
| return error.ExecutionPayloadStatusPreMerge; | ||
| } else if (external_data.execution_payload_status == .invalid) { | ||
| if (external_data.execution_payload_status == .invalid) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
While the removal of the |
||
| return error.InvalidExecutionPayload; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new implementation uses an
ifstatement that only handles the negative case (.invalid). According to the repository style guide (Lines 134-138), it is preferred to handle or assert both positive and negative spaces. Additionally, this function lacks the required minimum of two assertions per function (Line 54). Consider using aswitchstatement to explicitly handle all enum variants and adding assertions for the function arguments to improve safety and clarity.References