Cayman/232 review

bench/state_transition/process_epoch.zig

@@ -698,11 +698,11 @@ fn runBenchmark(
     const validators = try beacon_state.?.validatorsSlice(allocator);
     defer allocator.free(validators);
 
-    try state_transition.syncPubkeys(validators, &pubkey_index_map, &index_pubkey_cache);
+    try state_transition.syncPubkeys(validators, &pubkey_index_map, index_pubkey_cache);
 
     const immutable_data = state_transition.EpochCacheImmutableData{
         .config = &beacon_config,
-        .index_to_pubkey = &index_pubkey_cache,
+        .index_to_pubkey = index_pubkey_cache,
         .pubkey_to_index = &pubkey_index_map,
     };
 

bindings/napi/BeaconStateView.zig

@@ -778,7 +778,7 @@ pub fn BeaconStateView_createMultiProof(env: napi.Env, cb: napi.CallbackInfo(1))
     // Get the root node from the state
     try cached_state.state.commit();
     const root_node = switch (cached_state.state.*) {
-        inline else => |*state| state.base_view.data.root,
+        inline else => |state| state.root,
     };
 
     // Create proof input for compact multi-proof
@@ -880,7 +880,7 @@ pub fn BeaconStateView_serialize(env: napi.Env, cb: napi.CallbackInfo(0)) !napi.
 pub fn BeaconStateView_serializedSize(env: napi.Env, cb: napi.CallbackInfo(0)) !napi.Value {
     const cached_state = try env.unwrap(CachedBeaconState, cb.this());
     const size = switch (cached_state.state.*) {
-        inline else => |*state| try state.serializedSize(),
+        inline else => |state| try state.serializedSize(),
     };
     return try env.createInt64(@intCast(size));
 }
@@ -902,7 +902,7 @@ pub fn BeaconStateView_serializeToBytes(env: napi.Env, cb: napi.CallbackInfo(2))
 
     const output_slice = output_info.data[offset..];
     const bytes_written = switch (cached_state.state.*) {
-        inline else => |*state| try state.serializeIntoBytes(output_slice),
+        inline else => |state| try state.serializeIntoBytes(output_slice),
     };
 
     return try env.createInt64(@intCast(bytes_written));

src/consensus_types/phase0.zig

@@ -19,7 +19,7 @@ pub const Checkpoint = ssz.FixedContainerType(struct {
     root: p.Root,
 });
 
-pub const Validator = ssz.FixedContainerType(struct {
+pub const Validator = ssz.StructContainerType(struct {
     pubkey: p.BLSPubkey,
     withdrawal_credentials: p.Root,
     effective_balance: p.Gwei,