chore: update to new libp2p interface with types#146
Merged
vasco-santos merged 7 commits intomasterfrom Dec 19, 2020
Merged
Conversation
vasco-santos
force-pushed
the
chore/update-to-new-libp2p-interface-with-types
branch
2 times, most recently
from
ab236f8 to
6434366
Compare
6 tasks
vasco-santos
force-pushed
the
chore/update-to-new-libp2p-interface-with-types
branch
from
6434366 to
96e37e8
Compare
Collaborator
Author
|
cc @wemeetagain |
vasco-santos
force-pushed
the
chore/update-to-new-libp2p-interface-with-types
branch
from
6a90990 to
7f729a1
Compare
vasco-santos
force-pushed
the
chore/update-to-new-libp2p-interface-with-types
branch
from
7f729a1 to
2257656
Compare
vasco-santos
commented
Dec 16, 2020
| "noImplicitThis": true, | ||
| "strictFunctionTypes": true, | ||
| "strictNullChecks": true, | ||
| "skipLibCheck": true, |
Collaborator
Author
There was a problem hiding this comment.
It seems that typescript@4.1.3 released yesterday broke a type def... Still need to check, we have been experiencing a lot of issues with typescript releases changing outputs of ts declaration files generated.
vasco-santos
force-pushed
the
chore/update-to-new-libp2p-interface-with-types
branch
2 times, most recently
from
cb4e151 to
429f83a
Compare
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 2 2
Lines 25 25
=======================================
Hits 23 23
Misses 2 2 Continue to review full report at Codecov.
|
vasco-santos
force-pushed
the
chore/update-to-new-libp2p-interface-with-types
branch
2 times, most recently
from
f8c9c89 to
5a1cfca
Compare
vasco-santos
force-pushed
the
chore/update-to-new-libp2p-interface-with-types
branch
from
5a1cfca to
784b6e9
Compare
vasco-santos
deleted the
chore/update-to-new-libp2p-interface-with-types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libp2p-interfacesnow supports via aegir types generation on release. This PR updates gossipsub to use it and fixes a couple of ts issues.At the moment, it is using a branch from the PR below that has a
preparescript to generate the build while we do not release it.Needs: