Closed
Conversation
`emitSelf` appears to default to `true`
|
|
vasco-santos
reviewed
Nov 9, 2020
Collaborator
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Hey @DanPen
The emitSelf should be false by default. If you check the pubsub interface, you can see it. On libp2p, the default is overwritten on its config. Maybe this where the confusion appeared?
We are keeping the emitSelf to be true on libp2p to avoid the breaking change, but we should move on that way.
1 task
Collaborator
|
The emitSelf default was changed on libp2p. Going to close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emitSelfappears to default totrue